Update::run_updates() - Code Metrics - Inspection of "Minify scripts" - moonstonemedia/Simple-Calendar - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( afae5e...fce50c )

unknown

created 2015-12-31 22:12 UTC

Update::run_updates() C

↳ Parent: Update

Complexity

Conditions	10
Paths	20

Size

Total Lines	51
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	51
rs	6
cc	10
eloc	28
nc	20
nop	0

How to fix Long Method Complexity

<?php
/**
 * Update Plugin
 *
 * @package SimpleCalendar/Updates
 */
namespace SimpleCalendar;

if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

/**
 * Update script.
 *
 * Updates the installed plugin to the current version.
 *
 * @since 3.0.0
 */
class Update {

	/**
	 * Previous version.
	 *
	 * @access protected
	 * @var string
	 */
	private $installed_ver = '0.0.0';

	/**
	 * Current version.
	 *
	 * @access private
	 * @var string
	 */
	private $new_ver = '0.0.0';

	/**
	 * Existing posts.
	 *
	 * @access private
	 * @var array
	 */
	private $posts = array();

	/**
	 * Update path.
	 *
	 * @access private
	 *
	 * @var array
	 */
	private $update_path = array(
		'2.1.0',
		'2.2.0',
		'3.0.0',
	);

	/**
	 * Constructor.
	 *
	 * @since 3.0.0
	 *
	 * @param string $version (optional) Current plugin version, defaults to value in plugin constant.
	 */
	public function __construct( $version = SIMPLE_CALENDAR_VERSION ) {
		// Look for previous version in current or legacy option, null for fresh install.
		$installed = get_option( 'simple-calendar_version', null );
		$this->installed_ver = is_null( $installed ) ? get_option( 'gce_version', null ) : $installed;
		$this->new_ver = $version;

		if ( version_compare( $this->installed_ver, $this->new_ver, '<' ) ) {
			$this->run_updates();
		}
	}

	/**
	 * Update to current version.
	 *
	 * Runs all the update scripts through version steps.
	 *
	 * @since 3.0.0
	 */
	public function run_updates() {

		do_action( 'simcal_before_update', $this->installed_ver );

		if ( ! is_null( $this->installed_ver ) ) {

			if ( version_compare( $this->installed_ver, $this->new_ver ) === -1 ) {

				$post_type = version_compare( $this->installed_ver, '3.0.0' ) === -1 ? 'gce_feed' : 'calendar';
				$this->posts = $this->get_posts( $post_type );

				foreach ( $this->update_path as $update_to ) {
					if ( version_compare( $this->installed_ver, $update_to, '<' ) ) {
						$this->update( $update_to );
					}
				}


			}

			simcal_delete_feed_transients();

		} else {

			new Post_Types();
			flush_rewrite_rules();

		}

		do_action( 'simcal_updated', $this->new_ver );

		// Redirect to a welcome page if new install or major update.
		if ( is_null( $this->installed_ver ) ) {
			set_transient( '_simple-calendar_activation_redirect', 'fresh', 60 );
		} else {
			$major_new = substr( $this->new_ver, 0, strrpos( $this->new_ver, '.' ) );
			$major_old = substr( $this->installed_ver, 0, strrpos( $this->installed_ver, '.' ) );
			if ( version_compare( $major_new, $major_old, '>' ) ) {
				set_transient( '_simple-calendar_activation_redirect', 'update', 60 );
			} elseif ( $major_old == $major_new ) {
				$version = explode( '.', $this->new_ver );
				end( $version );
				if ( 0 === intval( current( $version ) ) ) {
					set_transient( '_simple-calendar_activation_redirect', 'update', 60 );
				}
			}
		}

		$this->admin_redirects();

		update_option( 'simple-calendar_version', $this->new_ver );
	}

	/**
	 * Handle redirects to welcome page after install and updates.
	 *
	 * Transient must be present, the user must have access rights, and we must ignore the network/bulk plugin updaters.
	 *
	 * @since 3.0.0
	 */
	public function admin_redirects() {

		$transient = get_transient( '_simple-calendar_activation_redirect' );

		if ( ! $transient || is_network_admin() || isset( $_GET['activate-multi'] ) || ! current_user_can( 'manage_options' ) ) {

			return;
		}

		delete_transient( '_simple-calendar_activation_redirect' );

		// Do not redirect if already on welcome page screen.
		if ( ! empty( $_GET['page'] ) && in_array( $_GET['page'], array( 'simple-calendar_about' ) ) ) {

			return;
		}

		$url = add_query_arg(
				'simcal_install',

				esc_attr( $transient ),

				admin_url( 'index.php?page=simple-calendar_about' )

		);
		wp_safe_redirect( $url );
		exit;
	}

	/**
	 * Get posts.
	 *
	 * @since  3.0.0
	 *
	 * @param  $post_type
	 *
	 * @return array
	 */
	private function get_posts( $post_type ) {

		$posts = array();

		if ( ! empty( $post_type ) ) {

			// https://core.trac.wordpress.org/ticket/18408
			$posts = get_posts( array(
				'post_type'   => $post_type,
				'post_status' => array(
					'draft',
					'future',
					'publish',
					'pending',
					'private',
					'trash',
				),
				'nopaging'    => true,

			) );

			wp_reset_postdata();
		}

		return $posts;
	}

	/**
	 * Update.
	 *
	 * Runs an update script for the specified version passed in argument.
	 *
	 * @since 3.0.0
	 *
	 * @param string $version
	 */
	private function update( $version ) {

		$update_v = '\\' . __NAMESPACE__ . '\Updates\\Update_V' . str_replace( '.', '', $version );

		if ( class_exists( $update_v ) ) {
			new $update_v( $this->posts );
		}
	}

}


1			<?php
2			/**
3			* Update Plugin
4			*
5			* @package SimpleCalendar/Updates
6			*/
7			namespace SimpleCalendar;
8
9			if ( ! defined( 'ABSPATH' ) ) {
10			exit;
11			}
12
13			/**
14			* Update script.
15			*
16			* Updates the installed plugin to the current version.
17			*
18			* @since 3.0.0
19			*/
20			class Update {
21
22			/**
23			* Previous version.
24			*
25			* @access protected
26			* @var string
27			*/
28			private $installed_ver = '0.0.0';
29
30			/**
31			* Current version.
32			*
33			* @access private
34			* @var string
35			*/
36			private $new_ver = '0.0.0';
37
38			/**
39			* Existing posts.
40			*
41			* @access private
42			* @var array
43			*/
44			private $posts = array();
45
46			/**
47			* Update path.
48			*
49			* @access private
50			*
51			* @var array
52			*/
53			private $update_path = array(
54			'2.1.0',
55			'2.2.0',
56			'3.0.0',
57			);
58
59			/**
60			* Constructor.
61			*
62			* @since 3.0.0
63			*
64			* @param string $version (optional) Current plugin version, defaults to value in plugin constant.
65			*/
66			public function __construct( $version = SIMPLE_CALENDAR_VERSION ) {
67			// Look for previous version in current or legacy option, null for fresh install.
68			$installed = get_option( 'simple-calendar_version', null );
69			$this->installed_ver = is_null( $installed ) ? get_option( 'gce_version', null ) : $installed;
70			$this->new_ver = $version;
71
72			if ( version_compare( $this->installed_ver, $this->new_ver, '<' ) ) {
73			$this->run_updates();
74			}
75			}
76
77			/**
78			* Update to current version.
79			*
80			* Runs all the update scripts through version steps.
81			*
82			* @since 3.0.0
83			*/
84			public function run_updates() {
85
86			do_action( 'simcal_before_update', $this->installed_ver );
87
88			if ( ! is_null( $this->installed_ver ) ) {
89
90			if ( version_compare( $this->installed_ver, $this->new_ver ) === -1 ) {
91
92			$post_type = version_compare( $this->installed_ver, '3.0.0' ) === -1 ? 'gce_feed' : 'calendar';
93			$this->posts = $this->get_posts( $post_type );
94
95			foreach ( $this->update_path as $update_to ) {
96			if ( version_compare( $this->installed_ver, $update_to, '<' ) ) {
97			$this->update( $update_to );
98			}
99			}
			1 ignored issue – show introduced 2015-11-25 01:38 UTC by Report Bug Copy Issue Report Blank line found after control structure Loading history...
100
101			}
102
103			simcal_delete_feed_transients();
104
105			} else {
106
107			new Post_Types();
108			flush_rewrite_rules();
109
110			}
111
112			do_action( 'simcal_updated', $this->new_ver );
113
114			// Redirect to a welcome page if new install or major update.
115			if ( is_null( $this->installed_ver ) ) {
116			set_transient( '_simple-calendar_activation_redirect', 'fresh', 60 );
117			} else {
118			$major_new = substr( $this->new_ver, 0, strrpos( $this->new_ver, '.' ) );
119			$major_old = substr( $this->installed_ver, 0, strrpos( $this->installed_ver, '.' ) );
120			if ( version_compare( $major_new, $major_old, '>' ) ) {
121			set_transient( '_simple-calendar_activation_redirect', 'update', 60 );
122			} elseif ( $major_old == $major_new ) {
123			$version = explode( '.', $this->new_ver );
124			end( $version );
125			if ( 0 === intval( current( $version ) ) ) {
126			set_transient( '_simple-calendar_activation_redirect', 'update', 60 );
127			}
128			}
129			}
130
131			$this->admin_redirects();
132
133			update_option( 'simple-calendar_version', $this->new_ver );
134			}
135
136			/**
137			* Handle redirects to welcome page after install and updates.
138			*
139			* Transient must be present, the user must have access rights, and we must ignore the network/bulk plugin updaters.
140			*
141			* @since 3.0.0
142			*/
143			public function admin_redirects() {
144
145			$transient = get_transient( '_simple-calendar_activation_redirect' );
146
147			if ( ! $transient \|\| is_network_admin() \|\| isset( $_GET['activate-multi'] ) \|\| ! current_user_can( 'manage_options' ) ) {
			1 ignored issue – show introduced 2015-11-25 01:38 UTC by Report Bug Copy Issue Report Detected access of super global var $_GET, probably need manual inspection. Loading history...
148			return;
149			}
150
151			delete_transient( '_simple-calendar_activation_redirect' );
152
153			// Do not redirect if already on welcome page screen.
154			if ( ! empty( $_GET['page'] ) && in_array( $_GET['page'], array( 'simple-calendar_about' ) ) ) {
			2 ignored issues – show introduced 2015-11-25 01:38 UTC by Report Bug Copy Issue Report Detected access of super global var $_GET, probably need manual inspection. Loading history... introduced 2015-11-25 01:38 UTC by Report Bug Copy Issue Report Detected usage of a non-sanitized input variable: $_GET Loading history...
155			return;
156			}
157
158			$url = add_query_arg(
159			'simcal_install',
			0 ignored issues – show Coding Style introduced 2015-12-31 22:15 UTC by Report Bug Copy Issue Report This line of the multi-line function call does not seem to be indented correctly. Expected `12` spaces, but found `16`. Loading history...
160			esc_attr( $transient ),
			0 ignored issues – show Coding Style introduced 2015-12-31 22:15 UTC by Report Bug Copy Issue Report This line of the multi-line function call does not seem to be indented correctly. Expected `12` spaces, but found `16`. Loading history...
161			admin_url( 'index.php?page=simple-calendar_about' )
			0 ignored issues – show Coding Style introduced 2015-12-31 22:15 UTC by Report Bug Copy Issue Report This line of the multi-line function call does not seem to be indented correctly. Expected `12` spaces, but found `16`. Loading history...
162			);
163			wp_safe_redirect( $url );
164			exit;
165			}
166
167			/**
168			* Get posts.
169			*
170			* @since 3.0.0
171			*
172			* @param $post_type
173			*
174			* @return array
175			*/
176			private function get_posts( $post_type ) {
177
178			$posts = array();
179
180			if ( ! empty( $post_type ) ) {
181
182			// https://core.trac.wordpress.org/ticket/18408
183			$posts = get_posts( array(
184			'post_type' => $post_type,
185			'post_status' => array(
186			'draft',
187			'future',
188			'publish',
189			'pending',
190			'private',
191			'trash',
192			),
193			'nopaging' => true,
			1 ignored issue – show introduced 2015-11-25 01:38 UTC by Report Bug Copy Issue Report Disabling pagination is prohibited in VIP context, do not set `nopaging` to `true` ever. Loading history...
194			) );
195
196			wp_reset_postdata();
197			}
198
199			return $posts;
200			}
201
202			/**
203			* Update.
204			*
205			* Runs an update script for the specified version passed in argument.
206			*
207			* @since 3.0.0
208			*
209			* @param string $version
210			*/
211			private function update( $version ) {
212
213			$update_v = '\\' . __NAMESPACE__ . '\Updates\\Update_V' . str_replace( '.', '', $version );
214
215			if ( class_exists( $update_v ) ) {
216			new $update_v( $this->posts );
217			}
218			}
219
220			}
221

moonstonemedia / Simple-Calendar

Push — master ( afae5e...fce50c )

Update::run_updates() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like