SimpleCalendar\Admin\Metaboxes\Settings::settings_handle()

Complexity

Conditions	15
Paths	675

Size

Total Lines	91
Code Lines	52

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	private static function settings_handle( $post ) {

		$feed_options = $calendar_options = $calendar_views = array();

		$feed_types = simcal_get_feed_types();
		foreach ( $feed_types as $feed_type ) {

			$feed = simcal_get_feed( $feed_type );

			if ( $feed instanceof Feed ) {
				$feed_options[ $feed_type ] = $feed->name;
			}
		}

		$calendar_types = simcal_get_calendar_types();
		foreach ( $calendar_types as $calendar_type => $views ) {

			$calendar = simcal_get_calendar( $calendar_type );

			if ( $calendar instanceof Calendar ) {
				$calendar_options[ $calendar_type ] = $calendar->name;
				$calendar_views[ $calendar_type ]   = $calendar->views;
			}
		}

		if ( $feed_options ) {

The expression $feed_options of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

			if ( $feed_types = wp_get_object_terms( $post->ID, 'calendar_feed' ) ) {
				$feed_type = sanitize_title( current( $feed_types )->name );
			} else {
				$feed_type = apply_filters( 'simcal_default_feed_type', 'google' );
			}

			?>
			<label for="_feed_type"><span><?php _e( 'Event Source', 'google-calendar-events' ); ?></span>
				<select name="_feed_type" id="_feed_type">
					<optgroup label="<?php _ex( 'Get events from', 'From which calendar source to load events from', 'google-calendar-events' ) ?>">
						<?php foreach ( $feed_options as $feed => $name ) { ?>
							<option value="<?php echo $feed; ?>" <?php selected( $feed, $feed_type, true ); ?>><?php echo $name; ?></option>
						<?php } ?>
					</optgroup>
				</select>
			</label>
			<?php

		}

		if ( $calendar_options ) {

The expression $calendar_options of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

			if ( $calendar_types = wp_get_object_terms( $post->ID, 'calendar_type' ) ) {
				$calendar_type = sanitize_title( current( $calendar_types )->name );
			} else {
				$calendar_type = apply_filters( 'simcal_default_calendar_type', 'default-calendar' );
			}

			?>
			<label for="_calendar_type"><span><?php _e( 'Calendar Type', 'google-calendar-events' ); ?></span>
				<select name="_calendar_type" id="_calendar_type">
					<optgroup label="<?php _e( 'Calendar to use', 'google-calendar-events' ); ?>">
						<?php foreach ( $calendar_options as $calendar => $name ) { ?>
							<option value="<?php echo $calendar; ?>" <?php selected( $calendar, $calendar_type, true ); ?>><?php echo $name; ?></option>
						<?php } ?>
					</optgroup>
				</select>
			</label>
			<?php

			if ( $calendar_views ) {

The expression $calendar_views of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

				$calendar_view = get_post_meta( $post->ID, '_calendar_view', true );

				foreach ( $calendar_views as $calendar => $views ) {

					$calendar_type_view = isset( $calendar_view[ $calendar ] ) ? $calendar_view[ $calendar ] : '';

					?>
					<label for="_calendar_view_<?php echo $calendar; ?>"><span><?php _e( 'View', 'google-calendar-events' ); ?></span>
						<select name="_calendar_view[<?php echo $calendar; ?>]" id="_calendar_view_<?php echo $calendar; ?>">
							<optgroup label="<?php _e( 'View to display', 'google-calendar-events' ); ?>">
								<?php foreach ( $views as $view => $name ) { ?>
									<option value="<?php echo $view; ?>" <?php selected( $view, $calendar_type_view, true ); ?>><?php echo $name; ?></option>
								<?php } ?>
							</optgroup>
						</select>
					</label>
					<?php

				}
			}
		}
	}