Setting::attributeLabels() - Code Metrics - Inspection of "phpunit" - monster-hunter/yii2-settings - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b812ef...80282b )

by monster

created 2017-08-08 09:50 UTC

Setting::attributeLabels() A

↳ Parent: Setting

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
ccs	10
cts	10
cp	1
rs	9.4285
cc	1
eloc	10
nc	1
nop	0
crap	1

<?php
/**
 * @link http://phe.me
 * @copyright Copyright (c) 2014 Pheme
 * @license MIT http://opensource.org/licenses/MIT
 */

namespace pheme\settings\models;

use Yii;
use yii\helpers\Json;
use yii\base\DynamicModel;
use pheme\settings\Module;
use yii\base\InvalidParamException;

/**
 * This is the model class for table "settings".
 *
 * @author Aris Karageorgos <[email protected]>
 */
class Setting extends BaseSetting
{
    /**
     * @param bool $forDropDown if false - return array or validators, true - key=>value for dropDown
     * @return array
     */
    public function getTypes($forDropDown = true)
    {
        $values = [
            'string' => ['value', 'string'],
            'integer' => ['value', 'integer'],
            'boolean' => ['value', 'boolean', 'trueValue' => "1", 'falseValue' => "0", 'strict' => true],
            'float' => ['value', 'number'],
            'email' => ['value', 'email'],
            'ip' => ['value', 'ip'],
            'url' => ['value', 'url'],
            'object' => [
                'value',
                function ($attribute, $params) {

                    $object = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                    try {
                        Json::decode($this->$attribute);
                    } catch (InvalidParamException $e) {
                        $this->addError($attribute, Module::t('settings', '"{attribute}" must be a valid JSON object', [
                            'attribute' => $attribute,
                        ]));
                    }
                }
            ],
        ];

        if (!$forDropDown) {
            return $values;
        }

        $return = [];
        foreach ($values as $key => $value) {
            $return[$key] = Module::t('settings', $key);
        }

        return $return;
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            [['value'], 'string'],
            [['section', 'key'], 'string', 'max' => 255],
            [
                ['key'],
                'unique',
                'targetAttribute' => ['section', 'key'],
                'message' =>
                    Module::t('settings', '{attribute} "{value}" already exists for this section.')
            ],
            ['type', 'in', 'range' => array_keys($this->getTypes(false))],
            [['type', 'created', 'modified'], 'safe'],
            [['active'], 'boolean'],
        ];
    }

    public function beforeSave($insert)
    {
        $validators = $this->getTypes(false);
        if (!array_key_exists($this->type, $validators)) {
            $this->addError('type', Module::t('settings', 'Please select correct type'));
            return false;
        }

        $model = DynamicModel::validateData([
            'value' => $this->value
        ], [
            $validators[$this->type],
        ]);

        if ($model->hasErrors()) {
            $this->addError('value', $model->getFirstError('value'));
            return false;
        }

        if ($this->hasErrors()) {
            return false;
        }

        return parent::beforeSave($insert);
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'id' => Module::t('settings', 'ID'),
            'type' => Module::t('settings', 'Type'),
            'section' => Module::t('settings', 'Section'),
            'key' => Module::t('settings', 'Key'),
            'value' => Module::t('settings', 'Value'),
            'active' => Module::t('settings', 'Active'),
            'created' => Module::t('settings', 'Created'),
            'modified' => Module::t('settings', 'Modified'),
        ];
    }
}


1		<?php
2		/**
3		* @link http://phe.me
4		* @copyright Copyright (c) 2014 Pheme
5		* @license MIT http://opensource.org/licenses/MIT
6		*/
7
8		namespace pheme\settings\models;
9
10		use Yii;
11		use yii\helpers\Json;
12		use yii\base\DynamicModel;
13		use pheme\settings\Module;
14		use yii\base\InvalidParamException;
15
16		/**
17		* This is the model class for table "settings".
18		*
19		* @author Aris Karageorgos <[email protected]>
20		*/
21		class Setting extends BaseSetting
22		{
23		/**
24		* @param bool $forDropDown if false - return array or validators, true - key=>value for dropDown
25		* @return array
26		*/
27	18	public function getTypes($forDropDown = true)
28		{
29		$values = [
30	18	'string' => ['value', 'string'],
31	18	'integer' => ['value', 'integer'],
32	18	'boolean' => ['value', 'boolean', 'trueValue' => "1", 'falseValue' => "0", 'strict' => true],
33	18	'float' => ['value', 'number'],
34	18	'email' => ['value', 'email'],
35	18	'ip' => ['value', 'ip'],
36	18	'url' => ['value', 'url'],
37		'object' => [
38	18	'value',
39		function ($attribute, $params) {
		0 ignored issues – show Unused Code introduced 2017-08-08 09:01 UTC by Report Bug Copy Issue Report The parameter `$params` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
40		$object = null;
		0 ignored issues – show Unused Code introduced 2017-08-08 09:01 UTC by Report Bug Copy Issue Report `$object` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
41		try {
42		Json::decode($this->$attribute);
43		} catch (InvalidParamException $e) {
44		$this->addError($attribute, Module::t('settings', '"{attribute}" must be a valid JSON object', [
45		'attribute' => $attribute,
46		]));
47		}
48		}
49	18	],
50	18	];
51
52	18	if (!$forDropDown) {
53	18	return $values;
54		}
55
56	1	$return = [];
57	1	foreach ($values as $key => $value) {
58	1	$return[$key] = Module::t('settings', $key);
59	1	}
60
61	1	return $return;
62		}
63
64		/**
65		* @inheritdoc
66		*/
67	18	public function rules()
68		{
69		return [
70	18	[['value'], 'string'],
71	18	[['section', 'key'], 'string', 'max' => 255],
72		[
73	18	['key'],
74	18	'unique',
75	18	'targetAttribute' => ['section', 'key'],
76		'message' =>
77	18	Module::t('settings', '{attribute} "{value}" already exists for this section.')
78	18	],
79	18	['type', 'in', 'range' => array_keys($this->getTypes(false))],
80	18	[['type', 'created', 'modified'], 'safe'],
81	18	[['active'], 'boolean'],
82	18	];
83		}
84
85	17	public function beforeSave($insert)
86		{
87	17	$validators = $this->getTypes(false);
88	17	if (!array_key_exists($this->type, $validators)) {
89		$this->addError('type', Module::t('settings', 'Please select correct type'));
90		return false;
91		}
92
93	17	$model = DynamicModel::validateData([
94	17	'value' => $this->value
95	17	], [
96	17	$validators[$this->type],
97	17	]);
98
99	17	if ($model->hasErrors()) {
100	1	$this->addError('value', $model->getFirstError('value'));
101	1	return false;
102		}
103
104	17	if ($this->hasErrors()) {
105		return false;
106		}
107
108	17	return parent::beforeSave($insert);
109		}
110
111		/**
112		* @inheritdoc
113		*/
114	2	public function attributeLabels()
115		{
116		return [
117	2	'id' => Module::t('settings', 'ID'),
118	2	'type' => Module::t('settings', 'Type'),
119	2	'section' => Module::t('settings', 'Section'),
120	2	'key' => Module::t('settings', 'Key'),
121	2	'value' => Module::t('settings', 'Value'),
122	2	'active' => Module::t('settings', 'Active'),
123	2	'created' => Module::t('settings', 'Created'),
124	2	'modified' => Module::t('settings', 'Modified'),
125	2	];
126		}
127		}
128

monster-hunter / yii2-settings

Push — master ( b812ef...80282b )

Setting::attributeLabels() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like