monsterhunter\yii2\log\controllers\DefaultController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	79
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	behaviors()	0	12	1
A	actionIndex()	0	18	2
A	actionView()	0	6	1
A	actionDelete()	0	6	1
A	findModel()	0	8	2

<?php

namespace monsterhunter\yii2\log\controllers;

use monsterhunter\yii2\log\models\search\SystemLogSearch;
use monsterhunter\yii2\log\models\SystemLog;
use yii;
use yii\filters\VerbFilter;
use yii\web\Controller;
use yii\web\NotFoundHttpException;

/**
 * LogController implements the CRUD actions for SystemLog models.
 */
class DefaultController extends Controller
{
    public function behaviors()
    {
        return [
            'verbs' => [
                'class' => VerbFilter::className(),

The method yii\base\BaseObject::className() has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead.

                'actions' => [
                    'delete' => ['post'],
                    'clear' => ['post'],
                ],
            ],
        ];
    }

    /**
     * Lists all SystemLog models.
     * @return mixed
     */
    public function actionIndex()
    {
        $searchModel = new SystemLogSearch();
        $dataProvider = $searchModel->search(Yii::$app->request->queryParams);

        if (strcasecmp(Yii::$app->request->method, 'delete') == 0) {
            SystemLog::deleteAll($dataProvider->query->where);

Accessing where on the interface yii\db\QueryInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            return $this->refresh();
        }
        $dataProvider->sort = [
            'defaultOrder' => ['log_time' => SORT_DESC]
        ];

        return $this->render('index', [
            'searchModel' => $searchModel,
            'dataProvider' => $dataProvider,
        ]);
    }

    /**
     * Displays a single SystemLog models.
     * @param integer $id
     * @return mixed
     */
    public function actionView($id)
    {
        return $this->render('view', [
            'model' => $this->findModel($id),
        ]);
    }

    /**
     * Deletes an existing SystemLog models.
     * If deletion is successful, the browser will be redirected to the 'index' page.
     * @param integer $id
     * @return mixed
     */
    public function actionDelete($id)
    {
        $this->findModel($id)->delete();

        return $this->redirect(['index']);
    }

    /**
     * Finds the SystemLog models based on its primary key value.
     * If the models is not found, a 404 HTTP exception will be thrown.
     * @param integer $id
     * @return SystemLog the loaded models
     * @throws NotFoundHttpException if the models cannot be found
     */
    protected function findModel($id)
    {
        if (($model = SystemLog::findOne($id)) !== null) {

The expression \monsterhunter\yii2\log\models\SystemLog::findOne($id); of type yii\db\ActiveRecordInterface|array|null adds the type array to the return on line 88 which is incompatible with the return type documented by monsterhunter\yii2\log\controllers\DefaultController::findModel of type monsterhunter\yii2\log\models\SystemLog.

            return $model;
        } else {
            throw new NotFoundHttpException('The requested page does not exist.');
        }
    }
}