Kernel - Code Metrics - Inspection of "Prepare v2.0" - monsieurbiz/SyliusRichEditorPlugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#35)

by Jacques

created 2020-09-20 17:49 UTC

Kernel A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
eloc	20
dl	0
loc	41
rs	10
c	1
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	configureRoutes()	7	1
A	registerBundles()	6	3
A	configureContainer()	11	2
A	getProjectDir()	3	1

<?php

/*
 * This file is part of Monsieur Biz' Rich Editor plugin for Sylius.
 *
 * (c) Monsieur Biz <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace App;

use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
use Symfony\Component\Config\Loader\LoaderInterface;
use Symfony\Component\Config\Resource\FileResource;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Kernel as BaseKernel;
use Symfony\Component\Routing\RouteCollectionBuilder;

class Kernel extends BaseKernel
{
    use MicroKernelTrait;

    private const CONFIG_EXTS = '.{php,xml,yaml,yml}';

    public function registerBundles(): iterable
    {
        $contents = require $this->getProjectDir() . '/config/bundles.php';
        foreach ($contents as $class => $envs) {
            if ($envs[$this->environment] ?? $envs['all'] ?? false) {
                yield new $class();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            }
        }
    }

    public function getProjectDir(): string
    {
        return \dirname(__DIR__);
    }

    protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader): void
    {
        $container->addResource(new FileResource($this->getProjectDir() . '/config/bundles.php'));
        $container->setParameter('container.dumper.inline_class_loader', \PHP_VERSION_ID < 70400 || $this->debug);
        $container->setParameter('container.dumper.inline_factories', true);
        $confDir = $this->getProjectDir() . '/config';

        $loader->load($confDir . '/{packages}/*' . self::CONFIG_EXTS, 'glob');
        $loader->load($confDir . '/{packages}/' . $this->environment . '/*' . self::CONFIG_EXTS, 'glob');
        $loader->load($confDir . '/{services}' . self::CONFIG_EXTS, 'glob');
        $loader->load($confDir . '/{services}_' . $this->environment . self::CONFIG_EXTS, 'glob');
    }

    protected function configureRoutes(RouteCollectionBuilder $routes): void
    {
        $confDir = $this->getProjectDir() . '/config';

        $routes->import($confDir . '/{routes}/' . $this->environment . '/*' . self::CONFIG_EXTS, '/', 'glob');
        $routes->import($confDir . '/{routes}/*' . self::CONFIG_EXTS, '/', 'glob');
        $routes->import($confDir . '/{routes}' . self::CONFIG_EXTS, '/', 'glob');
    }
}


1			<?php
2
3			/*
4			* This file is part of Monsieur Biz' Rich Editor plugin for Sylius.
5			*
6			* (c) Monsieur Biz <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace App;
15
16			use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
17			use Symfony\Component\Config\Loader\LoaderInterface;
18			use Symfony\Component\Config\Resource\FileResource;
19			use Symfony\Component\DependencyInjection\ContainerBuilder;
20			use Symfony\Component\HttpKernel\Kernel as BaseKernel;
21			use Symfony\Component\Routing\RouteCollectionBuilder;
22
23			class Kernel extends BaseKernel
24			{
25			use MicroKernelTrait;
26
27			private const CONFIG_EXTS = '.{php,xml,yaml,yml}';
28
29			public function registerBundles(): iterable
30			{
31			$contents = require $this->getProjectDir() . '/config/bundles.php';
32			foreach ($contents as $class => $envs) {
33			if ($envs[$this->environment] ?? $envs['all'] ?? false) {
34			yield new $class();
			0 ignored issues – show Bug Best Practice introduced 2020-09-20 16:39 UTC by Report Bug Copy Issue Report The expression `yield new $class()` returns the type `Generator` which is incompatible with the return type mandated by `Symfony\Component\HttpKe...face::registerBundles()` of `Symfony\Component\HttpKe...dleInterface[]\|iterable`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
35			}
36			}
37			}
38
39			public function getProjectDir(): string
40			{
41			return \dirname(__DIR__);
42			}
43
44			protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader): void
45			{
46			$container->addResource(new FileResource($this->getProjectDir() . '/config/bundles.php'));
47			$container->setParameter('container.dumper.inline_class_loader', \PHP_VERSION_ID < 70400 \|\| $this->debug);
48			$container->setParameter('container.dumper.inline_factories', true);
49			$confDir = $this->getProjectDir() . '/config';
50
51			$loader->load($confDir . '/{packages}/*' . self::CONFIG_EXTS, 'glob');
52			$loader->load($confDir . '/{packages}/' . $this->environment . '/*' . self::CONFIG_EXTS, 'glob');
53			$loader->load($confDir . '/{services}' . self::CONFIG_EXTS, 'glob');
54			$loader->load($confDir . '/{services}_' . $this->environment . self::CONFIG_EXTS, 'glob');
55			}
56
57			protected function configureRoutes(RouteCollectionBuilder $routes): void
58			{
59			$confDir = $this->getProjectDir() . '/config';
60
61			$routes->import($confDir . '/{routes}/' . $this->environment . '/*' . self::CONFIG_EXTS, '/', 'glob');
62			$routes->import($confDir . '/{routes}/*' . self::CONFIG_EXTS, '/', 'glob');
63			$routes->import($confDir . '/{routes}' . self::CONFIG_EXTS, '/', 'glob');
64			}
65			}
66

monsieurbiz / SyliusRichEditorPlugin

Pull Request — master (#35)

Kernel A

Complexity

Size/Duplication

Importance

4 Methods

Duplication Side-by-Side

Filter issues like