Monospice\LaravelRedisSentinel\Connections\PredisSentinelConnection

Complexity

Total Complexity

2

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	transaction()	0	8	2

<?php

namespace Monospice\LaravelRedisSentinel\Connections;

use Illuminate\Redis\Connections\PredisConnection;

class PredisSentinelConnection extends PredisConnection
{
    /**
     * Execute commands in a transaction.  Avoids use of Predis transaction
     * which does not support aggregate connections.  Mirrors implementation
     * of PhpRedisConnection::transaction() in core Framework.
     *
     * @param  callable  $callback

Should the type for parameter $callback not be null|callable? Also, consider making the array more specific, something like array<String>, or String[].

     * @return \Redis|array
     */
    public function transaction(callable $callback = null)
    {
        $transaction = $this->client()->multi();

        return is_null($callback)
            ? $transaction
            : tap($this->client(), $callback)->exec();
    }
}