DevPontes\Route\Traits\Matcher

Complexity

Total Complexity

7

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	match()	0	13	3
A	setParam()	0	14	4

<?php

namespace DevPontes\Route\Traits;

use DevPontes\Route\Router;

trait Matcher
{
    /**
     * Set param
     *
     * @param string $routeUrl
     * @return string
     */
    protected function setParam(string $routeUrl): string
    {
        $routeUrl = explode('/', $routeUrl);

        foreach ($routeUrl as $k => $v) {
            if (preg_match('/^\{.*\}$/', $v) && (count($this->url) == count($routeUrl))) {
                $routeUrl[$k] = $this->url[$k];
                $this->param  = $this->url[$k];

The property param does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }

            $route = implode('/', $routeUrl);
        }

        return $route;

The variable $route seems to be defined by a foreach iteration on line 19. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }

    /**
     * Find the corresponding route based on the given URL
     *
     * @param array $url
     * @return Router|null
     */
    protected function match(array $url): ?Router
    {
        $url = implode('/', $url);

        foreach ($this->routes as $route) {
            $routeurl = $this->setParam($route->getUrl());

            if ($routeurl == $url) {
                return $route;
            }
        }

        return null;
    }
}