RefundTest::testRefundBankAccountFull() - Code Metrics - Inspection of "Merge pull request #125 from caiogaspar/hotfix/ref..." - moip/moip-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4b77f9...4fb3b2 )

by Jean C.

created 2017-06-27 16:45 UTC

RefundTest::testRefundBankAccountFull() A

↳ Parent: RefundTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	9

Duplication

Lines	10
Ratio	90.91 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	9
c	1
b	0
f	0
nc	1
nop	0
dl	10
loc	11
rs	9.4285

<?php

namespace Moip\Tests\Resource;

use Moip\Tests\TestCase;

class RefundTest extends TestCase
{

    public function testRefundBankAccountFull()

    {
        $this->mockHttpSession($this->body_order);
        $order = $this->createOrder()->create();
        $this->mockHttpSession($this->body_billet_pay);
        $payment = $order->payments()->get('PAY-N2TXFLV4PP7Y');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->mockHttpSession($this->body_refund_full_bankaccount);
        $refund = $payment->refunds()
            ->bankAccountFull('CHECKING', '001', '1584', '9', '00210169', '6', $order->getCustomer());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertNotEmpty($refund->getId());
    }
    
    public function testRefundBankAccountPartial()

    {
        $this->mockHttpSession($this->body_order);
        $order = $this->createOrder()->create();
        $this->mockHttpSession($this->body_billet_pay);
        $payment = $order->payments()->get('PAY-N2TXFLV4PP7Y');
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->mockHttpSession($this->body_refund_partial_bankaccount);
        $refund = $payment->refunds()
            ->bankAccountPartial(20000, 'SAVING', '001', '1584', '9', '00210169', '6', $order->getCustomer());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertNotEmpty($refund->getId());
    }
}


Push — master ( 4b77f9...4fb3b2 )

RefundTest::testRefundBankAccountFull() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Moip\Tests\Resource;
4
5		use Moip\Tests\TestCase;
6
7		class RefundTest extends TestCase
8		{
9
10	View Code Duplication	public function testRefundBankAccountFull()
		0 ignored issues – show Duplication introduced 2017-06-27 15:07 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		$this->mockHttpSession($this->body_order);
13		$order = $this->createOrder()->create();
14		$this->mockHttpSession($this->body_billet_pay);
15		$payment = $order->payments()->get('PAY-N2TXFLV4PP7Y');
		0 ignored issues – show Bug introduced 2017-06-27 15:07 UTC by Report Bug Copy Issue Report The method `payments` does only exist in `Moip\Resource\Orders`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
16		$this->mockHttpSession($this->body_refund_full_bankaccount);
17		$refund = $payment->refunds()
18		->bankAccountFull('CHECKING', '001', '1584', '9', '00210169', '6', $order->getCustomer());
		0 ignored issues – show Bug introduced 2017-06-27 15:07 UTC by Report Bug Copy Issue Report The method `getCustomer` does only exist in `Moip\Resource\Orders`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
19		$this->assertNotEmpty($refund->getId());
20		}
21
22	View Code Duplication	public function testRefundBankAccountPartial()
		0 ignored issues – show Duplication introduced 2017-06-27 15:07 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		$this->mockHttpSession($this->body_order);
25		$order = $this->createOrder()->create();
26		$this->mockHttpSession($this->body_billet_pay);
27		$payment = $order->payments()->get('PAY-N2TXFLV4PP7Y');
		0 ignored issues – show Bug introduced 2017-06-27 15:07 UTC by Report Bug Copy Issue Report The method `payments` does only exist in `Moip\Resource\Orders`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
28		$this->mockHttpSession($this->body_refund_partial_bankaccount);
29		$refund = $payment->refunds()
30		->bankAccountPartial(20000, 'SAVING', '001', '1584', '9', '00210169', '6', $order->getCustomer());
		0 ignored issues – show Bug introduced 2017-06-27 15:07 UTC by Report Bug Copy Issue Report The method `getCustomer` does only exist in `Moip\Resource\Orders`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
31		$this->assertNotEmpty($refund->getId());
32		}
33		}
34

moip / moip-sdk-php

Push — master ( 4b77f9...4fb3b2 )

RefundTest::testRefundBankAccountFull() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like