LinksTest - Code Metrics - Inspection of "Issue 126" - moip/moip-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#144)

unknown

created 2017-07-26 17:30 UTC

LinksTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	33.33 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
dl	10
loc	30
rs	10
c	2
b	0
f	0
wmc	3
lcom	1
cbo	2

3 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetLinkWithoutCheckout()	10	10	1
A	testGetCheckoutLink()	0	8	1
A	testGetAllCheckoutLinks()	0	7	1

How to fix Duplicated Code

<?php

namespace Moip\Tests\Helper;

use Moip\Tests\TestCase;

class LinksTest extends TestCase
{    

    public function testGetLinkWithoutCheckout()

    {
        $this->sandbox_mock = self::MOCK;
        $this->mockHttpSession($this->body_order);
        $order = $this->createOrder()->create();
        $this->mockHttpSession($this->body_billet_pay);
        $payment = $order->payments()->setBoleto(new \DateTime('today +1day'), 'http://dev.moip.com.br/images/logo-header-moip.png')->execute();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $this->assertEquals('https://checkout-sandbox.moip.com.br/boleto/PAY-XNVIBO5MIQ9S', $payment->getLinks()->getLink('payBoleto'));
    }

    public function testGetCheckoutLink()
    {
        $this->sandbox_mock = self::MOCK;
        $this->mockHttpSession($this->body_order);
        $order = $this->createOrder()->create();

        $this->assertEquals('https://checkout-sandbox.moip.com.br/creditcard/ORD-HG479ZEIB7LV', $order->getLinks()->getCheckout('payCreditCard'));
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    public function testGetAllCheckoutLinks()
    {
        $this->mockHttpSession($this->body_order);
        $order = $this->createOrder()->create();

        $this->assertNotEmpty($order->getLinks()->getAllCheckout());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


Pull Request — master (#144)

LinksTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Moip\Tests\Helper;
4
5		use Moip\Tests\TestCase;
6
7		class LinksTest extends TestCase
8		{
		0 ignored issues – show Coding Style introduced 2017-07-26 17:32 UTC by Report Bug Copy Issue Report The opening class brace should be on a newline by itself. Loading history...
9	View Code Duplication	public function testGetLinkWithoutCheckout()
		0 ignored issues – show Duplication introduced 2017-07-26 17:32 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		{
11		$this->sandbox_mock = self::MOCK;
12		$this->mockHttpSession($this->body_order);
13		$order = $this->createOrder()->create();
14		$this->mockHttpSession($this->body_billet_pay);
15		$payment = $order->payments()->setBoleto(new \DateTime('today +1day'), 'http://dev.moip.com.br/images/logo-header-moip.png')->execute();
		0 ignored issues – show Bug introduced 2017-07-07 17:15 UTC by Report Bug Copy Issue Report The method `payments` does only exist in `Moip\Resource\Orders`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
16
17		$this->assertEquals('https://checkout-sandbox.moip.com.br/boleto/PAY-XNVIBO5MIQ9S', $payment->getLinks()->getLink('payBoleto'));
18		}
19
20		public function testGetCheckoutLink()
21		{
22		$this->sandbox_mock = self::MOCK;
23		$this->mockHttpSession($this->body_order);
24		$order = $this->createOrder()->create();
25
26		$this->assertEquals('https://checkout-sandbox.moip.com.br/creditcard/ORD-HG479ZEIB7LV', $order->getLinks()->getCheckout('payCreditCard'));
		0 ignored issues – show Bug introduced 2017-07-26 17:32 UTC by Report Bug Copy Issue Report The method `getLinks` does only exist in `Moip\Resource\Orders`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
27		}
28
29		public function testGetAllCheckoutLinks()
30		{
31		$this->mockHttpSession($this->body_order);
32		$order = $this->createOrder()->create();
33
34		$this->assertNotEmpty($order->getLinks()->getAllCheckout());
		0 ignored issues – show Bug introduced 2017-07-26 17:32 UTC by Report Bug Copy Issue Report The method `getLinks` does only exist in `Moip\Resource\Orders`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
35		}
36		}
37

moip / moip-sdk-php

Pull Request — master (#144)

LinksTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like