PaymentTest - Code Metrics - Inspection of "Feature/adding escrow payments" - moip/moip-sdk-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#133)

unknown

created 2017-07-07 14:08 UTC

PaymentTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	58
Duplicated Lines	37.93 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
dl	22
loc	58
rs	10
c	1
b	1
f	0
wmc	4
lcom	1
cbo	2

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testBillet()	0	9	1
A	testCreditCardPCI()	0	13	1
A	testCreditCardPCIStore()	10	10	1
A	testShouldCreateEscrowPaymentWithCreditCard()	12	12	1

How to fix Duplicated Code

<?php

namespace Moip\Tests\Resource;

use Moip\Tests\TestCase;

class PaymentTest extends TestCase
{
    //todo: credit card hash

    /**
     * MoipTest creating a credit card payment, passing all credit card data.
     */
    public function testCreditCardPCI()
    {
        $this->mockHttpSession($this->body_order);
        $order = $this->createOrder()->create();
        $this->mockHttpSession($this->body_cc_pay_pci);
        $cc = '5555666677778884';
        $payment = $order->payments()->setCreditCard(5, 2018, $cc, 123, $this->createCustomer())->execute();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertNotEmpty($payment->getFundingInstrument()->creditCard);
        $first6 = $payment->getFundingInstrument()->creditCard->first6;
        $last4 = $payment->getFundingInstrument()->creditCard->last4;
        $this->assertEquals($first6, substr($cc, 0, 6));
        $this->assertEquals($last4, substr($cc, -4));
    }

    /**
     * MoipTest creating a billet payment.
     */
    public function testBillet()
    {
        $this->mockHttpSession($this->body_order);
        $order = $this->createOrder()->create();
        $this->mockHttpSession($this->body_billet_pay);
        $payment = $order->payments()->setBoleto(new \DateTime('today +1day'),
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'http://dev.moip.com.br/images/logo-header-moip.png')->execute();
        $this->assertNotEmpty($payment->getFundingInstrument()->boleto);
    }

    public function testCreditCardPCIStore()

    {
        $this->mockHttpSession($this->body_order);
        $order = $this->createOrder()->create();
        $cc = '5555666677778884';
        $this->mockHttpSession($this->body_cc_pay_pci_store);
        $payment = $order->payments()->setCreditCard(5, 2018, $cc, 123, $this->createCustomer(), false)->execute();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $this->assertFalse($payment->getFundingInstrument()->creditCard->store);
        $this->assertNotEmpty($payment->getId());
    }
    
    public function testShouldCreateEscrowPaymentWithCreditCard() 

    {
        $this->mockHttpSession($this->body_order);
        $order = $this->createOrder()->create();
        $cc = '5555666677778884';
        $this->mockHttpSession($this->body_cc_pay_pci_escrow);
        $payment = $order->payments()
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->setCreditCard(5, 2018, $cc, 123, $this->createCustomer(), false)
            ->setEscrow('teste de descricao')
            ->execute();
        $this->assertEquals('teste de descricao', $payment->getEscrow()->description);
    }
}


Pull Request — master (#133)

PaymentTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Moip\Tests\Resource;
4
5		use Moip\Tests\TestCase;
6
7		class PaymentTest extends TestCase
8		{
9		//todo: credit card hash
10
11		/**
12		* MoipTest creating a credit card payment, passing all credit card data.
13		*/
14		public function testCreditCardPCI()
15		{
16		$this->mockHttpSession($this->body_order);
17		$order = $this->createOrder()->create();
18		$this->mockHttpSession($this->body_cc_pay_pci);
19		$cc = '5555666677778884';
20		$payment = $order->payments()->setCreditCard(5, 2018, $cc, 123, $this->createCustomer())->execute();
		0 ignored issues – show Bug introduced 2017-03-30 15:32 UTC by Report Bug Copy Issue Report The method `payments` does only exist in `Moip\Resource\Orders`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
21		$this->assertNotEmpty($payment->getFundingInstrument()->creditCard);
22		$first6 = $payment->getFundingInstrument()->creditCard->first6;
23		$last4 = $payment->getFundingInstrument()->creditCard->last4;
24		$this->assertEquals($first6, substr($cc, 0, 6));
25		$this->assertEquals($last4, substr($cc, -4));
26		}
27
28		/**
29		* MoipTest creating a billet payment.
30		*/
31		public function testBillet()
32		{
33		$this->mockHttpSession($this->body_order);
34		$order = $this->createOrder()->create();
35		$this->mockHttpSession($this->body_billet_pay);
36		$payment = $order->payments()->setBoleto(new \DateTime('today +1day'),
		0 ignored issues – show Bug introduced 2017-03-30 15:32 UTC by Report Bug Copy Issue Report The method `payments` does only exist in `Moip\Resource\Orders`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
37		'http://dev.moip.com.br/images/logo-header-moip.png')->execute();
38		$this->assertNotEmpty($payment->getFundingInstrument()->boleto);
39		}
40
41	View Code Duplication	public function testCreditCardPCIStore()
		0 ignored issues – show Duplication introduced 2017-07-07 14:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		{
43		$this->mockHttpSession($this->body_order);
44		$order = $this->createOrder()->create();
45		$cc = '5555666677778884';
46		$this->mockHttpSession($this->body_cc_pay_pci_store);
47		$payment = $order->payments()->setCreditCard(5, 2018, $cc, 123, $this->createCustomer(), false)->execute();
		0 ignored issues – show Bug introduced 2017-07-03 17:31 UTC by Report Bug Copy Issue Report The method `payments` does only exist in `Moip\Resource\Orders`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
48		$this->assertFalse($payment->getFundingInstrument()->creditCard->store);
49		$this->assertNotEmpty($payment->getId());
50		}
51
52	View Code Duplication	public function testShouldCreateEscrowPaymentWithCreditCard()
		0 ignored issues – show Duplication introduced 2017-07-07 14:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		{
54		$this->mockHttpSession($this->body_order);
55		$order = $this->createOrder()->create();
56		$cc = '5555666677778884';
57		$this->mockHttpSession($this->body_cc_pay_pci_escrow);
58		$payment = $order->payments()
		0 ignored issues – show Bug introduced 2017-07-07 14:09 UTC by Report Bug Copy Issue Report The method `payments` does only exist in `Moip\Resource\Orders`, but not in `stdClass`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
59		->setCreditCard(5, 2018, $cc, 123, $this->createCustomer(), false)
60		->setEscrow('teste de descricao')
61		->execute();
62		$this->assertEquals('teste de descricao', $payment->getEscrow()->description);
63		}
64		}
65

moip / moip-sdk-php

Pull Request — master (#133)

PaymentTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like