Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Payment often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Payment, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 11 | View Code Duplication | class Payment extends MoipResource |
|
| 12 | { |
||
| 13 | /** |
||
| 14 | * @const string |
||
| 15 | */ |
||
| 16 | const PATH = 'payments'; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @const string |
||
| 20 | */ |
||
| 21 | const MULTI_PAYMENTS_PATH = 'multipayments'; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @const string |
||
| 25 | */ |
||
| 26 | const SIMULATOR_PATH = 'simulador'; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * Payment means. |
||
| 30 | * |
||
| 31 | * @const string |
||
| 32 | */ |
||
| 33 | const METHOD_CREDIT_CARD = 'CREDIT_CARD'; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * Payment means. |
||
| 37 | * |
||
| 38 | * @const string |
||
| 39 | */ |
||
| 40 | const METHOD_BOLETO = 'BOLETO'; |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Payment means. |
||
| 44 | * |
||
| 45 | * @const string |
||
| 46 | */ |
||
| 47 | const METHOD_ONLINE_DEBIT = 'ONLINE_DEBIT'; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * Payment means. |
||
| 51 | * |
||
| 52 | * @const string |
||
| 53 | */ |
||
| 54 | const METHOD_WALLET = 'WALLET'; |
||
| 55 | |||
| 56 | /** |
||
| 57 | * Payment means. |
||
| 58 | * |
||
| 59 | * @const string |
||
| 60 | */ |
||
| 61 | const METHOD_ONLINE_BANK_DEBIT = 'ONLINE_BANK_DEBIT'; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * @var \Moip\Resource\Orders |
||
| 65 | */ |
||
| 66 | private $order; |
||
| 67 | |||
| 68 | /** |
||
| 69 | * Just created, but not initialized yet. |
||
| 70 | */ |
||
| 71 | const STATUS_CREATED = 'CREATED'; |
||
| 72 | |||
| 73 | /** |
||
| 74 | * Waiting for the payment. |
||
| 75 | */ |
||
| 76 | const STATUS_WAITING = 'WAITING'; |
||
| 77 | |||
| 78 | /** |
||
| 79 | * On risk analysis, it may be automatic or manual. |
||
| 80 | */ |
||
| 81 | const STATUS_IN_ANALYSIS = 'IN_ANALYSIS'; |
||
| 82 | |||
| 83 | /** |
||
| 84 | * The amount was reserved on client credit card, it may be caught or discarded until 5 days. |
||
| 85 | */ |
||
| 86 | const STATUS_PRE_AUTHORIZED = 'PRE_AUTHORIZED'; |
||
| 87 | |||
| 88 | /** |
||
| 89 | * Payment confirmed by the bank institution. |
||
| 90 | */ |
||
| 91 | const STATUS_AUTHORIZED = 'AUTHORIZED'; |
||
| 92 | |||
| 93 | /** |
||
| 94 | * Payment cancelled. |
||
| 95 | */ |
||
| 96 | const STATUS_CANCELLED = 'CANCELLED'; |
||
| 97 | |||
| 98 | /** |
||
| 99 | * Payment refunded. |
||
| 100 | */ |
||
| 101 | const STATUS_REFUNDED = 'REFUNDED'; |
||
| 102 | |||
| 103 | /** |
||
| 104 | * Paymend reversed (it means that the payment may was not recognized by the client). |
||
| 105 | */ |
||
| 106 | const STATUS_REVERSED = 'REVERSED'; |
||
| 107 | |||
| 108 | /** |
||
| 109 | * Payment finalized, the amout is on your account. |
||
| 110 | */ |
||
| 111 | const STATUS_SETTLED = 'SETTLED'; |
||
| 112 | |||
| 113 | /** |
||
| 114 | * @var \Moip\Resource\Multiorders |
||
| 115 | */ |
||
| 116 | private $multiorder; |
||
| 117 | |||
| 118 | /** |
||
| 119 | * Initializes new instances. |
||
| 120 | */ |
||
| 121 | protected function initialize() |
||
| 127 | |||
| 128 | /** |
||
| 129 | * Create a new payment in api MoIP. |
||
| 130 | * |
||
| 131 | * @return $this |
||
| 132 | */ |
||
| 133 | public function execute() |
||
| 146 | |||
| 147 | /** |
||
| 148 | * Get an payment and multipayment in MoIP. |
||
| 149 | * |
||
| 150 | * @param string $id_moip Id MoIP payment |
||
| 151 | * |
||
| 152 | * @return stdClass |
||
| 153 | */ |
||
| 154 | public function get($id_moip) |
||
| 162 | |||
| 163 | /** |
||
| 164 | * Get id MoIP payment. |
||
| 165 | * |
||
| 166 | * |
||
| 167 | * @return \Moip\Resource\Payment |
||
| 168 | */ |
||
| 169 | public function getId() |
||
| 173 | |||
| 174 | /** |
||
| 175 | * Mount payment structure. |
||
| 176 | * |
||
| 177 | * @param \stdClass $response |
||
| 178 | * |
||
| 179 | * @return Payment |
||
| 180 | */ |
||
| 181 | protected function populate(stdClass $response) |
||
| 202 | |||
| 203 | /** |
||
| 204 | * Refunds. |
||
| 205 | * |
||
| 206 | * @return Refund |
||
| 207 | */ |
||
| 208 | public function refunds() |
||
| 215 | |||
| 216 | /** |
||
| 217 | * Escrows. |
||
| 218 | * |
||
| 219 | * @return Escrow |
||
| 220 | */ |
||
| 221 | public function escrows() |
||
| 228 | |||
| 229 | /** |
||
| 230 | * Get payment status. |
||
| 231 | * |
||
| 232 | * @return string Payment status. Possible values CREATED, WAITING, IN_ANALYSIS, PRE_AUTHORIZED, AUTHORIZED, CANCELLED, REFUNDED, REVERSED, SETTLED |
||
| 233 | */ |
||
| 234 | public function getStatus() |
||
| 238 | |||
| 239 | /** |
||
| 240 | * get creation time. |
||
| 241 | * |
||
| 242 | * @return \DateTime |
||
| 243 | */ |
||
| 244 | public function getCreatedAt() |
||
| 248 | |||
| 249 | /** |
||
| 250 | * Returns when the last update occurred. |
||
| 251 | * |
||
| 252 | * @return \DateTime |
||
| 253 | */ |
||
| 254 | public function getUpdatedAt() |
||
| 258 | |||
| 259 | /** |
||
| 260 | * Returns the funding instrument. |
||
| 261 | * |
||
| 262 | * @return stdClass |
||
| 263 | */ |
||
| 264 | public function getFundingInstrument() |
||
| 269 | |||
| 270 | /** |
||
| 271 | * Get href to Boleto |
||
| 272 | **. |
||
| 273 | * |
||
| 274 | * @return stdClass |
||
| 275 | */ |
||
| 276 | public function getHrefBoleto() |
||
| 280 | |||
| 281 | /** |
||
| 282 | * Returns payment amount. |
||
| 283 | * |
||
| 284 | * @return stdClass |
||
| 285 | */ |
||
| 286 | public function getAmount() |
||
| 290 | |||
| 291 | /** |
||
| 292 | * Returns escrow. |
||
| 293 | * |
||
| 294 | * @return stdClass |
||
| 295 | */ |
||
| 296 | public function getEscrow() |
||
| 300 | |||
| 301 | /** |
||
| 302 | * Set means of payment. |
||
| 303 | * |
||
| 304 | * @param \stdClass $fundingInstrument |
||
| 305 | * |
||
| 306 | * @return $this |
||
| 307 | */ |
||
| 308 | public function setFundingInstrument(stdClass $fundingInstrument) |
||
| 314 | |||
| 315 | /** |
||
| 316 | * Set billet. |
||
| 317 | * |
||
| 318 | * @param \DateTime|string $expirationDate Expiration date of a billet. |
||
| 319 | * @param string $logoUri Logo of billet. |
||
| 320 | * @param array $instructionLines Instructions billet. |
||
| 321 | * |
||
| 322 | * @return $this |
||
| 323 | */ |
||
| 324 | public function setBoleto($expirationDate, $logoUri, array $instructionLines = []) |
||
| 345 | |||
| 346 | /** |
||
| 347 | * Set credit card holder. |
||
| 348 | * |
||
| 349 | * @param \Moip\Resource\Customer $holder |
||
| 350 | */ |
||
| 351 | private function setCreditCardHolder(Customer $holder) |
||
| 369 | |||
| 370 | /** |
||
| 371 | * Set credit cardHash. |
||
| 372 | * |
||
| 373 | * @param string $hash Credit card hash encripted using Moip.js |
||
| 374 | * @param \Moip\Resource\Customer $holder |
||
| 375 | * @param bool $store Flag to know if credit card should be saved. |
||
| 376 | * |
||
| 377 | * @return $this |
||
| 378 | */ |
||
| 379 | public function setCreditCardHash($hash, Customer $holder, $store = true) |
||
| 389 | |||
| 390 | /** |
||
| 391 | * Set credit card |
||
| 392 | * Credit card used in a payment. |
||
| 393 | * The card when returned within a parent resource is presented in its minimum representation. |
||
| 394 | * |
||
| 395 | * @param int $expirationMonth Card expiration month |
||
| 396 | * @param int $expirationYear Year of card expiration. |
||
| 397 | * @param string $number Card number. |
||
| 398 | * @param int $cvc Card Security Code. |
||
| 399 | * @param \Moip\Resource\Customer $holder |
||
| 400 | * @param bool $store Flag to know if credit card should be saved. |
||
| 401 | * |
||
| 402 | * @return $this |
||
| 403 | */ |
||
| 404 | public function setCreditCard($expirationMonth, $expirationYear, $number, $cvc, Customer $holder, $store = true) |
||
| 417 | |||
| 418 | /** |
||
| 419 | * Sets data from a previously saved credit card |
||
| 420 | * Credit card used in a payment. |
||
| 421 | * Used when the credit card was saved with the customer and the payment made in a future date. |
||
| 422 | * |
||
| 423 | * @param string $creditCardId MoIP's Credit Card Id. |
||
| 424 | * @param int $cvc Card Security Code. |
||
| 425 | * |
||
| 426 | * @return $this |
||
| 427 | */ |
||
| 428 | public function setCreditCardSaved($creditCardId, $cvc) |
||
| 438 | |||
| 439 | /** |
||
| 440 | * Set installment count. |
||
| 441 | * |
||
| 442 | * @param int $installmentCount |
||
| 443 | * |
||
| 444 | * @return $this |
||
| 445 | */ |
||
| 446 | public function setInstallmentCount($installmentCount) |
||
| 452 | |||
| 453 | /** |
||
| 454 | * Set statement descriptor. |
||
| 455 | * |
||
| 456 | * @param string $statementDescriptor |
||
| 457 | * |
||
| 458 | * @return $this |
||
| 459 | */ |
||
| 460 | public function setStatementDescriptor($statementDescriptor) |
||
| 466 | |||
| 467 | /** |
||
| 468 | * Set payment means made available by banks. |
||
| 469 | * |
||
| 470 | * @param string $bankNumber Bank number. Possible values: 001, 237, 341, 041. |
||
| 471 | * @param \DateTime|string $expirationDate Date of expiration debit. |
||
| 472 | * @param string $returnUri Return Uri. |
||
| 473 | * |
||
| 474 | * @return $this |
||
| 475 | */ |
||
| 476 | public function setOnlineBankDebit($bankNumber, $expirationDate, $returnUri) |
||
| 489 | |||
| 490 | /** |
||
| 491 | * Set Multiorders. |
||
| 492 | * |
||
| 493 | * @param \Moip\Resource\Multiorders $multiorder |
||
| 494 | * |
||
| 495 | * @return $this |
||
| 496 | */ |
||
| 497 | public function setMultiorder(Multiorders $multiorder) |
||
| 503 | |||
| 504 | /** |
||
| 505 | * Set order. |
||
| 506 | * |
||
| 507 | * @param \Moip\Resource\Orders $order |
||
| 508 | * |
||
| 509 | * @return $this |
||
| 510 | */ |
||
| 511 | public function setOrder(Orders $order) |
||
| 517 | |||
| 518 | /** |
||
| 519 | * Turns on a delay on credit card payment capture (pre-authorization). |
||
| 520 | * |
||
| 521 | * @return $this |
||
| 522 | */ |
||
| 523 | public function setDelayCapture() |
||
| 529 | |||
| 530 | /** |
||
| 531 | * Set escrow to a payment |
||
| 532 | * |
||
| 533 | * @param string $description |
||
| 534 | * |
||
| 535 | * @return $this |
||
| 536 | */ |
||
| 537 | public function setEscrow($description) |
||
| 544 | |||
| 545 | /** |
||
| 546 | * Capture a pre-authorized amount on a credit card payment. |
||
| 547 | * |
||
| 548 | * @throws \Exception |
||
| 549 | * |
||
| 550 | * @return Payment |
||
| 551 | */ |
||
| 552 | public function capture() |
||
| 564 | |||
| 565 | /** |
||
| 566 | * Avoid a pre-authorized amount on a credit card payment. |
||
| 567 | * |
||
| 568 | * @throws \Exception |
||
| 569 | * |
||
| 570 | * @return Payment |
||
| 571 | */ |
||
| 572 | public function avoid() |
||
| 584 | |||
| 585 | /** |
||
| 586 | * Authorize a payment (Available only in sandbox to credit card payment with status IN_ANALYSIS and billet payment with status WAITING). |
||
| 587 | * |
||
| 588 | * @return bool |
||
| 589 | */ |
||
| 590 | public function authorize($amount = null) |
||
| 604 | } |
||
| 605 |
This check looks for classes that have been defined more than once.
If you can, we would recommend to use standard object-oriented programming techniques. For example, to avoid multiple types, it might make sense to create a common interface, and then multiple, different implementations for that interface.
This also has the side-effect of providing you with better IDE auto-completion, static analysis and also better OPCode caching from PHP.