Fouladgar\MobileVerification\Http\Middleware\EnsureMobileIsVerified

Complexity

Total Complexity

5

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	11	5

<?php

namespace Fouladgar\MobileVerification\Http\Middleware;

use Closure;
use Fouladgar\MobileVerification\Contracts\MustVerifyMobile;

class EnsureMobileIsVerified
{
    /**
     * Handle an incoming request.
     *
     * @param $request
     * @param Closure $next
     * @param null    $redirectToRoute

Are you sure the doc-type for parameter $redirectToRoute is correct as it would always require null to be passed?

     *
     * @return mixed|void
     */
    public function handle($request, Closure $next, $redirectToRoute = null)

The parameter $redirectToRoute is not used and could be removed.

    {
        $user = auth()->user();

        if (! $user || ($user instanceof MustVerifyMobile && ! $user->hasVerifiedMobile())) {
            return $request->expectsJson()
                ? abort(403, 'Your mobile number is not verified.')

Are you sure the usage of abort(403, 'Your mobile number is not verified.') is correct as it seems to always return null.

                : redirect('/')->withErrors(['mobile' => 'Your mobile number is not verified.']);
        }

        return $next($request);
    }
}