moe-lk / bulk-upload

app/Notifications/ExportReady.php

<?php

namespace App\Notifications;

use App\Models\User;
use Illuminate\Bus\Queueable;
use Illuminate\Notifications\Notification;
use Illuminate\Contracts\Queue\ShouldQueue;
use App\Mail\ExportReady as MailExportReady;
use Illuminate\Notifications\Messages\MailMessage;

class ExportReady extends Notification
{
    use Queueable;

    /**
     * Create a new notification instance.
     *
     * @return void
     */
    public function __construct($user)
    {
        $this->user  = $user;

The property user does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function via($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return ['mail'];
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return (new MailExportReady($this->user));

The expression return new App\Mail\ExportReady($this->user) returns the type App\Mail\ExportReady which is incompatible with the documented return type Illuminate\Notifications\Messages\MailMessage.

    }

    /**
     * Get the array representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function toArray($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return [
            //
        ];
    }
}