moe-lk / bulk-upload

app/Console/Commands/ProcessTerminatedFiles.php

<?php

namespace App\Console\Commands;

use App\Mail\IncorrectTemplate;
use App\Mail\TerminatedReport;
use App\Models\Upload;
use App\Models\User;
use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Mail;

class ProcessTerminatedFiles extends ImportStudents
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'process:terminated';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Command description';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
            $files = $this->getFiles();
            try {
                if(!empty($files)){
                    array_walk($files,array($this,'process'));
                    unset($files);
                    exit();

Using exit here is not recommended.

                }else{
                    $output = new \Symfony\Component\Console\Output\ConsoleOutput();
                    $output->writeln('No files found,Waiting for files');
                    exit();

Using exit here is not recommended.

                }

            }catch (Exception $e){

The type App\Console\Commands\Exception was not found. Did you mean Exception? If so, make sure to prefix the type with \.

                $output = new \Symfony\Component\Console\Output\ConsoleOutput();
                $output->writeln($e);
                sleep(300);
                $this->handle();

            }

    }

    protected function getFiles(){
        $files = Upload::where('is_processed', '=', 3)
            ->where('is_email_sent','=',0)
            ->where('updated_at', '<=', Carbon::now()->tz('Asia/Colombo')->subHours(3))
            ->limit(50)
            ->get()->toArray();
        return $files;
    }

    protected function  process($file){
        $time = Carbon::now()->tz('Asia/Colombo');
        $this->processSheet($file);
        $output = new \Symfony\Component\Console\Output\ConsoleOutput();
        $now = Carbon::now()->tz('Asia/Colombo');
        $output->writeln('=============== Time taken to batch ' .$now->diffInMinutes($time));

    }

    protected function processSheet($file){
        $this->startTime = Carbon::now()->tz('Asia/Colombo');

The property startTime does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $user = User::find($file['security_user_id']);
        $output = new \Symfony\Component\Console\Output\ConsoleOutput();
        $output->writeln('##########################################################################################################################');
        $output->writeln('Processing the file: '.$file['filename']);
        if ($this->checkTime()) {
            Mail::to($user->email)->send(new TerminatedReport($file));

The property email does not seem to exist on App\Models\User. Are you sure there is no database migration missing?

            DB::table('uploads')
                ->where('id', $file['id'])
                ->update(['is_processed' => 3, 'is_email_sent' => 1,'updated_at' => now()]);
        } else {
            exit();

Using exit here is not recommended.

        }
    }



}