Test Setup Failed
Pull Request — master (#620)
by Mohamed
08:18
created
app/Console/Commands/MapStudentArea.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
      */
31 31
     public function __construct()
32 32
     {
33
-        $this->output =  new \Symfony\Component\Console\Output\ConsoleOutput();
33
+        $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
34 34
         parent::__construct();
35 35
     }
36 36
 
@@ -41,13 +41,13 @@  discard block
 block discarded – undo
41 41
      */
42 42
     public function handle()
43 43
     {
44
-        $students = Security_user::where('is_student',true)->get()->toArray();
45
-        array_walk($students,array($this,'process'));
44
+        $students = Security_user::where('is_student', true)->get()->toArray();
45
+        array_walk($students, array($this, 'process'));
46 46
     }
47 47
 
48
-    public function process($student){
48
+    public function process($student) {
49 49
         $student['student_id'] = $student['id'];
50 50
         Institution_student::updateStudentArea($student);
51
-        $this->output->writeln('area updated for student:'. $student['openemis_no']) ;
51
+        $this->output->writeln('area updated for student:'.$student['openemis_no']);
52 52
     }
53 53
 }
Please login to merge, or discard this patch.
app/Console/Commands/cleanConfig.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -48,16 +48,16 @@
 block discarded – undo
48 48
         $year = $this->argument('year');
49 49
         $academicPeriod = $this->academic_period->getAcademicPeriod($year);
50 50
         $previousAcademicPeriodYear = $academicPeriod->order;
51
-        $previousAcademicPeriod = Academic_period::where('order',$previousAcademicPeriodYear+1)->first();
51
+        $previousAcademicPeriod = Academic_period::where('order', $previousAcademicPeriodYear + 1)->first();
52 52
 
53 53
         $params = [
54 54
             'academic_period' => $academicPeriod,
55 55
             'previous_academic_period' => $previousAcademicPeriod
56 56
         ];
57 57
 
58
-        if($year == '2019' || $year == '2018/19'){
58
+        if ($year == '2019' || $year == '2018/19') {
59 59
             die('Academic Year 2019 or earlier can`t be deleted');
60
-        }else{
60
+        }else {
61 61
             $this->clone->cleanConfig($params);
62 62
         }
63 63
     }
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
 
58 58
         if($year == '2019' || $year == '2018/19'){
59 59
             die('Academic Year 2019 or earlier can`t be deleted');
60
-        }else{
60
+        } else{
61 61
             $this->clone->cleanConfig($params);
62 62
         }
63 63
     }
Please login to merge, or discard this patch.
app/Http/Controllers/CloneController.php 3 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
     public function array_walk($shift, $count, $params)
42 42
     {
43 43
         try{
44
-           DB::beginTransaction();
44
+            DB::beginTransaction();
45 45
             array_walk($shift, array($this, 'process'), $params);
46 46
             DB::commit();
47 47
         }catch(\Exception $e){
Please login to merge, or discard this patch.
Spacing   +35 added lines, -35 removed lines patch added patch discarded remove patch
@@ -31,21 +31,21 @@  discard block
 block discarded – undo
31 31
         $this->academic_period = new Academic_period();
32 32
         $this->institution_classes = new Institution_class();
33 33
         $this->institution_class_subjects = new Institution_class_subject();
34
-        $this->institution_subjects =  new Institution_subject();
34
+        $this->institution_subjects = new Institution_subject();
35 35
         $this->institution_grades = new Institution_grade();
36
-        $this->education_grade_subjects =  new Education_grades_subject();
36
+        $this->education_grade_subjects = new Education_grades_subject();
37 37
         $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
38 38
     }
39 39
 
40 40
 
41 41
     public function array_walk($shift, $count, $params)
42 42
     {
43
-        try{
43
+        try {
44 44
            DB::beginTransaction();
45 45
             array_walk($shift, array($this, 'process'), $params);
46 46
             DB::commit();
47
-        }catch(\Exception $e){
48
-            $this->output->writeln('Terminating ' . $shift['institution_id']);
47
+        }catch (\Exception $e) {
48
+            $this->output->writeln('Terminating '.$shift['institution_id']);
49 49
             DB::rollBack();
50 50
         }
51 51
     }
@@ -59,24 +59,24 @@  discard block
 block discarded – undo
59 59
         $this->shifts->where(['cloned' => $academicPeriod->code])->update(['cloned' => $params['previous_academic_period']['code']]);
60 60
         $this->output->writeln('updated shifts');
61 61
 
62
-        $classIds =  $this->institution_classes->select('id')->where(['academic_period_id' => $academicPeriod->id])->get()->toArray();
62
+        $classIds = $this->institution_classes->select('id')->where(['academic_period_id' => $academicPeriod->id])->get()->toArray();
63 63
         $this->institution_classes->where(['academic_period_id' => $academicPeriod->id])->delete();
64 64
         $this->output->writeln('cleaned classes');
65 65
 
66 66
         do {
67 67
             $deleted = $this->institution_class_subjects->whereRaw("institution_class_id not in (select id from institution_classes where academic_period_id =".$academicPeriod->id." )")->limit(10000)->delete();
68 68
             $this->output->writeln('cleaned subjects');
69
-        }while($deleted > 0);
69
+        } while ($deleted > 0);
70 70
 
71 71
         do {
72
-            $deleted =  $this->institution_subjects->where('academic_period_id', $academicPeriod->id)->limit(10000)->delete();
72
+            $deleted = $this->institution_subjects->where('academic_period_id', $academicPeriod->id)->limit(10000)->delete();
73 73
             $this->output->writeln('10000 institutions cleaned subjects');
74 74
         } while ($deleted > 0);
75 75
     }
76 76
 
77 77
     public function process($shift, $count, $params)
78 78
     {
79
-        echo ('[' . getmypid() . ']This Process executed at' . date("F d, Y h:i:s A") . "\n");
79
+        echo ('['.getmypid().']This Process executed at'.date("F d, Y h:i:s A")."\n");
80 80
         $year = $params['year'];
81 81
         $academicPeriod = $params['academic_period'];
82 82
         $previousAcademicPeriod = $params['previous_academic_period'];
@@ -94,14 +94,14 @@  discard block
 block discarded – undo
94 94
 
95 95
 
96 96
         if ($mode) {
97
-            $institutionClasses = $this->institution_classes->getShiftClasses($shift,  $mode);
97
+            $institutionClasses = $this->institution_classes->getShiftClasses($shift, $mode);
98 98
             try {
99 99
                 array_walk($institutionClasses, array($this, 'updateInstitutionClasses'), $params);
100
-                $this->output->writeln('updating from ' . $shift['institution_id']);
101
-            } catch (\Exception $e) {
100
+                $this->output->writeln('updating from '.$shift['institution_id']);
101
+            }catch (\Exception $e) {
102 102
                 Log::error($e->getMessage(), [$e]);
103 103
             }
104
-        } else {
104
+        }else {
105 105
             $institutionSubjects = $this->institution_grades->getGradeSubjects($shift['institution_id']);
106 106
             try {
107 107
                 if ($data['created']) {
@@ -112,32 +112,32 @@  discard block
 block discarded – undo
112 112
                         try {
113 113
                             array_walk($newInstitutionClasses, array($this, 'insertInstitutionClasses'), $params);
114 114
                             $this->output->writeln('##########################################################################################################################');
115
-                            $this->output->writeln('updating from = ' . $shift['institution_id']);
116
-                        } catch (\Exception $e) {
117
-                            $this->output->writeln('Terminating ' . $shift['institution_id']);
115
+                            $this->output->writeln('updating from = '.$shift['institution_id']);
116
+                        }catch (\Exception $e) {
117
+                            $this->output->writeln('Terminating '.$shift['institution_id']);
118 118
                             DB::rollBack();
119 119
                             Log::error($e->getMessage(), [$e]);
120 120
                         }
121
-                    } else {
122
-                        $this->output->writeln('no classes found ' . $shift['institution_id']);
121
+                    }else {
122
+                        $this->output->writeln('no classes found '.$shift['institution_id']);
123 123
                     }
124
-                } else {
124
+                }else {
125 125
                     try {
126 126
                         $shift['id'] = $shiftId;
127 127
                         $institutionClasses = $this->institution_classes->getShiftClasses($shift, $mode);
128 128
                         array_walk($institutionClasses, array($this, 'updateInstitutionClasses'), $params);
129 129
                         $this->output->writeln('##########################################################################################################################');
130
-                        $this->output->writeln('updating from ' . $shift['institution_id']);
131
-                    } catch (\Exception $e) {
132
-                        $this->output->writeln('Terminating ' . $shift['institution_id']);
130
+                        $this->output->writeln('updating from '.$shift['institution_id']);
131
+                    }catch (\Exception $e) {
132
+                        $this->output->writeln('Terminating '.$shift['institution_id']);
133 133
                         DB::rollBack();
134 134
                         Log::error($e->getMessage(), [$e]);
135 135
                     }
136 136
                 }
137 137
                 DB::commit();
138
-            } catch (\Exception $e) {
138
+            }catch (\Exception $e) {
139 139
                 Log::error($e->getMessage(), [$e]);
140
-                $this->output->writeln('Terminating ' . $shift['institution_id']);
140
+                $this->output->writeln('Terminating '.$shift['institution_id']);
141 141
                 DB::rollBack();
142 142
             }
143 143
         }
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
             $subject['created'] = now();
157 157
             $subject['created_user_id'] = 1;
158 158
             $this->institution_subjects->create($subject);
159
-        } catch (\Exception $e) {
159
+        }catch (\Exception $e) {
160 160
             DB::rollBack();
161 161
             Log::error($e->getMessage(), [$e]);
162 162
         }
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
                         'academic_period_id' => $params['academic_period_id']
186 186
                     ]);
187 187
             }
188
-        } catch (\Exception $e) {
188
+        }catch (\Exception $e) {
189 189
             DB::rollBack();
190 190
             Log::error($e->getMessage(), [$e]);
191 191
         }
@@ -215,8 +215,8 @@  discard block
 block discarded – undo
215 215
             $class['created'] = now();
216 216
             $class['institution_shift_id'] = $param['shift_id'];
217 217
             // $class['created_user_id'] = 
218
-            $this->output->writeln('Create class:' . $class['name']);
219
-            $class =  Institution_class::create($class);
218
+            $this->output->writeln('Create class:'.$class['name']);
219
+            $class = Institution_class::create($class);
220 220
             $institutionClassGrdaeObj['institution_class_id'] = $class->id;
221 221
             $institutionClassGrdaeObj['education_grade_id'] = $educationGrdae;
222 222
             $institutionClassGrdaeObj['created_user_id'] = $class['created_user_id'];
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
                 ->toArray();
229 229
             $params['class'] = $class;
230 230
             $this->insertInstitutionClassSubjects($institutionSubjects, $class);
231
-        } catch (\Exception $e) {
231
+        }catch (\Exception $e) {
232 232
             DB::rollBack();
233 233
             Log::error($e->getMessage(), [$e]);
234 234
         }
@@ -239,8 +239,8 @@  discard block
 block discarded – undo
239 239
         if (!empty($subjects)) {
240 240
             try {
241 241
                 array_walk($subjects, array($this, 'insertClassSubjects'), $class);
242
-                $this->output->writeln('updating subjects ' . $class->name);
243
-            } catch (\Exception $e) {
242
+                $this->output->writeln('updating subjects '.$class->name);
243
+            }catch (\Exception $e) {
244 244
                 DB::rollBack();
245 245
                 Log::error($e->getMessage(), [$e]);
246 246
             }
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
             if (!$this->institution_class_subjects->isDuplicated($subjectobj)) {
262 262
                 $this->institution_class_subjects->create($subjectobj);
263 263
             }
264
-        } catch (\Exception $e) {
264
+        }catch (\Exception $e) {
265 265
             DB::rollBack();
266 266
             Log::error($e->getMessage(), [$e]);
267 267
         }
@@ -309,19 +309,19 @@  discard block
 block discarded – undo
309 309
                 unset($shift['id']);
310 310
                 unset($shift['created']);
311 311
                 unset($shift['modified']);
312
-                $shift = $this->shifts->create((array)$shift);
312
+                $shift = $this->shifts->create((array) $shift);
313 313
                 $data = [
314 314
                     'shift_id' => $shift->id,
315 315
                     'created' => true
316 316
                 ];
317
-            } else {
317
+            }else {
318 318
                 $data = [
319 319
                     'shift_id' => $exist->id,
320 320
                     'created' => false
321 321
                 ];
322 322
             };
323 323
             return $data;
324
-        } catch (\Exception $e) {
324
+        }catch (\Exception $e) {
325 325
             DB::rollBack();
326 326
         }
327 327
     }
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
            DB::beginTransaction();
45 45
             array_walk($shift, array($this, 'process'), $params);
46 46
             DB::commit();
47
-        }catch(\Exception $e){
47
+        } catch(\Exception $e){
48 48
             $this->output->writeln('Terminating ' . $shift['institution_id']);
49 49
             DB::rollBack();
50 50
         }
Please login to merge, or discard this patch.
app/Console/Commands/CallPromotionCommand.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -48,21 +48,21 @@
 block discarded – undo
48 48
         $mode = $this->argument('mode');
49 49
         $academicPeriod = $this->academic_period->getAcademicPeriod($year);
50 50
         $previousAcademicPeriodYear = $academicPeriod->order;
51
-        $previousAcademicPeriod = Academic_period::where('order',$previousAcademicPeriodYear+1)->first();
52
-        $institutions = $this->instituion_grade->getInstitutionGradeList($previousAcademicPeriod->code,$limit,$mode);
51
+        $previousAcademicPeriod = Academic_period::where('order', $previousAcademicPeriodYear + 1)->first();
52
+        $institutions = $this->instituion_grade->getInstitutionGradeList($previousAcademicPeriod->code, $limit, $mode);
53 53
         $params = [
54 54
             'year' => $year,
55 55
             'mode'=> $mode
56 56
         ];
57
-        if(in_array($mode,['AL','1-5','SP','6-11'])){
58
-            array_walk($institutions,array($this,'callPromotion'),$params);
59
-        }else{
57
+        if (in_array($mode, ['AL', '1-5', 'SP', '6-11'])) {
58
+            array_walk($institutions, array($this, 'callPromotion'), $params);
59
+        }else {
60 60
             die('The give mode not support');
61 61
         }
62 62
        
63 63
     }
64 64
 
65
-    protected function callPromotion($institution,$count,$params){
66
-        $this->call('promote:students',['year' => $params['year'],'institution' => $institution['code'],'mode' => $params['mode'] ]);
65
+    protected function callPromotion($institution, $count, $params) {
66
+        $this->call('promote:students', ['year' => $params['year'], 'institution' => $institution['code'], 'mode' => $params['mode']]);
67 67
     }
68 68
 }
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
         ];
57 57
         if(in_array($mode,['AL','1-5','SP','6-11'])){
58 58
             array_walk($institutions,array($this,'callPromotion'),$params);
59
-        }else{
59
+        } else{
60 60
             die('The give mode not support');
61 61
         }
62 62
        
Please login to merge, or discard this patch.
app/Console/Commands/PromoteStudents.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -65,15 +65,15 @@
 block discarded – undo
65 65
         $institution = $this->argument('institution');
66 66
         $academicPeriod = $this->academic_period->getAcademicPeriod($year);
67 67
         $previousAcademicPeriodYear = $academicPeriod->order;
68
-        $previousAcademicPeriod = Academic_period::where('order',$previousAcademicPeriodYear+1)->first();
68
+        $previousAcademicPeriod = Academic_period::where('order', $previousAcademicPeriodYear + 1)->first();
69 69
         $mode = $this->argument('mode');
70
-        $institutionGrade = $this->instituion_grade->getInstitutionGradeToPromoted($previousAcademicPeriod->code,$institution,$mode);
70
+        $institutionGrade = $this->instituion_grade->getInstitutionGradeToPromoted($previousAcademicPeriod->code, $institution, $mode);
71 71
         $output->writeln('Start promoting:'.$institution);
72 72
         $params = [
73 73
             'academicPeriod' => $academicPeriod,
74 74
             'previousAcademicPeriod' => $previousAcademicPeriod
75 75
         ];
76
-        (new BulkPromotion())->callback($institutionGrade,$params);
76
+        (new BulkPromotion())->callback($institutionGrade, $params);
77 77
         $output->writeln('Finished promoting:'.$institution);
78 78
     }
79 79
 }
Please login to merge, or discard this patch.
app/Models/Institution_shift.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 
7
-class Institution_shift extends Base_Model  {
7
+class Institution_shift extends Base_Model {
8 8
 
9 9
     /**
10 10
      * The database table used by the model.
@@ -41,40 +41,40 @@  discard block
 block discarded – undo
41 41
      */
42 42
     protected $dates = ['modified', 'created'];
43 43
 
44
-    public function shiftExists($shift){
44
+    public function shiftExists($shift) {
45 45
        return self::query()
46
-            ->where('institution_id',$shift['institution_id'])
47
-            ->where('location_institution_id',$shift['location_institution_id'])
48
-            ->where('shift_option_id',$shift['shift_option_id'])
49
-            ->where('academic_period_id',$shift['academic_period_id'])->exists();
46
+            ->where('institution_id', $shift['institution_id'])
47
+            ->where('location_institution_id', $shift['location_institution_id'])
48
+            ->where('shift_option_id', $shift['shift_option_id'])
49
+            ->where('academic_period_id', $shift['academic_period_id'])->exists();
50 50
     }
51 51
 
52
-    public function getShift($shift){
52
+    public function getShift($shift) {
53 53
         return self::query()
54
-            ->where('institution_id',$shift['institution_id'])
55
-            ->where('location_institution_id',$shift['location_institution_id'])
56
-            ->where('shift_option_id',$shift['shift_option_id'])
57
-            ->where('academic_period_id',$shift['academic_period_id'])->first();
54
+            ->where('institution_id', $shift['institution_id'])
55
+            ->where('location_institution_id', $shift['location_institution_id'])
56
+            ->where('shift_option_id', $shift['shift_option_id'])
57
+            ->where('academic_period_id', $shift['academic_period_id'])->first();
58 58
     }
59 59
 
60
-    public function getShiftsToClone(string $year,$limit,$mode){
60
+    public function getShiftsToClone(string $year, $limit, $mode) {
61 61
         return self::query()
62 62
             ->select('institution_shifts.*')
63
-            ->join('academic_periods','academic_periods.id','=','institution_shifts.academic_period_id')
64
-            ->where('academic_periods.code',$year)
65
-            ->whereNotIn('institution_shifts.cloned',[ '2020' , '2018/2019'])
63
+            ->join('academic_periods', 'academic_periods.id', '=', 'institution_shifts.academic_period_id')
64
+            ->where('academic_periods.code', $year)
65
+            ->whereNotIn('institution_shifts.cloned', ['2020', '2018/2019'])
66 66
             ->groupBy('institution_shifts.id')
67 67
             ->limit($limit)
68 68
             ->get()
69 69
             ->toArray();
70 70
     }
71 71
 
72
-    public function getShiftsTodelete(string $year,$academic_period_id){
72
+    public function getShiftsTodelete(string $year, $academic_period_id) {
73 73
         return self::query()
74 74
             // ->select('institution_shifts.*','academic_periods.academic_period_id')
75
-            ->join('academic_periods','academic_periods.id','=','institution_shifts.academic_period_id')
76
-            ->where('academic_period_id',$academic_period_id)
77
-            ->where('institution_shifts.cloned',$year)
75
+            ->join('academic_periods', 'academic_periods.id', '=', 'institution_shifts.academic_period_id')
76
+            ->where('academic_period_id', $academic_period_id)
77
+            ->where('institution_shifts.cloned', $year)
78 78
             ->get()->toArray();
79 79
     }
80 80
 }
Please login to merge, or discard this patch.
app/Models/Institution_class.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -75,9 +75,9 @@  discard block
 block discarded – undo
75 75
 
76 76
             )
77 77
             ->join('institution_class_grades', 'institution_classes.id', 'institution_class_grades.institution_class_id')
78
-            ->join('education_grades','institution_class_grades.education_grade_id','education_grades.id')  
78
+            ->join('education_grades', 'institution_class_grades.education_grade_id', 'education_grades.id')  
79 79
             ->join('education_programmes', 'education_grades.education_programme_id', 'education_programmes.id')
80
-            ->join('education_cycles', 'education_programmes.education_cycle_id','education_cycles.id')
80
+            ->join('education_cycles', 'education_programmes.education_cycle_id', 'education_cycles.id')
81 81
             ->groupBy('institution_classes.id');
82 82
 
83 83
         if ($al == true) {
@@ -87,8 +87,8 @@  discard block
 block discarded – undo
87 87
             ->groupBy('institution_classes.id')
88 88
             ->get()->toArray();
89 89
             return $data;
90
-        } else {
91
-            $query->where('education_programmes.education_cycle_id','<>',4)
90
+        }else {
91
+            $query->where('education_programmes.education_cycle_id', '<>', 4)
92 92
             ->where('institution_shift_id', $shift['id']);
93 93
             $data = $query
94 94
             ->groupBy('institution_classes.id')
@@ -97,13 +97,13 @@  discard block
 block discarded – undo
97 97
         }
98 98
     }
99 99
 
100
-    public static function getGradeClasses($education_grade_id,$institution_id){
100
+    public static function getGradeClasses($education_grade_id, $institution_id) {
101 101
         return self::query()
102
-        ->select('institution_classes.id','institution_classes.institution_id','institution_classes.institution_shift_id',
103
-            'institution_classes.name','institution_classes.no_of_students','institution_classes.class_number','institution_class_grades.education_grade_id')
104
-        ->where('institution_class_grades.education_grade_id',$education_grade_id)
105
-        ->where('institution_classes.institution_id',$institution_id)
106
-        ->join('institution_class_grades','institution_classes.id','institution_class_grades.institution_class_id')
102
+        ->select('institution_classes.id', 'institution_classes.institution_id', 'institution_classes.institution_shift_id',
103
+            'institution_classes.name', 'institution_classes.no_of_students', 'institution_classes.class_number', 'institution_class_grades.education_grade_id')
104
+        ->where('institution_class_grades.education_grade_id', $education_grade_id)
105
+        ->where('institution_classes.institution_id', $institution_id)
106
+        ->join('institution_class_grades', 'institution_classes.id', 'institution_class_grades.institution_class_id')
107 107
         ->get()->toArray();
108 108
     }
109 109
 
Please login to merge, or discard this patch.
app/Models/Education_grades_subject.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 
7
-class Education_grades_subject extends Model  {
7
+class Education_grades_subject extends Model {
8 8
 
9 9
     /**
10 10
      * The database table used by the model.
@@ -42,12 +42,12 @@  discard block
 block discarded – undo
42 42
     protected $dates = ['modified', 'created'];
43 43
 
44 44
 
45
-    public function institutionGradeSubject(){
46
-        return $this->hasMany('App\Models\Institution_subject','education_grade_id','education_grade_id');
45
+    public function institutionGradeSubject() {
46
+        return $this->hasMany('App\Models\Institution_subject', 'education_grade_id', 'education_grade_id');
47 47
     }
48 48
 
49
-    public function getGradeSubjects($educationGrade){
50
-        self::where('education_grade_id',$educationGrade['education_grade_id'])
49
+    public function getGradeSubjects($educationGrade) {
50
+        self::where('education_grade_id', $educationGrade['education_grade_id'])
51 51
         ->get()
52 52
         ->toArray();
53 53
         ;
Please login to merge, or discard this patch.
app/Models/Institution_subject.php 1 patch
Spacing   +17 added lines, -17 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 
7
-class Institution_subject extends Base_Model  {
7
+class Institution_subject extends Base_Model {
8 8
 
9 9
     /**
10 10
      * The database table used by the model.
@@ -42,29 +42,29 @@  discard block
 block discarded – undo
42 42
     protected $dates = ['modified', 'created', 'modified', 'created'];
43 43
 
44 44
 
45
-    public  function institutionGradeSubject(){
46
-        return $this->belongsTo('App\Models\Education_grades_subject','education_subject_id','education_subject_id');
45
+    public  function institutionGradeSubject() {
46
+        return $this->belongsTo('App\Models\Education_grades_subject', 'education_subject_id', 'education_subject_id');
47 47
     }
48 48
 
49
-    public  function institutionOptionalGradeSubject(){
50
-        return $this->belongsTo('App\Models\Education_grades_subject','education_grade_id','education_grade_id');
49
+    public  function institutionOptionalGradeSubject() {
50
+        return $this->belongsTo('App\Models\Education_grades_subject', 'education_grade_id', 'education_grade_id');
51 51
     }
52 52
 
53
-    public  function institutionMandatoryGradeSubject(){
54
-        return $this->belongsTo('App\Models\Education_grades_subject','education_grade_id','education_grade_id');
53
+    public  function institutionMandatoryGradeSubject() {
54
+        return $this->belongsTo('App\Models\Education_grades_subject', 'education_grade_id', 'education_grade_id');
55 55
     }
56 56
 
57 57
 
58
-    public  function institutionClassSubject(){
59
-        return $this->hasMany('App\Models\Institution_class_subject','institution_class_id','id');
58
+    public  function institutionClassSubject() {
59
+        return $this->hasMany('App\Models\Institution_class_subject', 'institution_class_id', 'id');
60 60
     }
61 61
 
62 62
 
63 63
 
64
-    public function getInstitutionSubjects($institution_id,$academic_period_id){
65
-        $query =  self::query()->where('institution_id',$institution_id)
66
-            ->where('academic_period_id',$academic_period_id)
67
-            ->join('education_grades_subjects','institution_subjects.education_subject_id','education_grades_subjects.id')
64
+    public function getInstitutionSubjects($institution_id, $academic_period_id) {
65
+        $query = self::query()->where('institution_id', $institution_id)
66
+            ->where('academic_period_id', $academic_period_id)
67
+            ->join('education_grades_subjects', 'institution_subjects.education_subject_id', 'education_grades_subjects.id')
68 68
             ->join('education_grades', 'education_grades_subjects.education_grade_id', 'education_grades.id')
69 69
             ->groupBy('education_grades_subjects.id');
70 70
         return $query->get()->toArray();
@@ -72,15 +72,15 @@  discard block
 block discarded – undo
72 72
 
73 73
     public  static function getStudentsCount($institution_subject_id)
74 74
     {
75
-        $total_male_students = self::with(['student' => function ($query) {
75
+        $total_male_students = self::with(['student' => function($query) {
76 76
             $query->where('student.gender_id', '=', 1);
77
-        }])->whereHas('student', function ($query) {
77
+        }])->whereHas('student', function($query) {
78 78
             $query->where('gender_id', '=', 1);
79 79
         })->where('institution_subject_id', '=', $institution_subject_id)->count();
80 80
 
81
-        $total_female_students = self::with(['student' => function ($query) {
81
+        $total_female_students = self::with(['student' => function($query) {
82 82
             $query->where('student.gender_id', '=', 2);
83
-        }])->whereHas('student', function ($query) {
83
+        }])->whereHas('student', function($query) {
84 84
             $query->where('gender_id', '=', 2);
85 85
         })->where('institution_subject_id', '=', $institution_subject_id)->count();
86 86
 
Please login to merge, or discard this patch.