Test Setup Failed
Pull Request — master (#461)
by Mohamed
07:38
created
app/Jobs/NotifyUserCompleteExport.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,13 +30,13 @@
 block discarded – undo
30 30
      */
31 31
     public function handle()
32 32
     {
33
-        try{
33
+        try {
34 34
             ini_set('memory_limit', '-1');
35 35
             (new ExaminationStudentsExport)->queue('/examination/student_data_with_nsid.csv')->chain([
36 36
                 (new ExportReady($this->user))
37 37
             ]);
38 38
             
39
-        }catch(\Exception $e){
39
+        }catch (\Exception $e) {
40 40
             $output = new \Symfony\Component\Console\Output\ConsoleOutput();
41 41
             $output->writeln($e->getMessage());
42 42
         }
Please login to merge, or discard this patch.
app/Mail/TerminatedReport.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -22,17 +22,17 @@  discard block
 block discarded – undo
22 22
 
23 23
         $institution = Institution_class::find($file['institution_class_id']);
24 24
         $this->user = User::find($file['security_user_id']);
25
-        $this->subject = 'SIS Bulk Upload: Process Terminated'.$institution->institution->code.': '. $institution->name.' '. date('Y:m:d H:i:s');
25
+        $this->subject = 'SIS Bulk Upload: Process Terminated'.$institution->institution->code.': '.$institution->name.' '.date('Y:m:d H:i:s');
26 26
         $this->from_address = env('MAIL_FROM_ADDRESS');
27 27
         $this->from_name = 'SIS Bulk Uploader';
28 28
         $this->with = [
29 29
             'name' => $this->user->first_name,
30
-            'link' =>   \App::environment('local') || \App::environment('stage')   ?  env('APP_URL').'/download/' .$file['filename'] : env('APP_URL').'/bulk-upload/download/' .$file['filename']
30
+            'link' =>   \App::environment('local') || \App::environment('stage') ?  env('APP_URL').'/download/'.$file['filename'] : env('APP_URL').'/bulk-upload/download/'.$file['filename']
31 31
         ];
32 32
         $this->viewData = [
33 33
             'name'=>$this->user->first_name, "body" => "Apologize ,The process of you file has been terminated in the middle,
34 34
              We advice you to check the student data and re-upload with only with correct data which are not in the system ",
35
-            'link' =>    \App::environment('local') || \App::environment('stage')   ?  env('APP_URL').'/download/' .$file['filename'] : env('APP_URL').'/bulk-upload/download/' .$file['filename']
35
+            'link' =>    \App::environment('local') || \App::environment('stage') ?  env('APP_URL').'/download/'.$file['filename'] : env('APP_URL').'/bulk-upload/download/'.$file['filename']
36 36
         ];
37 37
     }
38 38
 
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
     public function build()
45 45
     {
46 46
         return $this->view('emails.mail')
47
-            ->from($this->from_address,$this->from_name)
47
+            ->from($this->from_address, $this->from_name)
48 48
             ->to($this->user->email)
49 49
             ->subject($this->subject)
50 50
             ->with($this->with);
Please login to merge, or discard this patch.
app/Mail/ExportReady.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -19,17 +19,17 @@  discard block
 block discarded – undo
19 19
     public function __construct($user)
20 20
     {
21 21
         $this->user = $user;
22
-        $this->subject = 'The DoE data is ready to download '. date('Y:m:d H:i:s');
22
+        $this->subject = 'The DoE data is ready to download '.date('Y:m:d H:i:s');
23 23
         $this->from_address = env('MAIL_FROM_ADDRESS');
24 24
         $this->from_name = 'SIS Bulk Uploader';
25 25
         $this->with = [
26 26
             'name' => $this->user->first_name,
27
-            'link' => \App::environment('local') || \App::environment('stage')   ?  env('APP_URL').'/downloadExportexamination' : env('APP_URL').'/bulk-upload/downloadExportexamination'
27
+            'link' => \App::environment('local') || \App::environment('stage') ?  env('APP_URL').'/downloadExportexamination' : env('APP_URL').'/bulk-upload/downloadExportexamination'
28 28
         ];
29 29
 
30 30
         $this->viewData = [
31 31
             'name'=>$this->user->first_name, "body" =>'Your requested file is ready to download',
32
-            'link' => \App::environment('local') || \App::environment('stage')   ?  env('APP_URL').'/downloadExportexamination' : env('APP_URL').'/bulk-upload/downloadExportexamination'
32
+            'link' => \App::environment('local') || \App::environment('stage') ?  env('APP_URL').'/downloadExportexamination' : env('APP_URL').'/bulk-upload/downloadExportexamination'
33 33
         ];
34 34
     }
35 35
 
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     public function build()
42 42
     {
43 43
         return $this->view('emails.mail')
44
-            ->from($this->from_address,$this->from_name)
44
+            ->from($this->from_address, $this->from_name)
45 45
             ->to($this->user->email)
46 46
             ->subject($this->subject)
47 47
             ->with($this->with);
Please login to merge, or discard this patch.
app/Mail/StudentCountExceeded.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -31,16 +31,16 @@  discard block
 block discarded – undo
31 31
         $institution = Institution_class::find($file['institution_class_id']);
32 32
 
33 33
         $this->user = User::find($file['security_user_id']);
34
-        $this->subject = 'SIS Bulk Upload: Upload Failed '.$institution->institution->code.': '. $institution->name . date('Y:m:d H:i:s');
34
+        $this->subject = 'SIS Bulk Upload: Upload Failed '.$institution->institution->code.': '.$institution->name.date('Y:m:d H:i:s');
35 35
         $this->from_address = env('MAIL_FROM_ADDRESS');
36 36
         $this->from_name = 'SIS Bulk Uploader';
37 37
         $this->with = [
38 38
             'name' => $this->user->first_name,
39
-            'link' =>   \App::environment('local') || \App::environment('stage')    ?  env('APP_URL').'/download/' .$file['filename'] : env('APP_URL').'/bulk-upload/download/' .$file['filename']
39
+            'link' =>   \App::environment('local') || \App::environment('stage') ?  env('APP_URL').'/download/'.$file['filename'] : env('APP_URL').'/bulk-upload/download/'.$file['filename']
40 40
         ];
41 41
         $this->viewData = [
42 42
             'name'=>$this->user->first_name, "body" => "The class you tried to import data is exceeded the student count limit.Please check the class / increase the student limit",
43
-            'link' =>   \App::environment('local') || \App::environment('stage')    ?  env('APP_URL').'/download/' .$file['filename'] : env('APP_URL').'/bulk-upload/download/' .$file['filename']
43
+            'link' =>   \App::environment('local') || \App::environment('stage') ?  env('APP_URL').'/download/'.$file['filename'] : env('APP_URL').'/bulk-upload/download/'.$file['filename']
44 44
         ];
45 45
     }
46 46
 
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     public function build()
53 53
     {
54 54
         return $this->view('emails.mail')
55
-            ->from($this->from_address,$this->from_name)
55
+            ->from($this->from_address, $this->from_name)
56 56
             ->to($this->user->email)
57 57
             ->subject($this->subject)
58 58
             ->with($this->with);
Please login to merge, or discard this patch.
app/Mail/StudentImportFailure.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -24,17 +24,17 @@  discard block
 block discarded – undo
24 24
 
25 25
 
26 26
         $this->user = User::find($file['security_user_id']);
27
-        $this->subject = 'SIS Bulk Upload: ' .$file['subject']. $institution->institution->code.': '. $institution->name.' '. date('Y:m:d H:i:s');
27
+        $this->subject = 'SIS Bulk Upload: '.$file['subject'].$institution->institution->code.': '.$institution->name.' '.date('Y:m:d H:i:s');
28 28
         $this->from_address = env('MAIL_FROM_ADDRESS');
29 29
         $this->from_name = 'SIS Bulk Uploader';
30 30
         $this->with = [
31 31
             'name' => $this->user->first_name,
32
-            'link' =>  \App::environment('local') || \App::environment('stage')  ?  env('APP_URL').'/download/' .$file['filename'] : env('APP_URL').'/bulk-upload/download/' .$file['filename']
32
+            'link' =>  \App::environment('local') || \App::environment('stage') ?  env('APP_URL').'/download/'.$file['filename'] : env('APP_URL').'/bulk-upload/download/'.$file['filename']
33 33
         ];
34 34
         $this->viewData = [
35
-            'name'=>$this->user->first_name, "body" => "We found some errors on your data file ". $file['filename']. ' Pleas fix the errors and re-upload  only with incorrect data,
35
+            'name'=>$this->user->first_name, "body" => "We found some errors on your data file ".$file['filename'].' Pleas fix the errors and re-upload  only with incorrect data,
36 36
             We uploaded the correct data to the system',
37
-            'link' =>  \App::environment('local') || \App::environment('stage')   ?  env('APP_URL').'/download/' .$file['filename'] : env('APP_URL').'/bulk-upload/download/' .$file['filename']
37
+            'link' =>  \App::environment('local') || \App::environment('stage') ?  env('APP_URL').'/download/'.$file['filename'] : env('APP_URL').'/bulk-upload/download/'.$file['filename']
38 38
         ];
39 39
     }
40 40
 
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
     public function build()
47 47
     {
48 48
         return $this->view('emails.mail')
49
-            ->from($this->from_address,$this->from_name)
49
+            ->from($this->from_address, $this->from_name)
50 50
             ->to($this->user->email)
51 51
             ->subject($this->subject)
52 52
             ->with($this->with);
Please login to merge, or discard this patch.
app/Mail/IncorrectTemplate.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -23,16 +23,16 @@  discard block
 block discarded – undo
23 23
 
24 24
 
25 25
         $this->user = User::find($file['security_user_id']);
26
-        $this->subject = 'SIS Bulk Upload: IncorrectTemplate'.$institution->institution->code.': '. $institution->name.' '. date('Y:m:d H:i:s');
26
+        $this->subject = 'SIS Bulk Upload: IncorrectTemplate'.$institution->institution->code.': '.$institution->name.' '.date('Y:m:d H:i:s');
27 27
         $this->from_address = env('MAIL_FROM_ADDRESS');
28 28
         $this->from_name = 'SIS Bulk Uploader';
29 29
         $this->with = [
30 30
             'name' => $this->user->first_name,
31
-            'link' => \App::environment('local') || \App::environment('stage')  ?  env('APP_URL').'/download/' .$file['filename'] : env('APP_URL').'/bulk-upload/download/' .$file['filename']
31
+            'link' => \App::environment('local') || \App::environment('stage') ?  env('APP_URL').'/download/'.$file['filename'] : env('APP_URL').'/bulk-upload/download/'.$file['filename']
32 32
         ];
33 33
         $this->viewData = [
34 34
             'name'=>$this->user->first_name, "body" => "The Template you used for upload having some issues, please reconfirm and re-upload with correct template",
35
-            'link' =>  \App::environment('local') || \App::environment('stage')   ?  env('APP_URL').'/download/' .$file['filename'] : env('APP_URL').'/bulk-upload/download/' .$file['filename']
35
+            'link' =>  \App::environment('local') || \App::environment('stage') ?  env('APP_URL').'/download/'.$file['filename'] : env('APP_URL').'/bulk-upload/download/'.$file['filename']
36 36
         ];
37 37
     }
38 38
 
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
     public function build()
45 45
     {
46 46
         return $this->view('emails.mail')
47
-            ->from($this->from_address,$this->from_name)
47
+            ->from($this->from_address, $this->from_name)
48 48
             ->to($this->user->email)
49 49
             ->subject($this->subject)
50 50
             ->with($this->with);
Please login to merge, or discard this patch.
app/Mail/EmptyFile.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -25,16 +25,16 @@  discard block
 block discarded – undo
25 25
 
26 26
 
27 27
         $this->user = User::find($file['security_user_id']);
28
-        $this->subject = 'SIS Bulk Upload: ' .$file['subject'].' Empty ' . $institution->institution->code.': '. $institution->name.' '. date('Y:m:d H:i:s');
28
+        $this->subject = 'SIS Bulk Upload: '.$file['subject'].' Empty '.$institution->institution->code.': '.$institution->name.' '.date('Y:m:d H:i:s');
29 29
         $this->from_address = env('MAIL_FROM_ADDRESS');
30 30
         $this->from_name = 'SIS Bulk Uploader';
31 31
         $this->with = [
32 32
             'name' => $this->user->first_name,
33
-            'link' => \App::environment('local') || \App::environment('stage')   ?  env('APP_URL') : env('APP_URL').'/bulk-upload/'
33
+            'link' => \App::environment('local') || \App::environment('stage') ?  env('APP_URL') : env('APP_URL').'/bulk-upload/'
34 34
         ];
35 35
         $this->viewData = [
36
-            'name'=>$this->user->first_name, "body" => "No data Found in ". $file['filename']. ' Please re-upload the file with data',
37
-            'link' =>  \App::environment('local') || \App::environment('stage')   ?  env('APP_URL') : env('APP_URL').'/bulk-upload/'
36
+            'name'=>$this->user->first_name, "body" => "No data Found in ".$file['filename'].' Please re-upload the file with data',
37
+            'link' =>  \App::environment('local') || \App::environment('stage') ?  env('APP_URL') : env('APP_URL').'/bulk-upload/'
38 38
         ];
39 39
     }
40 40
 
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
     public function build()
47 47
     {
48 48
         return $this->view('emails.mail')
49
-            ->from($this->from_address,$this->from_name)
49
+            ->from($this->from_address, $this->from_name)
50 50
             ->to($this->user->email)
51 51
             ->subject($this->subject)
52 52
             ->with($this->with);
Please login to merge, or discard this patch.
app/Models/Institution_grade.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -71,11 +71,11 @@  discard block
 block discarded – undo
71 71
     {
72 72
         if (!is_null($id)) {
73 73
             return self::find($id)
74
-                ->select('institution_grades.id as insGrade','institution_classes.id', 'institution_classes.name', 'institution_grades.education_grade_id')
75
-                ->join('institution_classes', function ($join) use ($educationGradeId, $academicPeriodId) {
74
+                ->select('institution_grades.id as insGrade', 'institution_classes.id', 'institution_classes.name', 'institution_grades.education_grade_id')
75
+                ->join('institution_classes', function($join) use ($educationGradeId, $academicPeriodId) {
76 76
                     $join->on('institution_classes.institution_id', '=', 'institution_grades.institution_id')
77 77
                         ->where('institution_classes.academic_period_id', $academicPeriodId)
78
-                        ->join('institution_class_grades', function ($join) use ($educationGradeId) {
78
+                        ->join('institution_class_grades', function($join) use ($educationGradeId) {
79 79
                             $join->on('institution_class_grades.institution_class_id', '=', 'institution_classes.id')
80 80
                                 ->where('institution_class_grades.education_grade_id', $educationGradeId);
81 81
                         });
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
                 ->where('institution_grades.education_grade_id', $educationGradeId)
84 84
                 ->where('institution_grades.institution_id', $institutionId)
85 85
                 ->get();
86
-        }else{
86
+        }else {
87 87
             return null;
88 88
         }
89 89
     }
@@ -95,8 +95,8 @@  discard block
 block discarded – undo
95 95
      * @param $year
96 96
      * @param $id
97 97
      */
98
-    public function updatePromoted($year, $id){
99
-        self::where('id',$id)->update(['promoted'=>$year]);
98
+    public function updatePromoted($year, $id) {
99
+        self::where('id', $id)->update(['promoted'=>$year]);
100 100
     }
101 101
 
102 102
     /**
@@ -106,9 +106,9 @@  discard block
 block discarded – undo
106 106
      * @param $gradeId
107 107
      * @return mixed
108 108
      */
109
-    public function getInstitutionGrade($institutionId, $gradeId){
110
-         return self::where('education_grade_id',$gradeId)
111
-             ->where('institution_id',$institutionId)->get()->first();
109
+    public function getInstitutionGrade($institutionId, $gradeId) {
110
+         return self::where('education_grade_id', $gradeId)
111
+             ->where('institution_id', $institutionId)->get()->first();
112 112
     }
113 113
 
114 114
     /**
@@ -116,14 +116,14 @@  discard block
 block discarded – undo
116 116
      * @param null $institution
117 117
      * @return mixed
118 118
      */
119
-    public function getInstitutionGradeToPromoted($year, $institution = null){
119
+    public function getInstitutionGradeToPromoted($year, $institution = null) {
120 120
         return self::query()
121
-            ->select('education_grades.name','institutions.code','institutions.name as institution_name','institution_grades.id','institution_grades.institution_id','institution_grades.education_grade_id')
122
-            ->where('promoted','=',$year-1)
123
-            ->join('education_grades','institution_grades.education_grade_id','=','education_grades.id')
124
-            ->join('institutions', function($join) use ($year,$institution){
125
-                $join->on('institutions.id','=','institution_grades.institution_id')
126
-                    ->where('institutions.code','=',$institution);
121
+            ->select('education_grades.name', 'institutions.code', 'institutions.name as institution_name', 'institution_grades.id', 'institution_grades.institution_id', 'institution_grades.education_grade_id')
122
+            ->where('promoted', '=', $year - 1)
123
+            ->join('education_grades', 'institution_grades.education_grade_id', '=', 'education_grades.id')
124
+            ->join('institutions', function($join) use ($year, $institution){
125
+                $join->on('institutions.id', '=', 'institution_grades.institution_id')
126
+                    ->where('institutions.code', '=', $institution);
127 127
             })
128 128
                 ->orderBy('institution_id')
129 129
             ->get()->toArray();
@@ -133,13 +133,13 @@  discard block
 block discarded – undo
133 133
      * @param $year
134 134
      * @return mixed
135 135
      */
136
-    public function getInstitutionGradeList($year){
136
+    public function getInstitutionGradeList($year) {
137 137
         return self::query()
138
-            ->select('education_grades.name','institutions.code','institutions.name as institution_name','institution_grades.id','institution_grades.institution_id','institution_grades.education_grade_id')
139
-            ->where('promoted','=',$year-1)
140
-            ->join('education_grades','institution_grades.education_grade_id','=','education_grades.id')
138
+            ->select('education_grades.name', 'institutions.code', 'institutions.name as institution_name', 'institution_grades.id', 'institution_grades.institution_id', 'institution_grades.education_grade_id')
139
+            ->where('promoted', '=', $year - 1)
140
+            ->join('education_grades', 'institution_grades.education_grade_id', '=', 'education_grades.id')
141 141
             ->join('institutions', function($join) use ($year){
142
-                $join->on('institutions.id','=','institution_grades.institution_id');
142
+                $join->on('institutions.id', '=', 'institution_grades.institution_id');
143 143
             })
144 144
             ->orderBy('institution_id')
145 145
             ->get()
Please login to merge, or discard this patch.
app/Models/Institution_shift.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 
7
-class Institution_shift extends Base_Model  {
7
+class Institution_shift extends Base_Model {
8 8
 
9 9
     /**
10 10
      * The database table used by the model.
@@ -41,29 +41,29 @@  discard block
 block discarded – undo
41 41
      */
42 42
     protected $dates = ['modified', 'created'];
43 43
 
44
-    public function shiftExists($shift){
44
+    public function shiftExists($shift) {
45 45
        return self::query()
46
-            ->where('institution_id',$shift['institution_id'])
47
-            ->where('location_institution_id',$shift['location_institution_id'])
48
-            ->where('shift_option_id',$shift['shift_option_id'])
49
-            ->where('academic_period_id',$shift['academic_period_id'])->exists();
46
+            ->where('institution_id', $shift['institution_id'])
47
+            ->where('location_institution_id', $shift['location_institution_id'])
48
+            ->where('shift_option_id', $shift['shift_option_id'])
49
+            ->where('academic_period_id', $shift['academic_period_id'])->exists();
50 50
     }
51 51
 
52
-    public function getShiftsToClone(int $year){
52
+    public function getShiftsToClone(int $year) {
53 53
         return self::query()
54 54
             ->select('institution_shifts.*')
55
-            ->join('academic_periods','academic_periods.id','=','institution_shifts.academic_period_id')
55
+            ->join('academic_periods', 'academic_periods.id', '=', 'institution_shifts.academic_period_id')
56 56
             // ->where('academic_periods.code',$year)
57
-            ->where('institution_shifts.cloned',$year)
57
+            ->where('institution_shifts.cloned', $year)
58 58
             ->get()->toArray();
59 59
     }
60 60
 
61
-    public function getShiftsTodelete(int $year,$academic_period_id){
61
+    public function getShiftsTodelete(int $year, $academic_period_id) {
62 62
         return self::query()
63 63
             ->select('institution_shifts.*')
64
-            ->join('academic_periods','academic_periods.id','=','institution_shifts.academic_period_id')
65
-            ->where('academic_period_id',$academic_period_id)
66
-            ->where('institution_shifts.cloned',$year)
64
+            ->join('academic_periods', 'academic_periods.id', '=', 'institution_shifts.academic_period_id')
65
+            ->where('academic_period_id', $academic_period_id)
66
+            ->where('institution_shifts.cloned', $year)
67 67
             ->get()->toArray();
68 68
     }
69 69
 }
Please login to merge, or discard this patch.