moe-lk /
bulk-upload
| Total Complexity | 49 |
| Total Lines | 454 |
| Duplicated Lines | 0 % |
| Changes | 29 | ||
| Bugs | 11 | Features | 4 |
Complex classes like ExaminationStudentsController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ExaminationStudentsController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 25 | class ExaminationStudentsController extends Controller |
||
| 26 | { |
||
| 27 | public function __construct($year = 2019, $grade = 'G5') |
||
| 28 | { |
||
| 29 | $this->year = $year; |
||
|
Bug
Best Practice
introduced
by
|
|||
| 30 | $this->grade = $grade; |
||
| 31 | $this->student = new Security_user(); |
||
| 32 | $this->examination_student = new Examination_student(); |
||
| 33 | $this->academic_period = Academic_period::where('code', '=', $this->year)->first(); |
||
| 34 | $this->education_grade = Education_grade::where('code', '=', $this->grade)->first(); |
||
| 35 | $this->output = new \Symfony\Component\Console\Output\ConsoleOutput(); |
||
| 36 | } |
||
| 37 | |||
| 38 | public function index() |
||
| 41 | } |
||
| 42 | |||
| 43 | public function uploadFile(Request $request) |
||
| 83 | } |
||
| 84 | |||
| 85 | /** |
||
| 86 | * Import students data to the Examinations table |
||
| 87 | * |
||
| 88 | * @return void |
||
| 89 | */ |
||
| 90 | public static function callOnClick($year, $grade) |
||
| 125 | } |
||
| 126 | } |
||
| 127 | |||
| 128 | /** |
||
| 129 | * updated wrong census |
||
| 130 | * |
||
| 131 | * @param [type] $data |
||
| 132 | * @return void |
||
| 133 | */ |
||
| 134 | public function updateCensusNo($data) |
||
| 135 | { |
||
| 136 | $output = new \Symfony\Component\Console\Output\ConsoleOutput(); |
||
| 137 | $student = Security_user::where('openemis_no', $data['nsid']) |
||
| 138 | ->select('security_users.id') |
||
| 139 | ->first(); |
||
| 140 | if (!is_null($student)) { |
||
| 141 | $student = Institution_student::where('student_id', $student['id'])->get()->toArray(); |
||
| 142 | $Institution = Institution::where('code', $data['schoolid'])->get()->toArray(); |
||
| 143 | if (!empty($Institution)) { |
||
| 144 | $Institution = $Institution[0]; |
||
| 145 | if (count($student) == 1) { |
||
| 146 | $student = $student[0]; |
||
| 147 | if (((int)$Institution['id']) != ((int)$student['institution_id'])) { |
||
| 148 | $studentClass = Institution_class_student::where('student_id', $student['student_id']) |
||
| 149 | ->first(); |
||
| 150 | Institution_class_student::where('student_id', $student['student_id'])->delete(); |
||
| 151 | Institution_student::where('student_id', $student['student_id']) |
||
| 152 | ->update(['institution_id' => $Institution['id']]); |
||
| 153 | $class = new Institution_class(); |
||
| 154 | if (!is_null($studentClass)) { |
||
| 155 | $class->updateClassCount($studentClass->toArray()); |
||
| 156 | } |
||
| 157 | $output->writeln('updated student info:' . $data['nsid']); |
||
| 158 | } |
||
| 159 | } else { |
||
| 160 | Institution_student::where('institution_id', '<>', $Institution['id'])->where('student_id', $student[0]['student_id']) |
||
| 161 | ->delete(); |
||
| 162 | $output->writeln('updated student info:' . $Institution['id'] . '==' . $Institution['id']); |
||
| 163 | } |
||
| 164 | } |
||
| 165 | } |
||
| 166 | } |
||
| 167 | |||
| 168 | /** |
||
| 169 | * Iterate over existing student's data |
||
| 170 | * |
||
| 171 | * @return void |
||
| 172 | */ |
||
| 173 | public function doMatch($offset, $limit, $mode) |
||
| 236 | } |
||
| 237 | } |
||
| 238 | |||
| 239 | /** |
||
| 240 | * Set Examination values |
||
| 241 | * |
||
| 242 | * @param array $students |
||
| 243 | * @return array |
||
| 244 | */ |
||
| 245 | public function setIsTakingExam($students) |
||
| 246 | { |
||
| 247 | $students['taking_g5_exam'] = false; |
||
| 248 | $students['taking_ol_exam'] = false; |
||
| 249 | $students['taking_al_exam'] = false; |
||
| 250 | switch ($this->education_grade->code) { |
||
| 251 | case 'G5': |
||
| 252 | $students['taking_g5_exam'] = true; |
||
| 253 | break; |
||
| 254 | case 'G4': |
||
| 255 | $students['taking_g5_exam'] = true; |
||
| 256 | break; |
||
| 257 | case 'G10': |
||
| 258 | $students['taking_ol_exam'] = true; |
||
| 259 | break; |
||
| 260 | case 'G11': |
||
| 261 | $students['taking_ol_exam'] = true; |
||
| 262 | break; |
||
| 263 | // case preg_match('13', $this->education_grade->code): |
||
| 264 | // $students['taking_al_exam'] = true; |
||
| 265 | // break; |
||
| 266 | } |
||
| 267 | return $students; |
||
| 268 | } |
||
| 269 | |||
| 270 | |||
| 271 | /** |
||
| 272 | * Main function to merge the student's to SIS |
||
| 273 | * |
||
| 274 | * @param array $student |
||
| 275 | * @return void |
||
| 276 | */ |
||
| 277 | public function clone($student) |
||
| 337 | } |
||
| 338 | } |
||
| 339 | |||
| 340 | /** |
||
| 341 | * This function is implemented similar_text search algorithm |
||
| 342 | * to get the most matching name with the existing students |
||
| 343 | * data set |
||
| 344 | * |
||
| 345 | * @param array $student |
||
| 346 | * @return array |
||
| 347 | */ |
||
| 348 | public function getMatchingStudents($student) |
||
| 349 | { |
||
| 350 | /** |
||
| 351 | */ |
||
| 352 | $sis_student = $this->student->getMatches($student); |
||
| 353 | $doe_students = Examination_student::where('gender', $student['gender']) |
||
| 354 | ->where('b_date', $student['b_date']) |
||
| 355 | ->where('schoolid', $student['schoolid']) |
||
| 356 | ->where('year',$this->year) |
||
| 357 | ->where('grade',$this->grade) |
||
| 358 | ->count(); |
||
| 359 | $count = $this->student->getStudentCount($student); |
||
| 360 | |||
| 361 | $studentData = []; |
||
| 362 | $sis_users = (array) json_decode(json_encode($sis_student), true); |
||
| 363 | // if the same gender same DOE has more than one |
||
| 364 | if (($doe_students > 1) || ($count > 1)) { |
||
| 365 | $studentData = $this->searchSimilarName($student, $sis_users, false); |
||
| 366 | } else { |
||
| 367 | $studentData = $this->searchSimilarName($student, $sis_users); |
||
| 368 | } |
||
| 369 | return $studentData; |
||
| 370 | } |
||
| 371 | |||
| 372 | /** |
||
| 373 | * Search most matching name |
||
| 374 | * |
||
| 375 | * @param array $student |
||
| 376 | * @param array $sis_students |
||
| 377 | * @return array |
||
| 378 | */ |
||
| 379 | public function searchSimilarName($student, $sis_students, $surname_search = true) |
||
| 380 | { |
||
| 381 | $highest = []; |
||
| 382 | $minDistance = 0; |
||
| 383 | $matches = []; |
||
| 384 | $data = []; |
||
| 385 | foreach ($sis_students as $key => $value) { |
||
| 386 | similar_text(strtoupper($value['first_name']), (strtoupper($student['f_name'])), $percentage); |
||
| 387 | $distance = levenshtein(strtoupper($student['f_name']), strtoupper($value['first_name'])); |
||
| 388 | $value['rate'] = $percentage; |
||
| 389 | switch (true) { |
||
| 390 | case $value['rate'] == 100; |
||
| 391 | $highest = $value; |
||
| 392 | break; |
||
| 393 | case (($distance <= 2) && ($distance < $minDistance)); |
||
| 394 | $highest = $value; |
||
| 395 | $minDistance = $distance; |
||
| 396 | } |
||
| 397 | } |
||
| 398 | |||
| 399 | if ($surname_search) { |
||
| 400 | if (empty($highest)) { |
||
| 401 | foreach ($sis_students as $key => $value) { |
||
| 402 | //search name with last name |
||
| 403 | similar_text(strtoupper(get_l_name($student['f_name'])), strtoupper(get_l_name($value['first_name'])), $percentage); |
||
| 404 | $value['rate'] = $percentage; |
||
| 405 | switch (true) { |
||
| 406 | case ($value['rate'] == 100); |
||
| 407 | $highest = $value; |
||
| 408 | $matches[] = $value; |
||
| 409 | break; |
||
| 410 | } |
||
| 411 | } |
||
| 412 | } |
||
| 413 | } |
||
| 414 | |||
| 415 | if (count($matches) > 1) { |
||
| 416 | $highest = $this->searchSimilarName($student, $sis_students, false); |
||
| 417 | } |
||
| 418 | |||
| 419 | return $highest; |
||
| 420 | } |
||
| 421 | |||
| 422 | /** |
||
| 423 | * Generate new NSID for students |
||
| 424 | * |
||
| 425 | * @param array $student |
||
| 426 | * @param array $sis_student |
||
| 427 | * @return void |
||
| 428 | */ |
||
| 429 | public function updateStudentId($student, $sis_student) |
||
| 430 | { |
||
| 431 | try { |
||
| 432 | $student['nsid'] = $sis_student['openemis_no']; |
||
| 433 | // add new NSID to the examinations data set |
||
| 434 | unset($student['id']); |
||
| 435 | unset($student['taking_g5_exam']); |
||
| 436 | unset($student['taking_al_exam']); |
||
| 437 | unset($student['taking_ol_exam']); |
||
| 438 | unset($student['total']); |
||
| 439 | $students['updated_at'] = now(); |
||
| 440 | $this->examination_student->where('st_no', $student['st_no'])->update($student); |
||
| 441 | unset($student['st_no']); |
||
| 442 | $this->output->writeln('Updated to NSID' . $sis_student['openemis_no']); |
||
| 443 | } catch (\Exception $th) { |
||
| 444 | dd($th); |
||
| 445 | $this->output->writeln('error'); |
||
| 446 | Log::error($th); |
||
| 447 | } |
||
| 448 | } |
||
| 449 | |||
| 450 | /** |
||
| 451 | * export the all data with NSID |
||
| 452 | * |
||
| 453 | * @return void |
||
| 454 | */ |
||
| 455 | public function export() |
||
| 466 | } |
||
| 467 | |||
| 468 | public function downloadErrors() |
||
| 469 | { |
||
| 473 | } |
||
| 474 | |||
| 475 | public function downloadProcessedFile() |
||
| 481 |
Loading history...
