App\Exports\ExaminationStudentsExport

Complexity

Total Complexity

3

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	query()	0	6	1
A	headings()	0	19	1
A	__construct()	0	4	1

<?php

namespace App\Exports;

use App\Models\Examination_student;
use Illuminate\Contracts\Queue\ShouldQueue;
use Maatwebsite\Excel\Concerns\FromQuery;
use Maatwebsite\Excel\Concerns\Exportable;
use Maatwebsite\Excel\Concerns\FromCollection;
use Maatwebsite\Excel\Concerns\WithHeadings;
use Carbon\Carbon;

class ExaminationStudentsExport implements FromQuery , WithHeadings 
{

    use Exportable;

The trait Maatwebsite\Excel\Concerns\Exportable requires some properties which are not provided by App\Exports\ExaminationStudentsExport: $disk, $diskOptions, $fileName, $filePath, $writerType, $headers

    public function __construct($year,$grade)
    {
        $this->year = $year;

The property year does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->grade = $grade;

The property grade does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }
    
    public function headings(): array
    {
        return [
            'st_no',
            'stu_no',
            'nsid',
            'schoolid',
            'f_name',
            'medium',
            'b_date',
            'gender',
            'pvt_address',
            'a_income',
            'spl_need',
            'disability_type',
            'disability',
            'sp_center',
            'created_at',
            'updated_at'
        ];
    }
    
    /**
    * @return \Illuminate\Support\Collection
    */
    public function query()
    {
        return Examination_student::query()->whereNotNull('nsid')

The expression return App\Models\Examination_student::query()->whereNotNull('nsid')->distinct('nsid')->where('year', $this->year)->where('grade', $this->grade) also could return the type Illuminate\Database\Eloquent\Builder|Illuminate\Database\Query\Builder which is incompatible with the documented return type Illuminate\Support\Collection.

        ->distinct('nsid')

The call to Illuminate\Database\Query\Builder::distinct() has too many arguments starting with 'nsid'.

        ->where('year',$this->year)
        ->where('grade',$this->grade);
    }
}