RemoveDuplications::process() - Code Metrics - Inspection of "Preferred name" - moe-lk/bulk-upload - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#523)

by Mohamed

created 2020-10-08 12:21 UTC

RemoveDuplications::process() A

↳ Parent: RemoveDuplications

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	7
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	8
rs	10

<?php

namespace App\Console\Commands;

use Illuminate\Console\Command;
use Illuminate\Support\Facades\DB;
use App\Models\Institution_student;

class RemoveDuplications extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'student:clean {chunk} {max}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'This command is to clean students data';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        try {
            $this->start_time = microtime(TRUE);

            $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();

            $this->output->writeln('############### Starting delete Duplication ################');
            $duplicatedStudents = Institution_student::select(DB::raw('count(*) as total'),'student_id','id','academic_period_id','education_grade_id')
            ->groupBy('student_id')
            ->having('total','>',1)
            ->orderBy('student_id')
            ->get()
            ->toArray();
            if(count($duplicatedStudents)>0){
                processParallel(array($this,'process'),$duplicatedStudents,10);
            }else{
                $this->output->writeln('Nothing to Process, all are clean');
            }
        } catch (\Throwable $th) {
            dd($th);
        }
    }
  
    public function process($Student){
        Institution_student::where('institution_students.id','>',$Student['id'])
        ->where('institution_students.student_id',$Student['student_id'])
        ->where('institution_students.academic_period_id',$Student['academic_period_id'])
        ->where('institution_students.education_grade_id',$Student['education_grade_id'])
        ->delete();
        $this->end_time = microtime(TRUE);    

        $this->output->writeln('The cook took ' . ($this->end_time - $this->start_time) . ' seconds to complete');
    }
}


1			<?php
2
3			namespace App\Console\Commands;
4
5			use Illuminate\Console\Command;
6			use Illuminate\Support\Facades\DB;
7			use App\Models\Institution_student;
8
9			class RemoveDuplications extends Command
10			{
11			/**
12			* The name and signature of the console command.
13			*
14			* @var string
15			*/
16			protected $signature = 'student:clean {chunk} {max}';
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'This command is to clean students data';
24
25			/**
26			* Create a new command instance.
27			*
28			* @return void
29			*/
30			public function __construct()
31			{
32			parent::__construct();
33			}
34
35			/**
36			* Execute the console command.
37			*
38			* @return mixed
39			*/
40			public function handle()
41			{
42			try {
43			$this->start_time = microtime(TRUE);
			0 ignored issues – show Bug Best Practice introduced 2020-05-27 14:51 UTC by Report Bug Copy Issue Report The property `start_time` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
44			$this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
			0 ignored issues – show Documentation Bug introduced 2020-05-27 14:51 UTC by Report Bug Copy Issue Report It seems like `new Symfony\Component\Co...\Output\ConsoleOutput()` of type `Symfony\Component\Console\Output\ConsoleOutput` is incompatible with the declared type `Illuminate\Console\OutputStyle` of property `$output`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
45			$this->output->writeln('############### Starting delete Duplication ################');
46			$duplicatedStudents = Institution_student::select(DB::raw('count(*) as total'),'student_id','id','academic_period_id','education_grade_id')
47			->groupBy('student_id')
48			->having('total','>',1)
49			->orderBy('student_id')
50			->get()
51			->toArray();
52			if(count($duplicatedStudents)>0){
53			processParallel(array($this,'process'),$duplicatedStudents,10);
54			}else{
55			$this->output->writeln('Nothing to Process, all are clean');
56			}
57			} catch (\Throwable $th) {
58			dd($th);
59			}
60			}
61
62			public function process($Student){
63			Institution_student::where('institution_students.id','>',$Student['id'])
64			->where('institution_students.student_id',$Student['student_id'])
65			->where('institution_students.academic_period_id',$Student['academic_period_id'])
66			->where('institution_students.education_grade_id',$Student['education_grade_id'])
67			->delete();
68			$this->end_time = microtime(TRUE);
			0 ignored issues – show Bug Best Practice introduced 2020-09-01 18:29 UTC by Report Bug Copy Issue Report The property `end_time` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
69			$this->output->writeln('The cook took ' . ($this->end_time - $this->start_time) . ' seconds to complete');
70			}
71			}
72

moe-lk / bulk-upload

Pull Request — master (#523)

RemoveDuplications::process() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like