App\Console\Commands\RunAddStudentsToInstitutions

Complexity

Total Complexity

9

Size/Duplication

Total Lines	104
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	addStudents()	0	2	1
A	handle()	0	21	3
A	addStudent()	0	43	4

<?php

namespace App\Console\Commands;

use Illuminate\Console\Command;
use App\Models\Institution_class_student;
use App\Models\Institution_class_subject;
use App\Models\Institution_student_admission;
use App\Models\Institution_student;
use App\Models\Institution;
use Illuminate\Support\Facades\Log;

class RunAddStudentsToInstitutions extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'admission:students {institution}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Add approved students data to indtitution_student table';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        // dd('test');
        $institution = Institution::where([
            'id' => $this->argument('institution')
        ])->first();

        if(!is_null($institution)){

            // dd($institution);
            try {
                $this->info('adding missing students to the institution ' . $institution->name);

The property name does not seem to exist on App\Models\Institution. Are you sure there is no database migration missing?

                $approvedstudent = Institution_student_admission::select('institution_student_admission.*')->join('institutions', 'institution_id', '=', 'institutions.id')->leftJoin('institution_students', 'student_id', '=', 'institution_students.student_id')->where([
                    // 'status_id' => 121,122,123,124, // 
                    'institution_id' => $institution->id
                ])->get()->toArray();
                dd($approvedstudent);
                $approvedstudent = array_chunk($approvedstudent, 50);
                array_walk($approvedstudent, array($this, 'addStudents'));
            }catch (\Exception $e) {
                Log::error($e);
            }
        
        }
    }

    protected function addStudents($approvedstudent){
        array_walk($approvedstudent,array($this,'addStudent'));
    }

    protected function addStudent($approvedstudent){
        $output = new \Symfony\Component\Console\Output\ConsoleOutput();
        Log::info($approvedstudent);

        sleep(1);
        if(!(Institution_student::isDuplicated($approvedstudent) > 0)){
            $this->count += 1;

The property count does not exist on App\Console\Commands\RunAddStudentsToInstitutions. Did you maybe forget to declare it?

            $this->student = $approvedstudent ;

The property student does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            try{
               Institution_student::insert([
                   'student_status_id' => 1,
                   'student_id' => $approvedstudent['student_id'],
                   'education_grade_id' => $approvedstudent['education_grade_id'],
                   'academic_period_id' => $approvedstudent['academic_period_id'],
                   'start_date' => $approvedstudent['start_date'],
                   'start_year' => \Carbon\Carbon::createFromFormat('Y-m-d H:i:s', $approvedstudent['start_date'])->year , // $approvedstudent['start_date']->format('Y'),
                   'end_date' => $approvedstudent['end_date'],
                   'end_year' =>  \Carbon\Carbon::createFromFormat('Y-m-d H:i:s', $approvedstudent['end_date'])->year , //$approvedstudent['end_date']->format('Y'),
                   'institution_id' => $approvedstudent['institution_id'],
                   'admission_id' => $approvedstudent['admission_id'],
                   'created_user_id' => $approvedstudent['created_user_id'],
               ]);

               if(!is_null($approvedstudent['institution_class_id'])){
                   Institution_class_student::insert([
                       'student_id' => $approvedstudent['student_id'],
                       'institution_class_id' => $approvedstudent['institution_class_id'],
                       'education_grade_id' =>  $approvedstudent['education_grade_id'],
                       'academic_period_id' => $approvedstudent['academic_period_id'],
                       'institution_id' =>$approvedstudent['institution_id'],
                       'student_status_id' => 1,
                       'created_user_id' => $approvedstudent['created_user_id'],
                   ]);
               }
                $output->writeln('
        ####################################################
           Total number of students updated : '.$this->count.'
        #                                                  #
        ####################################################' );
//        $output->writeln();
           }catch (\Exception $e){
//               echo $e->getMessage();
               $output->writeln( $e->getMessage());
           }
        }

    }
}