UpdateClassEntriyWithZeroId::process() - Code Metrics - Inspection of "modify" - moe-lk/bulk-upload - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#566)

by Mohamed

created 2020-10-21 12:34 UTC

UpdateClassEntriyWithZeroId::process() B

↳ Parent: UpdateClassEntriyWithZeroId

Complexity

Conditions	4
Paths	3

Size

Total Lines	68
Code Lines	57

Duplication

Lines	0
Ratio	0 %

Importance

Changes	10
Bugs	0	Features	3

Metric	Value
cc	4
eloc	57
nc	3
nop	1
dl	0
loc	68
rs	8.9381
c	10
b	0
f	3

How to fix Long Method

<?php

namespace App\Console\Commands;

use App\Models\Institution;
use Illuminate\Console\Command;
use App\Models\Institution_class;
use Illuminate\Support\Facades\DB;
use App\Models\Institution_student;
use App\Models\Institution_class_student;
use App\Models\Institution_student_admission;
use App\Models\Security_user;
use Carbon\Carbon;

class UpdateClassEntriyWithZeroId extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'update:zero_id_class {from}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'update student class reference';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        DB::statement("SET SESSION sql_mode=(SELECT REPLACE(@@sql_mode,'ONLY_FULL_GROUP_BY',''));");
        $students = Institution_student::withTrashed()->where('updated_from',$this->argument('from'))
        ->get()->toArray();
        if(count($students)>0){
            array_walk($students,array($this,'process'));
        }else{
            echo "all are updated \r\n";
        }
    }

    public function process($student){
        $institution_class = Institution_class::select('id')->where('institution_id',$student['institution_id'])->get()->toArray();
        $wrongStudentsClass = Institution_class_student::whereNotIn('institution_class_id',$institution_class)
        ->orWhere('institution_class_id',0)
        ->where('student_id',$student['student_id'])
        ->get()->toArray();
        
        if(count($wrongStudentsClass)>0){
            Institution_class_student::where('student_id',$student['student_id'])->forceDelete();
            Institution_student_admission::where('student_id',$student['student_id'])->forceDelete();
            Institution_student::where('student_id',$student['student_id'])->forceDelete();

            array_walk($wrongStudentsClass,array($this,'updateClassCount'));
            
            echo "deleted wrong class reference:" .$student['student_id']; 

            $institutionClass =  Institution_class::getGradeClasses($student['education_grade_id'],$student['institution_id']);

            if(count($institutionClass) == 1){
                $start_date = new Carbon($student['start_date']);
                $end_date = new Carbon($student['end_date']);
                Institution_student_admission::create(
                    [
                        'student_id'=>$student['student_id'],
                        'institution_class_id'=>  $institutionClass[0]['id'],
                        'start_date' => $student['start_date'],
                        'start_year' => $start_date->format('Y'),
                        'end_date' => $student['start_date'],
                        'end_year' => $end_date->format('Y'),
                        'education_grade_id' => $student['education_grade_id'],
                        'institution_id' => $student['institution_id'],
                        'status_id' => 124,
                        'academic_period_id' => $student['academic_period_id'],
                        'created_user_id' => $student['created_user_id'],
                        'updated_from' => $student['updated_from']
                    ]
                );
                $institutionClassStudent = [
                    'student_id'=>$student['student_id'],
                    'institution_class_id'=>  $institutionClass[0]['id'],
                    'education_grade_id' => $student['education_grade_id'],
                    'institution_id' => $student['institution_id'],
                    'status_id' => 124,
                    'academic_period_id' => $student['academic_period_id'],
                    'student_status_id' => 1,
                    'created_user_id' => $student['created_user_id'],
                    'updated_from' => $student['updated_from']
                ];
                Institution_class_student::create($institutionClassStudent);
                Institution_student::create([
                    'student_id'=>$student['student_id'],
                    'student_status_id' => 1,
                    'education_grade_id' => $student['education_grade_id'],
                    'institution_id' => $student['institution_id'],
                    'academic_period_id' => $student['academic_period_id'],
                    'created_user_id' => $student['created_user_id'],
                    'start_date' => $student['start_date'],
                    'start_year' => $start_date->format('Y'),
                    'end_date' => $student['start_date'],
                    'end_year' => $end_date->format('Y'),
                    'taking_g5_exam' => $student['updated_from'] == 'doe' ? true: false,
                    'income_at_g5' =>  $student['income_at_g5'],
                    'updated_from' => $student['updated_from'],
                    'exam_center_for_special_education_g5' =>  $student['exam_center_for_special_education_g5'],
                    'modified_user_id' =>  $student['modified_user_id'],
                ]);
                echo "updated:" .$student['student_id']; 
                array_walk([$institutionClassStudent],array($this,'updateClassCount'));
                array_walk(/** @scrutinizer ignore-type */ [$institutionClassStudent],array($this,'updateClassCount'));
            }

        }
    }

    public function updateClassCount($institutionClass){
        $studentCount = Institution_class_student::getStudentsCount($institutionClass['institution_class_id']);
        Institution_class::where(['id' => $institutionClass['institution_class_id']])
        ->update([
            'total_male_students' => $studentCount['total_male_students'],
            'total_female_students' => $studentCount['total_female_students']
        ]);
    }
}


moe-lk / bulk-upload

Pull Request — master (#566)

UpdateClassEntriyWithZeroId::process() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like