Test Setup Failed
Pull Request — master (#610)
by Mohamed
14:20
created
app/Models/Upload.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 
7
-class Upload extends Model  {
7
+class Upload extends Model {
8 8
 
9 9
     /**
10 10
      * The database table used by the model.
@@ -43,12 +43,12 @@  discard block
 block discarded – undo
43 43
 
44 44
     public $timestamps = true;
45 45
 
46
-    public function user(){
47
-        return $this->belongsTo('App\Models\Security_user','security_user_id');
46
+    public function user() {
47
+        return $this->belongsTo('App\Models\Security_user', 'security_user_id');
48 48
     }
49 49
 
50
-    public function classRoom(){
51
-        return $this->belongsTo('App\Models\Institution_class','institution_class_id');
50
+    public function classRoom() {
51
+        return $this->belongsTo('App\Models\Institution_class', 'institution_class_id');
52 52
     }
53 53
 
54 54
 }
Please login to merge, or discard this patch.
app/Models/Academic_period.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 
7
-class Academic_period extends Base_Model  {
7
+class Academic_period extends Base_Model {
8 8
 
9 9
     /**
10 10
      * The database table used by the model.
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
41 41
      */
42 42
     protected $dates = ['start_date', 'end_date', 'modified', 'created'];
43 43
 
44
-    public function getAcademicPeriod($year){
45
-        return self::query()->where('code',$year)->first();
44
+    public function getAcademicPeriod($year) {
45
+        return self::query()->where('code', $year)->first();
46 46
     }
47 47
 
48 48
 }
Please login to merge, or discard this patch.
app/Models/Identity_type.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 
7
-class Identity_type extends Model  {
7
+class Identity_type extends Model {
8 8
 
9 9
     /**
10 10
      * The database table used by the model.
Please login to merge, or discard this patch.
app/Models/Base_Model.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@  discard block
 block discarded – undo
6 6
 use Illuminate\Database\Eloquent\Model;
7 7
 use Illuminate\Support\Facades\Auth;
8 8
 
9
-class Base_Model extends Model{
9
+class Base_Model extends Model {
10 10
 
11 11
 
12 12
 
@@ -18,10 +18,10 @@  discard block
 block discarded – undo
18 18
     {
19 19
 
20 20
         parent::boot();
21
-        self::creating(function ($model) {
21
+        self::creating(function($model) {
22 22
             $model->created = Carbon::now();
23 23
         });
24
-        self::updating(function ($model) {
24
+        self::updating(function($model) {
25 25
             $model->modified = Carbon::now();
26 26
         });
27 27
     }
Please login to merge, or discard this patch.
app/Models/Institution_class_subject.php 2 patches
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -109,8 +109,9 @@
 block discarded – undo
109 109
                 })
110 110
                 ->where('institution_class_id', '=', $student->institution_class_id)
111 111
                 ->get()->toArray();
112
-            if (!empty($subjectId))
113
-                $data[] = $subjectId[0];
112
+            if (!empty($subjectId)) {
113
+                            $data[] = $subjectId[0];
114
+            }
114 115
         }
115 116
         return $data;
116 117
     }
Please login to merge, or discard this patch.
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 use Webpatser\Uuid\Uuid;
7 7
 
8
-class Institution_class_subject extends Base_Model  {
8
+class Institution_class_subject extends Base_Model {
9 9
 
10 10
     /**
11 11
      * The database table used by the model.
@@ -42,19 +42,19 @@  discard block
 block discarded – undo
42 42
      */
43 43
     protected $dates = ['modified', 'created'];
44 44
 
45
-    public function institutionMandatorySubject(){
46
-        return $this->belongsTo('App\Models\Institution_subject','institution_subject_id','id')
45
+    public function institutionMandatorySubject() {
46
+        return $this->belongsTo('App\Models\Institution_subject', 'institution_subject_id', 'id')
47 47
         ->with('institutionGradeSubject')
48
-        ->whereHas('institutionGradeSubject', function ($query) {
49
-                $query->where('auto_allocation',1);
48
+        ->whereHas('institutionGradeSubject', function($query) {
49
+                $query->where('auto_allocation', 1);
50 50
         });
51 51
     }
52 52
 
53
-    public function institutionOptionalSubject(){
54
-        return $this->belongsTo('App\Models\Institution_subject','institution_subject_id','id')
53
+    public function institutionOptionalSubject() {
54
+        return $this->belongsTo('App\Models\Institution_subject', 'institution_subject_id', 'id')
55 55
         ->with('institutionGradeSubject')
56
-        ->whereHas('institutionGradeSubject', function ($query) {
57
-                $query->where('auto_allocation',0);
56
+        ->whereHas('institutionGradeSubject', function($query) {
57
+                $query->where('auto_allocation', 0);
58 58
         });
59 59
 
60 60
     }
@@ -62,23 +62,23 @@  discard block
 block discarded – undo
62 62
     public static function boot()
63 63
     {
64 64
         parent::boot();
65
-        self::creating(function ($model) {
65
+        self::creating(function($model) {
66 66
             $model->id = (string) Uuid::generate(4);
67 67
         });
68 68
     }
69 69
 
70
-    public function institutionSubject(){
71
-        return $this->belongsTo('App\Models\Institution_subject','institution_subject_id','id')
70
+    public function institutionSubject() {
71
+        return $this->belongsTo('App\Models\Institution_subject', 'institution_subject_id', 'id')
72 72
         ->with('institutionGradeSubject');
73 73
     }
74 74
 
75 75
 
76
-    public static function getMandetorySubjects($institutionClass){
76
+    public static function getMandetorySubjects($institutionClass) {
77 77
         $institutionGrade = Institution_class_grade::where('institution_class_id', '=', $institutionClass)->first();
78 78
         $mandatorySubject = Institution_class_subject::with(['institutionSubject'])
79
-            ->whereHas('institutionSubject', function ($query) use ($institutionGrade) {
80
-                $query->whereHas('institutionGradeSubject',function($query){
81
-                    $query->where('auto_allocation',1);
79
+            ->whereHas('institutionSubject', function($query) use ($institutionGrade) {
80
+                $query->whereHas('institutionGradeSubject', function($query) {
81
+                    $query->where('auto_allocation', 1);
82 82
                 })->where('education_grade_id', $institutionGrade->education_grade_id);
83 83
                 // ->where('auto_allocation', $institutionGrade->education_grade_id);
84 84
             })
@@ -87,10 +87,10 @@  discard block
 block discarded – undo
87 87
         return $mandatorySubject;
88 88
     }
89 89
 
90
-    public static function getAllSubjects($institutionClass){
90
+    public static function getAllSubjects($institutionClass) {
91 91
         $institutionGrade = Institution_class_grade::where('institution_class_id', '=', $institutionClass)->first();
92 92
         $allSubjects = Institution_class_subject::with(['institutionSubject'])
93
-        ->whereHas('institutionSubject', function ($query) use ($institutionGrade) {
93
+        ->whereHas('institutionSubject', function($query) use ($institutionGrade) {
94 94
             $query->whereHas('institutionGradeSubject')->where('education_grade_id', $institutionGrade->education_grade_id);
95 95
         })
96 96
         ->where('institution_class_id', '=', $institutionClass)
@@ -102,9 +102,9 @@  discard block
 block discarded – undo
102 102
         $data = [];
103 103
         foreach ($subjects as $subject) {
104 104
             $subjectId = Institution_class_subject::with(['institutionSubject'])
105
-                ->whereHas('institutionSubject', function ($query) use ($row, $subject, $student) {
106
-                    $query->whereHas('institutionGradeSubject',function($query){
107
-                        $query->where('auto_allocation',0);
105
+                ->whereHas('institutionSubject', function($query) use ($row, $subject, $student) {
106
+                    $query->whereHas('institutionGradeSubject', function($query) {
107
+                        $query->where('auto_allocation', 0);
108 108
                     })
109 109
                         ->where('name', '=', $row[$subject])
110 110
                         ->where('education_grade_id', '=', $student->education_grade_id);
@@ -117,15 +117,15 @@  discard block
 block discarded – undo
117 117
         return $data;
118 118
     }
119 119
 
120
-    public function getInstitutionClassSubjects($academicPeriodId,$classIds){
120
+    public function getInstitutionClassSubjects($academicPeriodId, $classIds) {
121 121
         return self::query()
122
-            ->whereIn('institution_class_id',$classIds)
122
+            ->whereIn('institution_class_id', $classIds)
123 123
             ->get()
124 124
             ->toArray();
125 125
     }
126 126
 
127
-    public function isDuplicated($subject){
128
-        return self::query()->where('institution_subject_id',$subject['institution_subject_id'])
129
-            ->where('institution_class_id',$subject['institution_class_id'])->get()->toArray();
127
+    public function isDuplicated($subject) {
128
+        return self::query()->where('institution_subject_id', $subject['institution_subject_id'])
129
+            ->where('institution_class_id', $subject['institution_class_id'])->get()->toArray();
130 130
     }
131 131
 }
Please login to merge, or discard this patch.
app/Models/Special_need_difficulty.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 
7
-class Special_need_difficulty extends Model  {
7
+class Special_need_difficulty extends Model {
8 8
 
9 9
     /**
10 10
      * The database table used by the model.
Please login to merge, or discard this patch.
app/Models/Institution_shift.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
     protected $dates = ['modified', 'created'];
43 43
 
44 44
     public function shiftExists($shift){
45
-       return self::query()
45
+        return self::query()
46 46
             ->where('institution_id',$shift['institution_id'])
47 47
             ->where('location_institution_id',$shift['location_institution_id'])
48 48
             ->where('shift_option_id',$shift['shift_option_id'])
Please login to merge, or discard this patch.
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 
7
-class Institution_shift extends Base_Model  {
7
+class Institution_shift extends Base_Model {
8 8
 
9 9
     /**
10 10
      * The database table used by the model.
@@ -41,40 +41,40 @@  discard block
 block discarded – undo
41 41
      */
42 42
     protected $dates = ['modified', 'created'];
43 43
 
44
-    public function shiftExists($shift){
44
+    public function shiftExists($shift) {
45 45
        return self::query()
46
-            ->where('institution_id',$shift['institution_id'])
47
-            ->where('location_institution_id',$shift['location_institution_id'])
48
-            ->where('shift_option_id',$shift['shift_option_id'])
49
-            ->where('academic_period_id',$shift['academic_period_id'])->exists();
46
+            ->where('institution_id', $shift['institution_id'])
47
+            ->where('location_institution_id', $shift['location_institution_id'])
48
+            ->where('shift_option_id', $shift['shift_option_id'])
49
+            ->where('academic_period_id', $shift['academic_period_id'])->exists();
50 50
     }
51 51
 
52
-    public function getShift($shift){
52
+    public function getShift($shift) {
53 53
         return self::query()
54
-            ->where('institution_id',$shift['institution_id'])
55
-            ->where('location_institution_id',$shift['location_institution_id'])
56
-            ->where('shift_option_id',$shift['shift_option_id'])
57
-            ->where('academic_period_id',$shift['academic_period_id'])->first();
54
+            ->where('institution_id', $shift['institution_id'])
55
+            ->where('location_institution_id', $shift['location_institution_id'])
56
+            ->where('shift_option_id', $shift['shift_option_id'])
57
+            ->where('academic_period_id', $shift['academic_period_id'])->first();
58 58
     }
59 59
 
60
-    public function getShiftsToClone(string $year,$limit,$mode){
60
+    public function getShiftsToClone(string $year, $limit, $mode) {
61 61
         return self::query()
62 62
             ->select('institution_shifts.*')
63
-            ->join('academic_periods','academic_periods.id','=','institution_shifts.academic_period_id')
64
-            ->where('academic_periods.code',$year)
65
-            ->whereNotIn('institution_shifts.cloned',[ !$mode ? '2020' : '2018/2019'])
63
+            ->join('academic_periods', 'academic_periods.id', '=', 'institution_shifts.academic_period_id')
64
+            ->where('academic_periods.code', $year)
65
+            ->whereNotIn('institution_shifts.cloned', [!$mode ? '2020' : '2018/2019'])
66 66
             ->groupBy('institution_shifts.id')
67 67
             ->limit($limit)
68 68
             ->get()
69 69
             ->toArray();
70 70
     }
71 71
 
72
-    public function getShiftsTodelete(string $year,$academic_period_id){
72
+    public function getShiftsTodelete(string $year, $academic_period_id) {
73 73
         return self::query()
74 74
             // ->select('institution_shifts.*','academic_periods.academic_period_id')
75
-            ->join('academic_periods','academic_periods.id','=','institution_shifts.academic_period_id')
76
-            ->where('academic_period_id',$academic_period_id)
77
-            ->where('institution_shifts.cloned',$year)
75
+            ->join('academic_periods', 'academic_periods.id', '=', 'institution_shifts.academic_period_id')
76
+            ->where('academic_period_id', $academic_period_id)
77
+            ->where('institution_shifts.cloned', $year)
78 78
             ->get()->toArray();
79 79
     }
80 80
 }
Please login to merge, or discard this patch.
app/Models/Security_role.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -4,7 +4,7 @@  discard block
 block discarded – undo
4 4
 
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 
7
-class Security_role extends Model  {
7
+class Security_role extends Model {
8 8
 
9 9
     /**
10 10
      * The database table used by the model.
@@ -42,8 +42,8 @@  discard block
 block discarded – undo
42 42
     protected $dates = ['modified', 'created'];
43 43
 
44 44
 
45
-    public function securityUsers(){
46
-        return $this->belongsToMany(Security_group_user::class,'security_group_users','security_group_id','security_group_id');
45
+    public function securityUsers() {
46
+        return $this->belongsToMany(Security_group_user::class, 'security_group_users', 'security_group_id', 'security_group_id');
47 47
     }
48 48
 
49 49
 
Please login to merge, or discard this patch.
app/Models/User_identity.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
 use Illuminate\Database\Eloquent\Model;
6 6
 use Webpatser\Uuid\Uuid;
7 7
 
8
-class User_identity extends Model  {
8
+class User_identity extends Model {
9 9
     
10 10
     public const CREATED_AT = 'created';
11 11
     public const UPDATED_AT = 'modified';
Please login to merge, or discard this patch.