App\Console\Commands\RemoveDuplicatedGuardians

Complexity

Total Complexity

5

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	delete()	0	11	2
A	handle()	0	11	2

<?php

namespace App\Console\Commands;

use Illuminate\Console\Command;
use App\Models\Student_guardian;
use Illuminate\Support\Facades\DB;

class RemoveDuplicatedGuardians extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'clean:guardian';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Command description';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        try {
            $this->start_time = microtime(TRUE);

The property start_time does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();

It seems like new Symfony\Component\Console\Output\ConsoleOutput() of type Symfony\Component\Console\Output\ConsoleOutput is incompatible with the declared type Illuminate\Console\OutputStyle of property $output.

            $this->output->writeln('############### Starting delete Duplication ################');
            Student_guardian::withTrashed()->restore();
            $this->delete();
            $this->end_time  = microtime(TRUE);

The property end_time does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $this->output->writeln('The cook took ' . ($this->end_time - $this->start_time) . ' seconds to complete');
        } catch (\Throwable $th) {

Consider adding a comment why this CATCH block is empty.

        }
    }

    public function delete(){
       try{
           DB::statement("UPDATE  student_guardians t1
           INNER JOIN student_guardians t2 
               set t1.deleted_at=now() 
           WHERE 
               t1.id > t2.id AND
               t1.student_id = t2.student_id AND
               t1.guardian_id = t2.guardian_id");
       }catch(\Exception $e){
           dd($e);
       }
    }
}