moe-lk / bulk-upload

app/Exports/ExaminationStudentsExport.php

Spacing +2 added lines, -2 removed lines

@@ -10,7 +10,7 @@ 
 use Maatwebsite\Excel\Concerns\WithHeadings;
 use Carbon\Carbon;
 
-class ExaminationStudentsExport implements FromQuery , WithHeadings 
+class ExaminationStudentsExport implements FromQuery, WithHeadings 
 {
 
     use Exportable;
@@ -44,6 +44,6 @@ 
     {
         return Examination_student::query()->whereNotNull('nsid')
         ->distinct('nsid')
-        ->whereDate('updated_at','>=',Carbon::today());
+        ->whereDate('updated_at', '>=', Carbon::today());
     }
 }

app/Http/Controllers/ExaminationStudentsController.php

Spacing +39 added lines, -39 removed lines

@@ -30,7 +30,7 @@ 
         $this->grade = $grade;
         $this->student = new Security_user();
         $this->examination_student = new Examination_student();
-        $this->academic_period =  Academic_period::where('code', '=', $this->year)->first();
+        $this->academic_period = Academic_period::where('code', '=', $this->year)->first();
         $this->education_grade = Education_grade::where('code', '=', $this->grade)->first();
         $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
     }
@@ -72,10 +72,10 @@ 
                     );
                     Session::flash('message', 'File upload successfully!');
                     // Redirect to index
-                } else {
+                }else {
                     Session::flash('message', 'File too large. File must be less than 20MB.');
                 }
-            } else {
+            }else {
                 Session::flash('message', 'Invalid File Extension.');
             }
         }
@@ -97,7 +97,7 @@ 
             $import->import($excelFile, 'local', \Maatwebsite\Excel\Excel::CSV);
             if ($import->failures()->count() > 0) {
                 $errors = $import->failures();
-                $columns =  [
+                $columns = [
                     'remarks',
                     'st_no',
                     'stu_no',
@@ -118,10 +118,10 @@ 
                 Storage::put($file, implode(',', $columns));
 
                 foreach ($errors as $error) {
-                    Storage::append($file, implode(':', $error->errors()) . ',' . implode(',', $error->values()));
+                    Storage::append($file, implode(':', $error->errors()).','.implode(',', $error->values()));
                 }
             }
-        } catch (\Maatwebsite\Excel\Validators\ValidationException $e) {
+        }catch (\Maatwebsite\Excel\Validators\ValidationException $e) {
         }
     }
 
@@ -135,9 +135,9 @@ 
         $students = [];
         switch ($mode) {
             case 'duplicate':
-                $students =  DB::table('examination_students as es')
+                $students = DB::table('examination_students as es')
                     ->select(DB::raw('count(*) as total'), 'e2.*')
-                    ->join('examination_students as e2', 'es.nsid','e2.nsid')
+                    ->join('examination_students as e2', 'es.nsid', 'e2.nsid')
                     ->having('total', '>', 1)
                     ->groupBy('e2.st_no')
                     ->orderBy('e2.st_no')
@@ -145,18 +145,18 @@ 
                     ->limit($limit)
                     ->get()->toArray();
                 $students = (array) json_decode(json_encode($students));
-                $this->output->writeln(count($students) . 'students remaining duplicate');
+                $this->output->writeln(count($students).'students remaining duplicate');
                 array_walk($students, array($this, 'clone'));
                 $this->output->writeln('All are generated');
                 break;
             case 'empty';
                 $students = Examination_student::whereNull('nsid')
-                    ->orWhere('nsid','<>','')
+                    ->orWhere('nsid', '<>', '')
                     ->offset($offset)
                     ->limit($limit)
                     ->get()->toArray();
                 $students = (array) json_decode(json_encode($students));
-                $this->output->writeln(count($students) . 'students remaining empty');
+                $this->output->writeln(count($students).'students remaining empty');
                 array_walk($students, array($this, 'clone'));
                 $this->output->writeln('All are generated');
                 break;
@@ -165,7 +165,7 @@ 
                     whereRaw('CHAR_LENGTH(nsid) > 11')
                     ->get()->toArray();
                 $students = (array) json_decode(json_encode($students));
-                $this->output->writeln(count($students) . 'students remaining with wrong NSID');
+                $this->output->writeln(count($students).'students remaining with wrong NSID');
                 array_walk($students, array($this, 'clone'));
                 $this->output->writeln('All are generated');
                 break;
@@ -174,14 +174,14 @@ 
                 ->count();
                 $all = Examination_student::select('nsid')
                     ->count();
-                $this->output->writeln( $all. 'Total Unique nsid are: ' .$count);
+                $this->output->writeln($all.'Total Unique nsid are: '.$count);
                 break;
             default:
                 $students = Examination_student::offset($offset)
                     ->limit($limit)
                     ->get()->toArray();
                 $students = (array) json_decode(json_encode($students));
-                $this->output->writeln(count($students) . 'students remaining empty');
+                $this->output->writeln(count($students).'students remaining empty');
                 array_walk($students, array($this, 'clone'));
                 $this->output->writeln('All are generated');
         }
@@ -227,13 +227,13 @@ 
      */
     public function clone($student)
     {
-        $student = (array)json_decode(json_encode($student));
+        $student = (array) json_decode(json_encode($student));
         //get student matching with same dob and gender
 
         $matchedStudent = $this->getMatchingStudents($student);
 
         // if the first match missing do complete insertion
-        $institution = Institution::where('code', '=', (int)$student['schoolid'])->first();
+        $institution = Institution::where('code', '=', (int) $student['schoolid'])->first();
 
         if (!is_null($institution)) {
 
@@ -260,7 +260,7 @@ 
 
                 //TODO implement insert student to admission table
                 $student['id'] = $sis_student['id'];
-                $sis_student['student_id'] =  $student['id'];
+                $sis_student['student_id'] = $student['id'];
 
                 $student = $this->setIsTakingExam($student);
                 if (count($institutionClass) == 1) {
@@ -268,13 +268,13 @@ 
                     Institution_student::createExaminationData($student, $admissionInfo);
                     Institution_student_admission::createExaminationData($student, $admissionInfo);
                     Institution_class_student::createExaminationData($student, $admissionInfo);
-                } else {
+                }else {
                     Institution_student_admission::createExaminationData($student, $admissionInfo);
                     Institution_student::createExaminationData($student, $admissionInfo);
                 }
                 $this->updateStudentId($student, $sis_student);
                 // update the matched student's data    
-            } else {
+            }else {
                 $student = $this->setIsTakingExam($student);
                 $studentData = $this->student->updateExaminationStudent($student, $matchedStudent);
                 $matchedStudent = array_merge((array) $student, $matchedStudent);
@@ -282,9 +282,9 @@ 
                 Institution_student::updateExaminationData($studentData, $admissionInfo);
                 $this->updateStudentId($student, $studentData);
             }
-        } else {
+        }else {
 
-            $this->output->writeln('Student ' . $student['st_no'] . ' not imorted' . $student['f_name']);
+            $this->output->writeln('Student '.$student['st_no'].' not imorted'.$student['f_name']);
         }
     }
 
@@ -301,18 +301,18 @@ 
         /**
          */
         $sis_student = $this->student->getMatches($student);
-        $doe_students =  Examination_student::where('gender',$student['gender'])
-            ->where('b_date',$student['b_date'])
-            ->where('schoolid',$student['schoolid'])
+        $doe_students = Examination_student::where('gender', $student['gender'])
+            ->where('b_date', $student['b_date'])
+            ->where('schoolid', $student['schoolid'])
             ->count();
         $count = $this->student->getStudentCount($student);
 
         $studentData = [];
-        $sis_users  = (array) json_decode(json_encode($sis_student), true);
+        $sis_users = (array) json_decode(json_encode($sis_student), true);
         // if the same gender same DOE has more than one 
-        if(($doe_students > 1) || ($count > 1)){
-            $studentData = $this->searchSimilarName($student, $sis_users,false);
-        }else{
+        if (($doe_students > 1) || ($count > 1)) {
+            $studentData = $this->searchSimilarName($student, $sis_users, false);
+        }else {
             $studentData = $this->searchSimilarName($student, $sis_users);
         }   
         return $studentData;
@@ -325,7 +325,7 @@ 
      * @param array $sis_students
      * @return array
      */
-    public function searchSimilarName($student, $sis_students,$surname_search = true)
+    public function searchSimilarName($student, $sis_students, $surname_search = true)
     {
         $highest = [];
         $minDistance = 0;
@@ -345,7 +345,7 @@ 
             }
         }
 
-        if($surname_search){
+        if ($surname_search) {
             if (empty($highest)) {
                 foreach ($sis_students as $key => $value) {
                     //search name with last name
@@ -361,8 +361,8 @@ 
             }
         }
 
-        if(count($matches)>1){
-            $highest =  $this->searchSimilarName($student, $sis_students,false);
+        if (count($matches) > 1) {
+            $highest = $this->searchSimilarName($student, $sis_students, false);
         }
 
         return $highest;
@@ -378,18 +378,18 @@ 
     public function updateStudentId($student, $sis_student)
     {
         try {
-            $student['nsid'] =  $sis_student['openemis_no'];
+            $student['nsid'] = $sis_student['openemis_no'];
             // add new NSID to the examinations data set
             unset($student['id']);
             unset($student['taking_g5_exam']);
             unset($student['taking_al_exam']);
             unset($student['taking_ol_exam']);
             unset($student['total']);
-            $students['updated_at'] =  now();
+            $students['updated_at'] = now();
             $this->examination_student->where('st_no', $student['st_no'])->update($student);
             unset($student['st_no']);
-            $this->output->writeln('Updated  to NSID' . $sis_student['openemis_no']);
-        } catch (\Exception $th) {
+            $this->output->writeln('Updated  to NSID'.$sis_student['openemis_no']);
+        }catch (\Exception $th) {
             dd($th);
             $this->output->writeln('error');
             Log::error($th);
@@ -407,7 +407,7 @@ 
         try {
             (new ExaminationStudentsExport)->store('examination/student_data_with_nsid.'.time().'.csv');
             (new ExportReady($adminUser));
-        } catch (\Throwable $th) {
+        }catch (\Throwable $th) {
             //throw $th;
             dd($th);
         }
@@ -417,13 +417,13 @@ 
     public function downloadErrors()
     {
 
-        $file_path = storage_path() . '/app/examination/errors.csv';
+        $file_path = storage_path().'/app/examination/errors.csv';
         return Response::download($file_path);
     }
 
     public function downloadProcessedFile()
     {
-        $file_path = storage_path() . '/app/examination/student_data_with_nsid.csv';
+        $file_path = storage_path().'/app/examination/student_data_with_nsid.csv';
         return Response::download($file_path);
     }
 }

app/Http/Controllers/FilesController.php

Spacing +32 added lines, -32 removed lines

@@ -13,101 +13,101 @@
 
     public function index()
     {
-        return Datatables::of(Upload::with(['classRoom'])->where('security_user_id','=',Auth::user()->id))
-            ->editColumn('is_processed', function ($data) {
+        return Datatables::of(Upload::with(['classRoom'])->where('security_user_id', '=', Auth::user()->id))
+            ->editColumn('is_processed', function($data) {
 
                 $nowTime = \Carbon\Carbon::now();
                 $to = \Carbon\Carbon::createFromFormat('Y-m-d H:s:i', $nowTime);
                 $from = \Carbon\Carbon::createFromFormat('Y-m-d H:s:i', $data->updated_at);
                 $diff_in_hours = $to->diffInHours($from);
 
-                if($diff_in_hours >= 2 && $data->is_processed == 3){
+                if ($diff_in_hours >= 2 && $data->is_processed == 3) {
                     return "Terminated";
                 }
                 elseif ($data->is_processed === 1) {
                     return "Success";
-                }elseif ($data->is_processed === 2){
+                }elseif ($data->is_processed === 2) {
                     return "Failed";
-                }elseif($diff_in_hours < 2 && $data->is_processed == 3){
+                }elseif ($diff_in_hours < 2 && $data->is_processed == 3) {
                     return "Processing";
-                }elseif ($data->is_processed == 4){
+                }elseif ($data->is_processed == 4) {
                     return "Process Paused";
-                }else{
+                }else {
                     return 'Pending';
                 };
 
             })
-            ->editColumn('is_email_sent', function ($data) {
+            ->editColumn('is_email_sent', function($data) {
                 if ($data->is_email_sent == 1) {
                     return "Success";
-                }elseif($data->is_email_sent == 2 ){
+                }elseif ($data->is_email_sent == 2) {
                     return 'Failed';
-                }else{
+                }else {
                     return 'Pending';
                 };
 
             })
-            ->editColumn('update', function ($data) {
-                if ((int)$data->update  == 0) {
+            ->editColumn('update', function($data) {
+                if ((int) $data->update == 0) {
                     return "No Processes";
-                }elseif((int)$data->update == 1 ){
+                }elseif ((int) $data->update == 1) {
                     return 'Success';
-                }elseif((int)$data->update == 2 ){
+                }elseif ((int) $data->update == 2) {
                     return 'Failed';
-                }elseif((int)$data->update == 3 ){
+                }elseif ((int) $data->update == 3) {
                     return 'Partial Success';
                 };
 
             })
-            ->editColumn('insert', function ($data) {
+            ->editColumn('insert', function($data) {
                 if ($data->insert == 0) {
                     return "No Processes";
-                }elseif($data->insert == 1 ){
+                }elseif ($data->insert == 1) {
                     return 'Success';
-                }elseif($data->insert == 2 ){
+                }elseif ($data->insert == 2) {
                     return 'Failed';
-                }elseif($data->insert == 3 ){
+                }elseif ($data->insert == 3) {
                     return 'Partial Success';
                 };
 
             })
-            ->editColumn('filename', function ($data) {
-                if(\App::environment('local') || \App::environment('stage')){
+            ->editColumn('filename', function($data) {
+                if (\App::environment('local') || \App::environment('stage')) {
                     return '<a href="/download_file/'.$data->filename.'">'.$data->classRoom->name.'</a>';
 
-                }else{
+                }else {
                     return '<a href="/bulk-upload/download_file/'.$data->filename.'">'.$data->classRoom->name.'</a>';
                 }
 
             })
-             ->editColumn('error', function ($data) {
-                if(\App::environment('local') || \App::environment('stage')){
+             ->editColumn('error', function($data) {
+                if (\App::environment('local') || \App::environment('stage')) {
                     return '<a href="/download/'.$data->filename.'">'.$data->classRoom->name.'</a>';
 
-                }else{
+                }else {
                     return '<a href="/bulk-upload/download/'.$data->filename.'">'.$data->classRoom->name.'</a>';
                 }
 
-            })->editColumn('actions', function ($data) {
+            })->editColumn('actions', function($data) {
 
                 $nowTime = \Carbon\Carbon::now();
                 $to = \Carbon\Carbon::createFromFormat('Y-m-d H:s:i', $nowTime);
                 $from = \Carbon\Carbon::createFromFormat('Y-m-d H:s:i', $data->updated_at);
                 $diff_in_hours = $to->diffInHours($from);
 
-                if($diff_in_hours >= 2 && $data->is_processed == 3){
+                if ($diff_in_hours >= 2 && $data->is_processed == 3) {
                     return '<button onclick="updateProcess('.($data->id).',100)" class="btn btn-primary text-uppercase">reprocess</button>';
-                }elseif ($data->is_processed == 1){
+                }elseif ($data->is_processed == 1) {
                     return '<div><h6>Processing <span class="badge badge-success text-uppercase">Successful</span></h6></div>';
-                }elseif ($data->is_processed == 2){
+                }elseif ($data->is_processed == 2) {
                     return '<div><h6>Processing <span class="badge badge-danger text-uppercase">Failed</span></h6></div>';
-                }elseif ($data->is_processed == 0){
+                }elseif ($data->is_processed == 0) {
                     return '<button onclick="updateProcess('.($data->id).',200)" class="btn btn-block btn-warning text-uppercase">pause</button>';
-                }elseif ($data->is_processed == 4){
+                }elseif ($data->is_processed == 4) {
                     return '<button onclick="updateProcess('.($data->id).',100)" class="btn btn-block btn-success text-uppercase">resume</button>';
                 }
             })
-            ->rawColumns(['filename','error','actions'])
+            ->rawColumns(['filename', 'error', 'actions'])
             ->make(true);
     }
 

app/Console/Commands/OpenTOPending.php

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
      */
     public function handle()
     {
-        Institution_student_admission::where('status_id',121)->update([
+        Institution_student_admission::where('status_id', 121)->update([
             'status_id' => 122
         ]);
     }

app/Console/Commands/UpdatePreferredName.php

Spacing +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
      */
     public function handle()
     {
-        Security_user::where('is_student',true)
+        Security_user::where('is_student', true)
         ->whereRaw('CHAR_LENGTH(first_name) <= 90')
         ->update(['preferred_name' =>  DB::raw('first_name')]);
     }

app/Console/Commands/UpdateDoeDataGrade.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
     public function handle()
     {
         Institution_student::where('updated_from', 'doe')
-            ->where('education_grade_id','<>', 4)
+            ->where('education_grade_id', '<>', 4)
             ->update(['education_grade_id' => 4]);
     }
 }

app/Imports/UsersImport.php

Spacing +29 added lines, -29 removed lines

@@ -75,7 +75,7 @@ 
     public function registerEvents(): array
     {
         return [
-            BeforeSheet::class => function (BeforeSheet $event) {
+            BeforeSheet::class => function(BeforeSheet $event) {
                 $this->sheetNames[] = $event->getSheet()->getTitle();
                 $this->worksheet = $event->getSheet();
                 $this->validateClass();
@@ -87,7 +87,7 @@ 
                     throw new \Maatwebsite\Excel\Validators\ValidationException($error, $failures);
                 }
             },
-            BeforeImport::class => function (BeforeImport $event) {
+            BeforeImport::class => function(BeforeImport $event) {
                 $this->highestRow = ($event->getReader()->getDelegate()->getActiveSheet()->getHighestDataRow('C'));
                 if ($this->highestRow < 3) {
                     $error = \Illuminate\Validation\ValidationException::withMessages([]);
@@ -114,7 +114,7 @@ 
                 $mandatorySubject = Institution_class_subject::getMandetorySubjects($this->file['institution_class_id']);
                 // dd($mandatorySubject);
                 $subjects = getMatchingKeys($row);
-                $genderId  = null;
+                $genderId = null;
                 switch ($row['gender_mf']) {
                     case 'M':
                         $genderId = $row['gender_mf'] = 1;
@@ -122,15 +122,15 @@ 
                         $this->maleStudentsCount += 1;
                         break;
                     case 'F':
-                        $genderId =  $row['gender_mf'] = 2;
+                        $genderId = $row['gender_mf'] = 2;
                         $genderId = 2;
                         $this->femaleStudentsCount += 1;
                         break;
                 }
 
-                $BirthArea = Area_administrative::where('name', 'like', '%' . $row['birth_registrar_office_as_in_birth_certificate'] . '%')->first();
-                $nationalityId = Nationality::where('name', 'like', '%' . $row['nationality'] . '%')->first();
-                $identityType = Identity_type::where('national_code', 'like', '%' . $row['identity_type'] . '%')->first();
+                $BirthArea = Area_administrative::where('name', 'like', '%'.$row['birth_registrar_office_as_in_birth_certificate'].'%')->first();
+                $nationalityId = Nationality::where('name', 'like', '%'.$row['nationality'].'%')->first();
+                $identityType = Identity_type::where('national_code', 'like', '%'.$row['identity_type'].'%')->first();
                 $academicPeriod = Academic_period::where('name', '=', $row['academic_period'])->first();
 
 
@@ -150,7 +150,7 @@ 
                     if (array_key_exists('preferred_name', $row)) {
                     $preferred_name = $row['preferred_name'];
                 }
-                $student =  Security_user::create([
+                $student = Security_user::create([
                     'username' => str_replace('-', '', $openemisStudent),
                     'openemis_no' => $openemisStudent,
                     'first_name' => $row['full_name'], // here we save full name in the column of first name. re reduce breaks of the system.
@@ -240,9 +240,9 @@ 
                 if (!empty($row['bmi_weight']) && !empty($row['bmi_weight']) && !empty($row['bmi_date_yyyy_mm_dd'])) {
                     try {
                         // convert Meeter to CM
-                        $hight = $row['bmi_height'] / 100;
+                        $hight = $row['bmi_height']/100;
                         //calculate BMI
-                        $bodyMass = ($row['bmi_weight']) / pow($hight, 2);
+                        $bodyMass = ($row['bmi_weight'])/pow($hight, 2);
 
                         $bmiAcademic = Academic_period::where('name', '=', $row['bmi_academic_period'])->first();
 
@@ -256,17 +256,17 @@ 
                             'security_user_id' => $student->student_id,
                             'created_user_id' => $this->file['security_user_id']
                         ]);
-                    } catch (\Throwable $th) {
-                        \Log::error('User_body_mass:' . $th->getMessage());
+                    }catch (\Throwable $th) {
+                        \Log::error('User_body_mass:'.$th->getMessage());
                     }
                 }
 
 
                 if (!empty($row['fathers_full_name']) && ($row['fathers_date_of_birth_yyyy_mm_dd'] !== null)) {
 
-                    $AddressArea = Area_administrative::where('name', 'like', '%' . $row['fathers_address_area'] . '%')->first();
-                    $nationalityId = Nationality::where('name', 'like', '%' . $row['fathers_nationality'] . '%')->first();
-                    $identityType = Identity_type::where('national_code', 'like', '%' . $row['fathers_identity_type'] . '%')->first();
+                    $AddressArea = Area_administrative::where('name', 'like', '%'.$row['fathers_address_area'].'%')->first();
+                    $nationalityId = Nationality::where('name', 'like', '%'.$row['fathers_nationality'].'%')->first();
+                    $identityType = Identity_type::where('national_code', 'like', '%'.$row['fathers_identity_type'].'%')->first();
                     $openemisFather = $this->uniqueUid::getUniqueAlphanumeric();
 
                     $identityType = ($identityType !== null) ? $identityType->id : null;
@@ -304,7 +304,7 @@ 
                             User_contact::createOrUpdate($father, $this->file['security_user_id']);
                         }
                         Student_guardian::createStudentGuardian($student, $father, $this->file['security_user_id']);
-                    } else {
+                    }else {
                         Security_user::where('id', '=', $father->id)
                             ->update(['is_guardian' => 1]);
                         $father['guardian_relation_id'] = 1;
@@ -317,9 +317,9 @@ 
                 }
 
                 if (!empty($row['mothers_full_name']) && ($row['mothers_date_of_birth_yyyy_mm_dd'] !== null)) {
-                    $AddressArea = Area_administrative::where('name', 'like', '%' . $row['mothers_address_area'] . '%')->first();
-                    $nationalityId = Nationality::where('name', 'like', '%' . $row['mothers_nationality'] . '%')->first();
-                    $identityType = Identity_type::where('national_code', 'like', '%' . $row['mothers_identity_type'] . '%')->first();
+                    $AddressArea = Area_administrative::where('name', 'like', '%'.$row['mothers_address_area'].'%')->first();
+                    $nationalityId = Nationality::where('name', 'like', '%'.$row['mothers_nationality'].'%')->first();
+                    $identityType = Identity_type::where('national_code', 'like', '%'.$row['mothers_identity_type'].'%')->first();
                     $openemisMother = $this->uniqueUid::getUniqueAlphanumeric();
 
                     $identityType = $identityType !== null ? $identityType->id : null;
@@ -355,7 +355,7 @@ 
                             User_contact::createOrUpdate($mother, $this->file['security_user_id']);
                         }
                         Student_guardian::createStudentGuardian($student, $mother, $this->file['security_user_id']);
-                    } else {
+                    }else {
                         Security_user::where('id', '=', $mother->id)
                             ->update(['is_guardian' => 1]);
                         $mother['guardian_relation_id'] = 2;
@@ -370,9 +370,9 @@ 
 
                 if (!empty($row['guardians_full_name']) && ($row['guardians_date_of_birth_yyyy_mm_dd'] !== null)) {
                     $genderId = $row['guardians_gender_mf'] == 'M' ? 1 : 2;
-                    $AddressArea = Area_administrative::where('name', 'like', '%' . $row['guardians_address_area'] . '%')->first();
-                    $nationalityId = Nationality::where('name', 'like', '%' . $row['guardians_nationality'] . '%')->first();
-                    $identityType = Identity_type::where('national_code', 'like', '%' . $row['guardians_identity_type'] . '%')->first();
+                    $AddressArea = Area_administrative::where('name', 'like', '%'.$row['guardians_address_area'].'%')->first();
+                    $nationalityId = Nationality::where('name', 'like', '%'.$row['guardians_nationality'].'%')->first();
+                    $identityType = Identity_type::where('national_code', 'like', '%'.$row['guardians_identity_type'].'%')->first();
                     $openemisGuardian = $this->uniqueUid::getUniqueAlphanumeric();
 
                     $identityType = $identityType !== null ? $identityType->id : null;
@@ -409,7 +409,7 @@ 
                             User_contact::createOrUpdate($guardian, $this->file['security_user_id']);
                         }
                         Student_guardian::createStudentGuardian($student, $guardian, $this->file['security_user_id']);
-                    } else {
+                    }else {
                         Security_user::where('id', '=', $guardian->id)
                             ->update(['is_guardian' => 1]);
                         $guardian['guardian_relation_id'] = 3;
@@ -441,7 +441,7 @@ 
 
                 if ($totalStudents['total'] > $institutionClass->no_of_students) {
                     $error = \Illuminate\Validation\ValidationException::withMessages([]);
-                    $failure = new Failure(3, 'rows', [3 => 'Class student count exceeded! Max number of students is ' . $institutionClass->no_of_students], [null]);
+                    $failure = new Failure(3, 'rows', [3 => 'Class student count exceeded! Max number of students is '.$institutionClass->no_of_students], [null]);
                     $failures = [0 => $failure];
                     throw new \Maatwebsite\Excel\Validators\ValidationException($error, $failures);
                     Log::info('email-sent', [$this->file]);
@@ -453,7 +453,7 @@ 
                         'total_female_students' => $totalStudents['total_female_students']
                     ]);
             }
-        } catch (\Maatwebsite\Excel\Validators\ValidationException $e) {
+        }catch (\Maatwebsite\Excel\Validators\ValidationException $e) {
             $error = \Illuminate\Validation\ValidationException::withMessages([]);
             //            $failure = new Failure(3, 'remark', [3 => ], [null]);
             $failures = $e->failures();
@@ -469,7 +469,7 @@ 
             '*.full_name' => 'required|regex:/^[\pL\s\-]+$/u|max:256',
             '*.preferred_name' => 'nullable|regex:/^[\pL\s\-]+$/u|max:90',
             '*.gender_mf' => 'required|in:M,F',
-            '*.date_of_birth_yyyy_mm_dd' => 'date|required|admission_age:' . $this->file['institution_class_id'],
+            '*.date_of_birth_yyyy_mm_dd' => 'date|required|admission_age:'.$this->file['institution_class_id'],
             '*.address' => 'nullable',
             '*.birth_registrar_office_as_in_birth_certificate' => 'nullable|exists:area_administratives,name|required_if:identity_type,BC|birth_place',
             '*.birth_divisional_secretariat' => 'nullable|exists:area_administratives,name|required_with:birth_registrar_office_as_in_birth_certificate',
@@ -479,8 +479,8 @@ 
             '*.academic_period' => 'required|exists:academic_periods,name',
             '*.education_grade' => 'required',
             '*.option_*' => 'nullable|exists:education_subjects,name',
-            '*.bmi_height' => 'bail|required_with:*.bmi_weight|bmi:' . $this->file['institution_class_id'],
-            '*.bmi_weight' => 'bail|required_with:*.bmi_height|bmi:' . $this->file['institution_class_id'],
+            '*.bmi_height' => 'bail|required_with:*.bmi_weight|bmi:'.$this->file['institution_class_id'],
+            '*.bmi_weight' => 'bail|required_with:*.bmi_height|bmi:'.$this->file['institution_class_id'],
             '*.bmi_date_yyyy_mm_dd' => 'bail|required_with:*.bmi_height|date', //bmi:'. $this->file['institution_class_id'].'
             '*.bmi_academic_period' => 'bail|required_with:*.bmi_height|exists:academic_periods,name',
             '*.admission_no' => 'required|max:12|min:4|regex:/^[A-Za-z0-9\/]+$/',

app/Console/Commands/CleanExamData.php

Spacing +25 added lines, -25 removed lines

@@ -48,24 +48,24 @@ 
     {
         $type = $this->argument('type');
         $students = array();
-        if($type == 'invalid'){
+        if ($type == 'invalid') {
             $students = DB::table('examination_students as es')
             ->whereRaw('CHAR_LENGTH(nsid) > 11')
             ->get()
             ->toArray();
-        }elseif($type == 'duplicate'){
+        }elseif ($type == 'duplicate') {
             $students = DB::table('security_users')
             ->where('updated_from', 'doe')
             ->get()
             ->toArray();
             
-        }elseif($type == 'all'){
+        }elseif ($type == 'all') {
             $students = DB::table('examination_students')
-            ->where('nsid','<>','')
+            ->where('nsid', '<>', '')
             ->whereNotNull('nsid')
             ->get()
             ->toArray();
-        }elseif($type == 'lock'){
+        }elseif ($type == 'lock') {
             $students = DB::table('examination_students')
             ->whereNotNull('nsid')
             ->get()
@@ -73,46 +73,46 @@ 
         }
 
         $this->output->writeln('###########################################------Start cleanning exam records------###########################################');    
-        if(count($students) > 0){
-            $this->output->writeln('Total students to clean: '.  count($students));
+        if (count($students) > 0) {
+            $this->output->writeln('Total students to clean: '.count($students));
             $students = array_chunk($students, $this->argument('chunk'));
             $function = array($this, 'process');
-            processParallel($function,$students, $this->argument('max'),$type);
-        }else{
+            processParallel($function, $students, $this->argument('max'), $type);
+        }else {
             $this->output->writeln('nothing to process, all are cleaned');
         }   
         $this->output->writeln('###########################################------Finished cleaning exam records------###########################################');
     }
 
-    public function process($students,$count,$type){
-       if($type === 'duplicate'){
-        array_walk($students,array($this,'cleanData'));
-       }elseif($type === 'lock'){
-        array_walk($students,array($this,'lockData'));
+    public function process($students, $count, $type) {
+       if ($type === 'duplicate') {
+        array_walk($students, array($this, 'cleanData'));
+       }elseif ($type === 'lock') {
+        array_walk($students, array($this, 'lockData'));
        }
     }
 
-    public function lockData($Student){
-        $Student = json_decode(json_encode($Student),true);
-        $student = Security_user::where('openemis_no',(string)$Student['nsid'])->first();
-        if(!empty($student)){
+    public function lockData($Student) {
+        $Student = json_decode(json_encode($Student), true);
+        $student = Security_user::where('openemis_no', (string) $Student['nsid'])->first();
+        if (!empty($student)) {
             Institution_student::where('student_id', $student->id)->update(['updated_from' => 'doe']);
             Security_user::where('id', $student->id)->update(['updated_from' => 'doe']);
-            $this->output->writeln('Locked:'. (string)$Student['nsid'] .':' . $student['openemis_no']);
+            $this->output->writeln('Locked:'.(string) $Student['nsid'].':'.$student['openemis_no']);
         }
     }
 
 
     public function cleanData($Student)
     {
-        $exist = Examination_student::where('nsid','=',  (string)$Student->openemis_no)->count();
+        $exist = Examination_student::where('nsid', '=', (string) $Student->openemis_no)->count();
         if (!$exist) {
             Institution_student::where('student_id', $Student->id)->delete();
             Institution_class_student::where('student_id', $Student->id)->delete();
             Institution_student_admission::where('student_id', $Student->id)->delete();
             Security_user::where('id', $Student->id)->delete();
-            $this->output->writeln('cleaned:'.  (string)$Student->openemis_no);
-        }else{
+            $this->output->writeln('cleaned:'.(string) $Student->openemis_no);
+        }else {
             
             Institution_student::where('student_id', $Student->id)->update(['updated_from' => 'doe']);
             Security_user::where('id', $Student->id)->update(['updated_from' => 'doe']);
@@ -132,12 +132,12 @@ 
     public function cleanInvalidData($Student)
     {
         $Student = (array) $Student;
-        $exist = Examination_student::where('nsid',$Student['nsid'])->count();
+        $exist = Examination_student::where('nsid', $Student['nsid'])->count();
         
         $this->uniqueUId = new UniqueUid();
 
-        $nsid = ltrim(rtrim($Student['nsid'],'-'),'-');
-        if(!$this->uniqueUId::isValidUniqueId('DBY-898-3J2')){
+        $nsid = ltrim(rtrim($Student['nsid'], '-'), '-');
+        if (!$this->uniqueUId::isValidUniqueId('DBY-898-3J2')) {
         }
     }
 }

app/Console/Commands/RemoveDuplications.php

Spacing +12 added lines, -12 removed lines

@@ -43,29 +43,29 @@
             $this->start_time = microtime(TRUE);
             $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
             $this->output->writeln('############### Starting delete Duplication ################');
-            $duplicatedStudents = Institution_student::select(DB::raw('count(*) as total'),'student_id','id','academic_period_id','education_grade_id')
+            $duplicatedStudents = Institution_student::select(DB::raw('count(*) as total'), 'student_id', 'id', 'academic_period_id', 'education_grade_id')
             ->groupBy('student_id')
-            ->having('total','>',1)
+            ->having('total', '>', 1)
             ->orderBy('student_id')
             ->get()
             ->toArray();
-            if(count($duplicatedStudents)>0){
-                processParallel(array($this,'process'),$duplicatedStudents,10);
-            }else{
+            if (count($duplicatedStudents) > 0) {
+                processParallel(array($this, 'process'), $duplicatedStudents, 10);
+            }else {
                 $this->output->writeln('Nothing to Process, all are clean');
             }
-        } catch (\Throwable $th) {
+        }catch (\Throwable $th) {
             dd($th);
         }
     }
   
-    public function process($Student){
-        Institution_student::where('institution_students.id','>',$Student['id'])
-        ->where('institution_students.student_id',$Student['student_id'])
-        ->where('institution_students.academic_period_id',$Student['academic_period_id'])
-        ->where('institution_students.education_grade_id',$Student['education_grade_id'])
+    public function process($Student) {
+        Institution_student::where('institution_students.id', '>', $Student['id'])
+        ->where('institution_students.student_id', $Student['student_id'])
+        ->where('institution_students.academic_period_id', $Student['academic_period_id'])
+        ->where('institution_students.education_grade_id', $Student['education_grade_id'])
         ->delete();
         $this->end_time = microtime(TRUE);    
-        $this->output->writeln('The cook took ' . ($this->end_time - $this->start_time) . ' seconds to complete');
+        $this->output->writeln('The cook took '.($this->end_time - $this->start_time).' seconds to complete');
     }
 }