ExaminationCheck::__construct() - Code Metrics - Inspection of "Fix duplciation os NSID on DOB same from DoE data" - moe-lk/bulk-upload - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#455)

by Mohamed

created 2020-09-01 13:09 UTC

ExaminationCheck::__construct() A

↳ Parent: ExaminationCheck

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	2
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	4
rs	10

<?php

namespace App\Console\Commands;

use Illuminate\Console\Command;
use Illuminate\Support\Facades\DB;
use App\Models\Examination_student;

class ExaminationCheck extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'examination:removedDuplicated';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'check duplications';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
        $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();

    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
       $students = DB::table('examination_students as es')
       ->select(DB::raw('count(*) as total'),'e2.*')
       ->join('examination_students as e2','es.nsid','e2.nsid')
       ->having('total','>',1)
       ->groupBy('e2.st_no')
       ->orderBy('e2.st_no')
        ->get();
        $this->output->writeln(count($students).'entries found');

        foreach($students as $student){
            Examination_student::where('st_no',$student->st_no)->update(['nsid'=>'']);
            $this->output->writeln($student->st_no.'removed');
        }
    }
}


1			<?php
2
3			namespace App\Console\Commands;
4
5			use Illuminate\Console\Command;
6			use Illuminate\Support\Facades\DB;
7			use App\Models\Examination_student;
8
9			class ExaminationCheck extends Command
10			{
11			/**
12			* The name and signature of the console command.
13			*
14			* @var string
15			*/
16			protected $signature = 'examination:removedDuplicated';
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'check duplications';
24
25			/**
26			* Create a new command instance.
27			*
28			* @return void
29			*/
30			public function __construct()
31			{
32			parent::__construct();
33			$this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
			0 ignored issues – show Documentation Bug introduced 2020-09-01 13:24 UTC by Report Bug Copy Issue Report It seems like `new Symfony\Component\Co...\Output\ConsoleOutput()` of type `Symfony\Component\Console\Output\ConsoleOutput` is incompatible with the declared type `Illuminate\Console\OutputStyle` of property `$output`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
34			}
35
36			/**
37			* Execute the console command.
38			*
39			* @return mixed
40			*/
41			public function handle()
42			{
43			$students = DB::table('examination_students as es')
44			->select(DB::raw('count() as total'),'e2.')
45			->join('examination_students as e2','es.nsid','e2.nsid')
46			->having('total','>',1)
47			->groupBy('e2.st_no')
48			->orderBy('e2.st_no')
49			->get();
50			$this->output->writeln(count($students).'entries found');
51
52			foreach($students as $student){
53			Examination_student::where('st_no',$student->st_no)->update(['nsid'=>'']);
54			$this->output->writeln($student->st_no.'removed');
55			}
56			}
57			}
58

moe-lk / bulk-upload

Pull Request — master (#455)

ExaminationCheck::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like