ExaminationCheck::deleteDuplication() - Code Metrics - Inspection of "disable nlast name chekc for twin mode" - moe-lk/bulk-upload - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#461)

by Mohamed

created 2020-09-02 06:05 UTC

ExaminationCheck::deleteDuplication() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	2

Metric	Value
cc	2
eloc	4
nc	2
nop	1
dl	0
loc	6
rs	10
c	2
b	0
f	2

<?php

namespace App\Console\Commands;

use Illuminate\Console\Command;
use Illuminate\Support\Facades\DB;
use App\Models\Examination_student;

class ExaminationCheck extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'examination:removedDuplicated {limit}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'check duplications';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
        $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();

    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $this->start_time = microtime(TRUE);

        $count = DB::table('examination_students')->select('nsid')->distinct()->count();

        $studentsIdsWithDuplication =   DB::table('examination_students as es')

        ->select(DB::raw('count(*) as total'),'es.*')
        ->whereNotNull('es.nsid')
        ->whereRaw('es.nsid != ""')
        ->having('total','>',1)
        ->groupBy('es.nsid')
        ->orderBy('es.nsid')
        ->chunk($this->argument('limit'),function($Students){
            foreach ($Students as $Student) {
                $count = Examination_student::where('nsid',$Student->nsid)->update(['nsid'=>'']);
                $this->output->writeln($Student->nsid .'same ID' . $count . ' records removed');
            }
        }); 
    }
}


1			<?php
2
3			namespace App\Console\Commands;
4
5			use Illuminate\Console\Command;
6			use Illuminate\Support\Facades\DB;
7			use App\Models\Examination_student;
8
9			class ExaminationCheck extends Command
10			{
11			/**
12			* The name and signature of the console command.
13			*
14			* @var string
15			*/
16			protected $signature = 'examination:removedDuplicated {limit}';
17
18			/**
19			* The console command description.
20			*
21			* @var string
22			*/
23			protected $description = 'check duplications';
24
25			/**
26			* Create a new command instance.
27			*
28			* @return void
29			*/
30			public function __construct()
31			{
32			parent::__construct();
33			$this->output = new \Symfony\Component\Console\Output\ConsoleOutput();
			0 ignored issues – show Documentation Bug introduced 2020-09-01 13:24 UTC by Report Bug Copy Issue Report It seems like `new Symfony\Component\Co...\Output\ConsoleOutput()` of type `Symfony\Component\Console\Output\ConsoleOutput` is incompatible with the declared type `Illuminate\Console\OutputStyle` of property `$output`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
34			}
35
36			/**
37			* Execute the console command.
38			*
39			* @return mixed
40			*/
41			public function handle()
42			{
43			$this->start_time = microtime(TRUE);
			0 ignored issues – show Bug Best Practice introduced 2020-09-01 18:29 UTC by Report Bug Copy Issue Report The property `start_time` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
44			$count = DB::table('examination_students')->select('nsid')->distinct()->count();
			0 ignored issues – show Unused Code introduced 2020-09-02 05:33 UTC by Report Bug Copy Issue Report The assignment to `$count` is dead and can be removed. Loading history...
45			$studentsIdsWithDuplication = DB::table('examination_students as es')
			0 ignored issues – show Unused Code introduced 2020-09-02 04:15 UTC by Report Bug Copy Issue Report The assignment to `$studentsIdsWithDuplication` is dead and can be removed. Loading history...
46			->select(DB::raw('count() as total'),'es.')
47			->whereNotNull('es.nsid')
48			->whereRaw('es.nsid != ""')
49			->having('total','>',1)
50			->groupBy('es.nsid')
51			->orderBy('es.nsid')
52			->chunk($this->argument('limit'),function($Students){
53			foreach ($Students as $Student) {
54			$count = Examination_student::where('nsid',$Student->nsid)->update(['nsid'=>'']);
55			$this->output->writeln($Student->nsid .'same ID' . $count . ' records removed');
56			}
57			});
58			}
59			}
60

moe-lk / bulk-upload

Pull Request — master (#461)

ExaminationCheck::deleteDuplication() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like