App\Http\Controllers\ImportExport::import()

Complexity

Conditions	3
Paths	3

Size

Total Lines	29
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function import(Request $request)
    {

            $request->validate([
                'import_file' => 'required',
                'class' => 'required'
            ]);

        ini_set('max_execution_time', 600);
        // (new UsersImport)->import(request()->file('file'), null, \Maatwebsite\Excel\Excel::XLSX);


            $import = new UsersImport();

The call to App\Imports\UsersImport::__construct() has too few arguments starting with file.

            try{
                $files = Storage::disk('sis-bulk-data-files')->allFiles();

The assignment to $files is dead and can be removed.

                Excel::import($import,request()->file('import_file'));

It seems like request()->file('import_file') can also be of type Illuminate\Http\UploadedFile[] and array; however, parameter $filePath of Maatwebsite\Excel\Facades\Excel::import() does only seem to accept string, maybe add an additional type check?

            }catch (\Maatwebsite\Excel\Validators\ValidationException $e) {
                $failures = $e->failures();

                foreach ($failures as $failure) {
                    $failure->row(); // row that went wrong
                    $failure->attribute(); // either heading key (if using heading row concern) or column index
                    $failure->errors(); // Actual error messages from Laravel validator
                    $failure->values(); // The values of the row that has failed.
                }
            }

           
        return back();

The expression return back() returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Support\Collection.

    }