App\Mail\StudentImportSuccess

Complexity

Total Complexity

2

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	build()	0	7	1
A	__construct()	0	16	1

<?php

namespace App\Mail;

use App\Models\User;
use App\Models\Institution_class;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Mail\Mailer as MailerContract;
use Illuminate\Mail\Mailable;
use Illuminate\Queue\SerializesModels;

class StudentImportSuccess extends Mailable
{
    use Queueable, SerializesModels;

The trait Illuminate\Queue\SerializesModels requires some properties which are not provided by App\Mail\StudentImportSuccess: $id, $relations, $class, $keyBy

    /**
     * Create a new message instance.
     *
     * @return void
     */
    public function __construct($file)
    {

        $institution = Institution_class::find($file['institution_class_id']);

        $this->user = User::find($file['security_user_id']);

The property user does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->subject = 'SIS Bulk upload: '. $file['subject'] .$institution->institution->code.': '. $institution->name.' ' . date('Y:m:d H:i:s');

The property name does not seem to exist on App\Models\Institution_class. Are you sure there is no database migration missing?

The property code does not seem to exist on App\Models\Institution. Are you sure there is no database migration missing?

        $this->from_address = env('MAIL_FROM_ADDRESS');

The property from_address does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->from_name = 'SIS Bulk Uploader';

The property from_name does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->with = [

The property with does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            'name' => $this->user->first_name,
            'link' =>  env('APP_URL').'/create/'
        ];
        $this->viewData = [
            'name'=>$this->user->first_name, "body" => "Student upload success, you can access the data from open email UI and dashboard",
            'link' =>  env('APP_URL').'/create/'
        ];
    }

    /**
     * Build the message.
     *
     * @return $this
     */
    public function build()
    {
        return $this->view('emails.mail')
             ->from($this->from_address,$this->from_name)
             ->to($this->user->email)

The property email does not seem to exist on App\Models\User. Are you sure there is no database migration missing?

            ->subject($this->subject)
            ->with($this->with);
    }

}