App\Http\Controllers\FileController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	143
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	downloadFile()	0	12	2
A	updateQueueWithUnprocessedFiles()	0	9	3
A	downloadErrorFile()	0	12	2
A	__construct()	0	7	1
A	upload()	0	59	2
A	downloadTemplate()	0	13	2

<?php

namespace App\Http\Controllers;

use App\Models\Upload;
use Aws\Ses\SesClient;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Response;
use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Facades\Validator;
use App\Models\Institution_class;


class FileController extends Controller
{


    public function __construct()
    {
        $this->middleware('auth');
        $this->ses = new SesClient(

The property ses does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            [
                'version' => '2010-12-01',
                'region' => 'us-east-2',

            ]
        );
    }

    /**
     * @param Request $request
     * @return \Illuminate\Http\JsonResponse
     */
    public function upload(Request $request){



        $validator = Validator::make(
            [
                'import_file'      => $request->import_file,
                'extension' => strtolower($request->import_file->getClientOriginalExtension()),
                'class' => $request->class,
                'email' => auth()->user()->email
            ],
            [
                'import_file'          => 'required',
                'extension'      => 'required|in:xlsx,xls,ods|max:2048',
                'class' => 'required',
                'email' => 'required'

            ],
            ['email.required' => 'You dont have email  in your account, pleas contact your Zonal/Provincial Coordinator and update the email to get notification']
        );
//        try {
//            $result = $this->ses->verifyEmailIdentity([
//                'EmailAddress' => auth()->user()->email,
//            ]);
//            var_dump($result);
//        } catch (AwsException $e) {
//            // output error message if fails
//            echo $e->getMessage();
//            echo "\n";
//        }
//        if ($validator->fails()) {
//            return back()
//                ->withErrors($validator);
//        }


        $uploadFile = $validator->validated()['import_file'];
        $class = Institution_class::find($validator->validated()['class']);
//        dd(auth()->user()->principal[0]->institution_group[0]->institution);
        $institution = auth()->user()->permissions->isEmpty() ? auth()->user()->principal[0]->institution_group[0]->institution->code : auth()->user()->permissions[0]->institution_staff->institution->code;


        $fileName = time().'_'.$institution.'_'.str_replace(' ','_', clean($class->name)).'_'.auth()->user()->openemis_no.'_student_bulk_data.xlsx';

The property name does not seem to exist on App\Models\Institution_class. Are you sure there is no database migration missing?

        Storage::disk('local')->putFileAs(
            'sis-bulk-data-files/',
            $uploadFile,
            $fileName
        );

        $upload = new Upload;
        $upload->fileName =$fileName;

The property fileName does not exist on App\Models\Upload. Did you mean filename?

        $upload->model = 'Student';
        $upload->node = 'None';
        $upload->institution_class_id = $class->id;
        $upload->user()->associate(auth()->user());
        $upload->save();


        return redirect('/')->withSuccess('The file is uploaded, we will process and let you know by your email');

The expression return redirect('/')->withSuccess('The file is uploaded, we will process and let you know by your email') also could return the type Illuminate\Http\RedirectResponse|Illuminate\Routing\Redirector which is incompatible with the documented return type Illuminate\Http\JsonResponse.

    }

    public function updateQueueWithUnprocessedFiles($id, $action){
        if($action == 100){
            DB::table('uploads')
                ->where('id', $id)
                ->update(['is_processed' => 0]);
        }elseif ($action == 200) {
            DB::table('uploads')
                ->where('id', $id)
                ->update(['is_processed' => 4]);
        }
    }


    public function downloadTemplate(){
        $filename = 'censusNo_className_sis_students_bulk_upload';
        $version = '2007_V2.0.2_20201211.xlsx';
        $file_path = storage_path() .'/app/public/'. $filename.'_'.$version;;
        if (file_exists($file_path))
        {
            return Response::download($file_path, Auth::user()->openemis_no.'_'.$filename.$version, [

Accessing openemis_no on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                'Content-Length: '. filesize($file_path)
            ]);
        }
        else
        {
            return response()->view('errors.404');
        }
    }


    /**
     * @param $filename
     * @return Processed excel file with error

The type App\Http\Controllers\Processed was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function downloadErrorFile($filename){

        $file_path = storage_path().'/app/sis-bulk-data-files/processed/'. $filename;
        if (file_exists($file_path))
        {
            return Response::download($file_path, $filename, [

The expression return Illuminate\Support\Facades\Response::download($file_path, $filename, array('Content-Length: ' . filesize($file_path))) returns the type Symfony\Component\HttpFoundation\BinaryFileResponse which is incompatible with the documented return type App\Http\Controllers\Processed.

                'Content-Length: '. filesize($file_path)
            ]);
        }
        else
        {
            abort(404, 'We did not found an error file.');
        }
    }


    public function downloadFile($filename){
        $file_path = storage_path().'/app/sis-bulk-data-files/'. $filename;
        if (file_exists($file_path))
        {
            return Response::download($file_path, $filename, [
                'Content-Length: '. filesize($file_path)
            ]);
        }
        else
        {

            abort(404, 'We did not found an error file.');
        }
    }
}