App\Console\Commands\cleanConfig

Complexity

Total Complexity

4

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	17	3
A	__construct()	0	7	1

<?php

namespace App\Console\Commands;

use App\Models\Academic_period;
use Illuminate\Console\Command;
use App\Models\Institution_shift;
use App\Http\Controllers\CloneController;

class cleanConfig extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'clean:clone {year}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Command description';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
        $this->shifts = new Institution_shift();

The property shifts does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->academic_period = new Academic_period();

The property academic_period does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->clone = new CloneController();

The property clone does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->output = new \Symfony\Component\Console\Output\ConsoleOutput();

It seems like new Symfony\Component\Console\Output\ConsoleOutput() of type Symfony\Component\Console\Output\ConsoleOutput is incompatible with the declared type Illuminate\Console\OutputStyle of property $output.

    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $this->start_time = microtime(TRUE);

The property start_time does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $year = $this->argument('year');
        $academicPeriod = $this->academic_period->getAcademicPeriod($year);
        $previousAcademicPeriodYear = $academicPeriod->order;

The property order does not seem to exist on App\Models\Academic_period. Are you sure there is no database migration missing?

        $previousAcademicPeriod = Academic_period::where('order',$previousAcademicPeriodYear+1)->first();

        $params = [
            'academic_period' => $academicPeriod,
            'previous_academic_period' => $previousAcademicPeriod
        ];

        if($year == '2019' || $year == '2018/19'){
            die('Academic Year 2019 or earlier can`t be deleted');

Using exit here is not recommended.

        }else{
            $this->clone->cleanConfig($params);
        }
    }
}