App\Console\Commands\CallPromotionCommand

Complexity

Total Complexity

4

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	handle()	0	18	2
A	callPromotion()	0	2	1

<?php

namespace App\Console\Commands;

use App\Models\Academic_period;
use Illuminate\Console\Command;
use App\Models\Institution_grade;
use Illuminate\Support\Facades\DB;

class CallPromotionCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'promote:run {year} {mode} {limit}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Command description';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
        $this->instituion_grade = new Institution_grade();

The property instituion_grade does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->academic_period = new Academic_period();

The property academic_period does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        DB::statement("SET SESSION sql_mode=(SELECT REPLACE(@@sql_mode,'ONLY_FULL_GROUP_BY',''));");
        $year = $this->argument('year');
        $limit = $this->argument('limit');
        $mode = $this->argument('mode');
        $academicPeriod = $this->academic_period->getAcademicPeriod($year);
        $previousAcademicPeriodYear = $academicPeriod->order;

The property order does not seem to exist on App\Models\Academic_period. Are you sure there is no database migration missing?

        $previousAcademicPeriod = Academic_period::where('order',$previousAcademicPeriodYear+1)->first();
        $institutions = $this->instituion_grade->getInstitutionGradeList($previousAcademicPeriod->code,$limit,$mode);

The property code does not seem to exist on App\Models\Academic_period. Are you sure there is no database migration missing?

        $params = [
            'year' => $year,
            'mode'=> $mode
        ];
        if(in_array($mode,['AL','1-5','SP','6-11'])){
            array_walk($institutions,array($this,'callPromotion'),$params);
        }else{
            die('The give mode not support');

Using exit here is not recommended.

        }
       
    }

    protected function callPromotion($institution,$count,$params){
        $this->call('promote:students',['year' => $params['year'],'institution' => $institution['code'],'mode' => $params['mode'] ]);
    }
}