modularsoftware / php-gedcom

library/PhpGedcom/Writer/Repo.php

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Xiang Ming <wenqiangliu344@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Xiang Ming
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace PhpGedcom\Writer;

class Repo
{
    /**
     * @param \PhpGedcom\Record\Repo $sour
     * @param int                    $level
     *
     * @return string
     */
    public static function convert(\PhpGedcom\Record\Repo &$repo)
    {
        $level = 0;
        $output = '';
        $_repo = $repo->getRepo();
        if ($_repo) {
            $output .= $level.' '.$_repo." REPO\n";
        } else {
            return $output;
        }

        // level up
        $level++;

        //NAME
        $name = $repo->getName();
        if ($name) {
            $output .= $level.' NAME '.$name."\n";
        }

        // ADDR
        $addr = $repo->getAddr();
        if ($addr) {

$addr is of type PhpGedcom\Record\Addr, thus it always evaluated to true.

            $_convert = \PhpGedcom\Writer\Addr::convert($addr, $level);
            $output .= $_convert;
        }

        // PHON
        $phon = $repo->getPhon();
        if ($phon) {

The expression $phon of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $_convert = \PhpGedcom\Writer\Phon::convert($phon, $level);

$phon of type array is incompatible with the type string expected by parameter $phon of PhpGedcom\Writer\Phon::convert().

            $output .= $_convert;
        }

        // NOTE array
        $note = $repo->getNote();
        if ($note && count($note) > 0) {

The expression $note of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($note as $item) {
                if ($item) {
                    $_convert = \PhpGedcom\Writer\NoteRef::convert($item, $level);
                    $output .= $_convert;
                }
            }
        }

        // REFN
        $refn = $repo->getRefn();
        if (!empty($refn) && count($refn) > 0) {
            foreach ($refn as $item) {
                if ($item) {
                    $_convert = \PhpGedcom\Writer\Refn::convert($item, $level);
                    $output .= $_convert;
                }
            }
        }

        // CHAN
        $chan = $repo->getChan();
        if ($chan) {

$chan is of type PhpGedcom\Record\Chan, thus it always evaluated to true.

            $_convert = \PhpGedcom\Writer\Chan::convert($chan, $level);
            $output .= $_convert;
        }

        // RIN
        $rin = $repo->getRin();
        if ($rin) {
            $output .= $level.' RIN '.$rin."\n";
        }

        return $output;
    }
}