Indi::addDesi() - Code Metrics - Inspection of "Status badge for StyleCI" - modularsoftware/php-gedcom - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (6a7148)

by Curtis

created 2020-09-08 00:28 UTC

Indi::addDesi() A

↳ Parent: Indi

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php
/**
 * php-gedcom
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Kristopher Wilson <[email protected]>
 * @copyright       Copyright (c) 2010-2013, Kristopher Wilson
 * @package         php-gedcom
 * @license         MIT
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace PhpGedcom\Record;

use PhpGedcom\Record;
use PhpGedcom\Record\NoteRef;
use PhpGedcom\Record\ObjeRef;
use PhpGedcom\Record\Refn;
use PhpGedcom\Record\SourRef;

/**
 * Class Indi
 * @package PhpGedcom\Record
 */
class Indi extends Record implements Noteable, Objectable, Sourceable {
	/**
	 * @var string
	 */
	protected $id;

	/**
	 * @var string
	 */
	protected $uid;

	/**
	 * @var string
	 */
	protected $resn;
	/**
	 * @var Indi\Name[]
	 */
	protected $name = array();
	/**
	 * @var string
	 */
	protected $sex;

	/**
	 * @var Indi\Even[]
	 */
	protected $even = array();
	/**
	 * @var Indi\Attr[]
	 */
	protected $attr = array();
	/**
	 * @var Indi\Bapl
	 */
	protected $bapl = array();

	/**
	 * @var Indi\Conl
	 */
	protected $conl = array();

	/**
	 * @var Indi\Endl
	 */
	protected $endl = array();

	/**
	 * @var Indi\Slgc
	 */
	protected $slgc = array();

	/**
	 * @var Indi\Famc[]
	 */
	protected $famc = array();
	/**
	 * @var Indi\Fams[]
	 */
	protected $fams = array();
	/**
	 * @var string[]
	 */
	protected $subm = array();
	/**
	 * @var string[]
	 */
	protected $alia = array();
	/**
	 * @var string[]
	 */
	protected $anci = array();
	/**
	 * @var string[]
	 */
	protected $desi = array();
	/**
	 * @var string
	 */
	protected $rfn;	
	/**
	 * @var string
	 */
	protected $afn;
	/**
	 * @var Refn[]
	 */
	protected $refn = array();
	/**
	 * @var string
	 */
	protected $rin;

	/**
	 * @var string
	 */
	protected $chan;


	/**
	 * @var Indi\Note[]
	 */
	protected $note = array();

	/**
	 * @var Obje[]
	 */
	protected $obje = array();

	/**
	 * @var Sour[]
	 */
	protected $sour = array();


	/**
	 * @var Indi\Asso[]
	 */
	protected $asso = array();



	/**
	 * @param string $id
	 * @return Indi
	 */
	public function setId($id = '') {
		$this->id = $id;
		return $this;
	}

	/**
	 * @return string
	 */
	public function getId() {
		return $this->id;
	}

	/**
	 * @param string $uid
	 * @return Indi
	 */
	public function setUid($uid = '') {
		$this->uid = $uid;
		return $this;
	}

	/**
	 * @return string
	 */
	public function getUid() {
		return $this->uid;
	}

	/**
	 * @param Indi\Name $name
	 * @return Indi
	 */
	public function addName($name = []) {
		$this->name[] = $name;
		return $this;
	}

	/**
	 * @return Indi\Name[]
	 */
	public function getName() {
		return $this->name;
	}

	/**
	 * @param Indi\Attr $attr
	 * @return Indi
	 */
	public function addAttr($attr = []) {
		$attrName = $attr->getType();

		if (!array_key_exists($attrName, $this->attr)) {
			$this->attr[$attrName] = [];
		}

		$this->attr[$attrName][] = $attr;
		return $this;
	}

	/**
	 * @return Indi\Attr[]
	 */
	public function getAllAttr() {
		return $this->attr;
	}
	/**
	 * @return Indi\Attr[]
	 */
	public function getAttr($key = '') {
		if (isset($this->attr[strtoupper($key)])) {
			return $this->attr[strtoupper($key)];

		}

	}
	/**
	 * @param Indi\Even $even
	 * @return Indi
	 */
	public function addEven($even = []) {
		$evenName = $even->getType();

		if (!array_key_exists($evenName, $this->even)) {
			$this->even[$evenName] = [];
		}

		$this->even[$evenName][] = $even;
		return $this;
	}

	/**
	 * @return array
	 */
	public function getAllEven() {
		return $this->even;
	}

	/**
	 * @return array
	 */
	public function getEven($key = '') {
		if (isset($this->even[strtoupper($key)])) {
			return $this->even[strtoupper($key)];

		}

	}

	/**
	 * @param Indi\Asso $asso
	 * @return Indi
	 */
	public function addAsso($asso = []) {
		$this->asso[] = $asso;
		return $this;
	}

	/**
	 * @return array
	 */
	public function getAsso() {
		return $this->asso;
	}

	/**
	 * @param Refn $ref
	 * @return Indi
	 */
	public function addRefn($ref = []) {
		$this->refn[] = $ref;
		return $this;
	}

	/**
	 * @return Refn[]
	 */
	public function getRefn() {
		return $this->refn;
	}

	/**
	 * @param \PhpGedcom\Record\NoteRef $note
	 * @return Indi
	 */
	public function addNote($note = []) {
		$this->note[] = $note;
		return $this;
	}

	/**
	 * @return array
	 */
	public function getNote() {
		return $this->note;
	}

	/**
	 * @param ObjeRef $obje
	 * @return Indi
	 */
	public function addObje($obje = []) {
		$this->obje[] = $obje;
		return $this;
	}

	/**
	 * @return array
	 */
	public function getObje() {
		return $this->obje;
	}

	/**
	 * @param SourRef $sour
	 * @return Indi
	 */
	public function addSour($sour = []) {
		$this->sour[] = $sour;
		return $this;
	}

	/**
	 * @return array
	 */
	public function getSour() {
		return $this->sour;
	}

	/**
	 * @param string $indi
	 * @return Indi
	 */
	public function addAlia($indi = '') {
		$this->alia[] = $indi;
		return $this;
	}

	/**
	 * @return array
	 */
	public function getAlia() {
		return $this->alia;
	}

	/**
	 * @param Indi\Famc $famc
	 * @return Indi
	 */
	public function addFamc($famc = []) {
		$this->famc[] = $famc;
		return $this;
	}

	/**
	 * @return array
	 */
	public function getFamc() {
		return $this->famc;
	}

	/**
	 * @param Indi\Fams $fams
	 * @return Indi
	 */
	public function addFams($fams = []) {
		$this->fams[] = $fams;
		return $this;
	}

	/**
	 * @return array
	 */
	public function getFams() {
		return $this->fams;
	}

	/**
	 * @param string $subm
	 * @return Indi
	 */
	public function addAnci($subm = '') {
		$this->anci[] = $subm;
		return $this;
	}

	/**
	 * @return string[]
	 */
	public function getAnci() {
		return $this->anci;
	}

	/**
	 * @param string $subm
	 * @return Indi
	 */
	public function addDesi($subm = '') {
		$this->desi[] = $subm;
		return $this;
	}

	/**
	 * @return string[]
	 */
	public function getDesi() {
		return $this->desi;
	}

	/**
	 * @param string $subm
	 * @return Indi
	 */
	public function addSubm($subm = '') {
		$this->subm[] = $subm;
		return $this;
	}

	/**
	 * @return string[]
	 */
	public function getSubm() {
		return $this->subm;
	}

	/**
	 * @param string $resn
	 * @return Indi
	 */
	public function setResn($resn = '') {
		$this->resn = $resn;
		return $this;
	}

	/**
	 * @return string
	 */
	public function getResn() {
		return $this->resn;
	}

	/**
	 * @param string $sex
	 * @return Indi
	 */
	public function setSex($sex = '') {
		$this->sex = $sex;
		return $this;
	}

	/**
	 * @return string
	 */
	public function getSex() {
		return $this->sex;
	}

	/**
	 * @param string $rfn
	 * @return Indi
	 */
	public function setRfn($rfn = '') {
		$this->rfn = $rfn;
		return $this;
	}

	/**
	 * @return string
	 */
	public function getRfn() {
		return $this->rfn;
	}

	/**
	 * @param string $afn
	 * @return Indi
	 */
	public function setAfn($afn = '') {
		$this->afn = $afn;
		return $this;
	}

	/**
	 * @return string
	 */
	public function getAfn() {
		return $this->afn;
	}

	/**
	 * @param string $chan
	 * @return Indi
	 */
	public function setChan($chan = null) {
		$this->chan = $chan;
		return $this;
	}

	/**
	 * @return string
	 */
	public function getChan() {
		return $this->chan;
	}

	/**
	 * @param string $rin
	 * @return Indi
	 */
	public function setRin($rin = '') {
		$this->rin = $rin;
		return $this;
	}

	/**
	 * @return string
	 */
	public function getRin() {
		return $this->rin;
	}

	/**
	 * @param Indi\Bapl $bapl
	 * @return Indi
	 */
	public function setBapl($bapl = []) {
		$this->bapl = $bapl;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
		return $this;
	}
	/**
	 * @param Indi\Bapl $bapl
	 * @return Indi
	 */
	public function addBapl($bapl = null) {
		$this->bapl[] = $bapl;
		return $this;
	}
	/**
	 * @return Indi\Bapl
	 */
	public function getBapl() {
		return $this->bapl;
	}

	/**
	 * @param Indi\Conl $conl
	 * @return Indi
	 */
	public function setConl($conl = []) {
		$this->conl = $conl;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
		return $this;
	}
	/**
	 * @param Indi\Conl $conl
	 * @return Indi
	 */
	public function addConl($conl) {
		$this->conl[] = $conl;
		return $this;
	}

	/**
	 * @return Indi\Conl
	 */
	public function getConl() {
		return $this->conl;
	}

	/**
	 * @param Indi\Endl $endl
	 * @return Indi
	 */
	public function setEndl($endl = []) {
		$this->endl = $endl;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
		return $this;
	}
	/**
	 * @param Indi\Endl $endl
	 * @return Indi
	 */
	public function addEndl($endl) {
		$this->endl[] = $endl;
		return $this;
	}

	/**
	 * @return Indi\Endl
	 */
	public function getEndl() {
		return $this->endl;
	}

	/**
	 * @param Indi\Slgc $slgc
	 * @return Indi
	 */
	public function setSlgc($slgc = []) {
		$this->slgc = $slgc;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
		return $this;
	}

	/**
	 * @param Indi\Slgc $slgc
	 * @return Indi
	 */
	public function addSlgc($slgc) {
		$this->slgc[] = $slgc;
		return $this;
	}

	/**
	 * @return Indi\Slgc
	 */
	public function getSlgc() {
		return $this->slgc;
	}
}


1			<?php
2			/**
3			* php-gedcom
4			*
5			* php-gedcom is a library for parsing, manipulating, importing and exporting
6			* GEDCOM 5.5 files in PHP 5.3+.
7			*
8			* @author Kristopher Wilson <[email protected]>
9			* @copyright Copyright (c) 2010-2013, Kristopher Wilson
10			* @package php-gedcom
11			* @license MIT
12			* @link http://github.com/mrkrstphr/php-gedcom
13			*/
14
15			namespace PhpGedcom\Record;
16
17			use PhpGedcom\Record;
18			use PhpGedcom\Record\NoteRef;
19			use PhpGedcom\Record\ObjeRef;
20			use PhpGedcom\Record\Refn;
21			use PhpGedcom\Record\SourRef;
22
23			/**
24			* Class Indi
25			* @package PhpGedcom\Record
26			*/
27			class Indi extends Record implements Noteable, Objectable, Sourceable {
28			/**
29			* @var string
30			*/
31			protected $id;
32
33			/**
34			* @var string
35			*/
36			protected $uid;
37
38			/**
39			* @var string
40			*/
41			protected $resn;
42			/**
43			* @var Indi\Name[]
44			*/
45			protected $name = array();
46			/**
47			* @var string
48			*/
49			protected $sex;
50
51			/**
52			* @var Indi\Even[]
53			*/
54			protected $even = array();
55			/**
56			* @var Indi\Attr[]
57			*/
58			protected $attr = array();
59			/**
60			* @var Indi\Bapl
61			*/
62			protected $bapl = array();
63
64			/**
65			* @var Indi\Conl
66			*/
67			protected $conl = array();
68
69			/**
70			* @var Indi\Endl
71			*/
72			protected $endl = array();
73
74			/**
75			* @var Indi\Slgc
76			*/
77			protected $slgc = array();
78
79			/**
80			* @var Indi\Famc[]
81			*/
82			protected $famc = array();
83			/**
84			* @var Indi\Fams[]
85			*/
86			protected $fams = array();
87			/**
88			* @var string[]
89			*/
90			protected $subm = array();
91			/**
92			* @var string[]
93			*/
94			protected $alia = array();
95			/**
96			* @var string[]
97			*/
98			protected $anci = array();
99			/**
100			* @var string[]
101			*/
102			protected $desi = array();
103			/**
104			* @var string
105			*/
106			protected $rfn;
107			/**
108			* @var string
109			*/
110			protected $afn;
111			/**
112			* @var Refn[]
113			*/
114			protected $refn = array();
115			/**
116			* @var string
117			*/
118			protected $rin;
119
120			/**
121			* @var string
122			*/
123			protected $chan;
124
125
126			/**
127			* @var Indi\Note[]
128			*/
129			protected $note = array();
130
131			/**
132			* @var Obje[]
133			*/
134			protected $obje = array();
135
136			/**
137			* @var Sour[]
138			*/
139			protected $sour = array();
140
141
142			/**
143			* @var Indi\Asso[]
144			*/
145			protected $asso = array();
146
147
148
149			/**
150			* @param string $id
151			* @return Indi
152			*/
153			public function setId($id = '') {
154			$this->id = $id;
155			return $this;
156			}
157
158			/**
159			* @return string
160			*/
161			public function getId() {
162			return $this->id;
163			}
164
165			/**
166			* @param string $uid
167			* @return Indi
168			*/
169			public function setUid($uid = '') {
170			$this->uid = $uid;
171			return $this;
172			}
173
174			/**
175			* @return string
176			*/
177			public function getUid() {
178			return $this->uid;
179			}
180
181			/**
182			* @param Indi\Name $name
183			* @return Indi
184			*/
185			public function addName($name = []) {
186			$this->name[] = $name;
187			return $this;
188			}
189
190			/**
191			* @return Indi\Name[]
192			*/
193			public function getName() {
194			return $this->name;
195			}
196
197			/**
198			* @param Indi\Attr $attr
199			* @return Indi
200			*/
201			public function addAttr($attr = []) {
202			$attrName = $attr->getType();
203
204			if (!array_key_exists($attrName, $this->attr)) {
205			$this->attr[$attrName] = [];
206			}
207
208			$this->attr[$attrName][] = $attr;
209			return $this;
210			}
211
212			/**
213			* @return Indi\Attr[]
214			*/
215			public function getAllAttr() {
216			return $this->attr;
217			}
218			/**
219			* @return Indi\Attr[]
220			*/
221			public function getAttr($key = '') {
222			if (isset($this->attr[strtoupper($key)])) {
223			return $this->attr[strtoupper($key)];
			0 ignored issues – show Bug Best Practice introduced 2020-09-08 00:30 UTC by Report Bug Copy Issue Report The expression `return $this->attr[strtoupper($key)]` returns the type `PhpGedcom\Record\Indi\Attr` which is incompatible with the documented return type `PhpGedcom\Record\Indi\Attr[]`. Loading history...
224			}
225
226			}
227			/**
228			* @param Indi\Even $even
229			* @return Indi
230			*/
231			public function addEven($even = []) {
232			$evenName = $even->getType();
233
234			if (!array_key_exists($evenName, $this->even)) {
235			$this->even[$evenName] = [];
236			}
237
238			$this->even[$evenName][] = $even;
239			return $this;
240			}
241
242			/**
243			* @return array
244			*/
245			public function getAllEven() {
246			return $this->even;
247			}
248
249			/**
250			* @return array
251			*/
252			public function getEven($key = '') {
253			if (isset($this->even[strtoupper($key)])) {
254			return $this->even[strtoupper($key)];
			0 ignored issues – show Bug Best Practice introduced 2020-09-08 00:30 UTC by Report Bug Copy Issue Report The expression `return $this->even[strtoupper($key)]` returns the type `PhpGedcom\Record\Indi\Even` which is incompatible with the documented return type `array`. Loading history...
255			}
256
257			}
258
259			/**
260			* @param Indi\Asso $asso
261			* @return Indi
262			*/
263			public function addAsso($asso = []) {
264			$this->asso[] = $asso;
265			return $this;
266			}
267
268			/**
269			* @return array
270			*/
271			public function getAsso() {
272			return $this->asso;
273			}
274
275			/**
276			* @param Refn $ref
277			* @return Indi
278			*/
279			public function addRefn($ref = []) {
280			$this->refn[] = $ref;
281			return $this;
282			}
283
284			/**
285			* @return Refn[]
286			*/
287			public function getRefn() {
288			return $this->refn;
289			}
290
291			/**
292			* @param \PhpGedcom\Record\NoteRef $note
293			* @return Indi
294			*/
295			public function addNote($note = []) {
296			$this->note[] = $note;
297			return $this;
298			}
299
300			/**
301			* @return array
302			*/
303			public function getNote() {
304			return $this->note;
305			}
306
307			/**
308			* @param ObjeRef $obje
309			* @return Indi
310			*/
311			public function addObje($obje = []) {
312			$this->obje[] = $obje;
313			return $this;
314			}
315
316			/**
317			* @return array
318			*/
319			public function getObje() {
320			return $this->obje;
321			}
322
323			/**
324			* @param SourRef $sour
325			* @return Indi
326			*/
327			public function addSour($sour = []) {
328			$this->sour[] = $sour;
329			return $this;
330			}
331
332			/**
333			* @return array
334			*/
335			public function getSour() {
336			return $this->sour;
337			}
338
339			/**
340			* @param string $indi
341			* @return Indi
342			*/
343			public function addAlia($indi = '') {
344			$this->alia[] = $indi;
345			return $this;
346			}
347
348			/**
349			* @return array
350			*/
351			public function getAlia() {
352			return $this->alia;
353			}
354
355			/**
356			* @param Indi\Famc $famc
357			* @return Indi
358			*/
359			public function addFamc($famc = []) {
360			$this->famc[] = $famc;
361			return $this;
362			}
363
364			/**
365			* @return array
366			*/
367			public function getFamc() {
368			return $this->famc;
369			}
370
371			/**
372			* @param Indi\Fams $fams
373			* @return Indi
374			*/
375			public function addFams($fams = []) {
376			$this->fams[] = $fams;
377			return $this;
378			}
379
380			/**
381			* @return array
382			*/
383			public function getFams() {
384			return $this->fams;
385			}
386
387			/**
388			* @param string $subm
389			* @return Indi
390			*/
391			public function addAnci($subm = '') {
392			$this->anci[] = $subm;
393			return $this;
394			}
395
396			/**
397			* @return string[]
398			*/
399			public function getAnci() {
400			return $this->anci;
401			}
402
403			/**
404			* @param string $subm
405			* @return Indi
406			*/
407			public function addDesi($subm = '') {
408			$this->desi[] = $subm;
409			return $this;
410			}
411
412			/**
413			* @return string[]
414			*/
415			public function getDesi() {
416			return $this->desi;
417			}
418
419			/**
420			* @param string $subm
421			* @return Indi
422			*/
423			public function addSubm($subm = '') {
424			$this->subm[] = $subm;
425			return $this;
426			}
427
428			/**
429			* @return string[]
430			*/
431			public function getSubm() {
432			return $this->subm;
433			}
434
435			/**
436			* @param string $resn
437			* @return Indi
438			*/
439			public function setResn($resn = '') {
440			$this->resn = $resn;
441			return $this;
442			}
443
444			/**
445			* @return string
446			*/
447			public function getResn() {
448			return $this->resn;
449			}
450
451			/**
452			* @param string $sex
453			* @return Indi
454			*/
455			public function setSex($sex = '') {
456			$this->sex = $sex;
457			return $this;
458			}
459
460			/**
461			* @return string
462			*/
463			public function getSex() {
464			return $this->sex;
465			}
466
467			/**
468			* @param string $rfn
469			* @return Indi
470			*/
471			public function setRfn($rfn = '') {
472			$this->rfn = $rfn;
473			return $this;
474			}
475
476			/**
477			* @return string
478			*/
479			public function getRfn() {
480			return $this->rfn;
481			}
482
483			/**
484			* @param string $afn
485			* @return Indi
486			*/
487			public function setAfn($afn = '') {
488			$this->afn = $afn;
489			return $this;
490			}
491
492			/**
493			* @return string
494			*/
495			public function getAfn() {
496			return $this->afn;
497			}
498
499			/**
500			* @param string $chan
501			* @return Indi
502			*/
503			public function setChan($chan = null) {
504			$this->chan = $chan;
505			return $this;
506			}
507
508			/**
509			* @return string
510			*/
511			public function getChan() {
512			return $this->chan;
513			}
514
515			/**
516			* @param string $rin
517			* @return Indi
518			*/
519			public function setRin($rin = '') {
520			$this->rin = $rin;
521			return $this;
522			}
523
524			/**
525			* @return string
526			*/
527			public function getRin() {
528			return $this->rin;
529			}
530
531			/**
532			* @param Indi\Bapl $bapl
533			* @return Indi
534			*/
535			public function setBapl($bapl = []) {
536			$this->bapl = $bapl;
			0 ignored issues – show Documentation Bug introduced 2020-09-08 00:30 UTC by Report Bug Copy Issue Report It seems like `$bapl` can also be of type `array`. However, the property `$bapl` is declared as type `PhpGedcom\Record\Indi\Bapl`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
537			return $this;
538			}
539			/**
540			* @param Indi\Bapl $bapl
541			* @return Indi
542			*/
543			public function addBapl($bapl = null) {
544			$this->bapl[] = $bapl;
545			return $this;
546			}
547			/**
548			* @return Indi\Bapl
549			*/
550			public function getBapl() {
551			return $this->bapl;
552			}
553
554			/**
555			* @param Indi\Conl $conl
556			* @return Indi
557			*/
558			public function setConl($conl = []) {
559			$this->conl = $conl;
			0 ignored issues – show Documentation Bug introduced 2020-09-08 00:30 UTC by Report Bug Copy Issue Report It seems like `$conl` can also be of type `array`. However, the property `$conl` is declared as type `PhpGedcom\Record\Indi\Conl`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
560			return $this;
561			}
562			/**
563			* @param Indi\Conl $conl
564			* @return Indi
565			*/
566			public function addConl($conl) {
567			$this->conl[] = $conl;
568			return $this;
569			}
570
571			/**
572			* @return Indi\Conl
573			*/
574			public function getConl() {
575			return $this->conl;
576			}
577
578			/**
579			* @param Indi\Endl $endl
580			* @return Indi
581			*/
582			public function setEndl($endl = []) {
583			$this->endl = $endl;
			0 ignored issues – show Documentation Bug introduced 2020-09-08 00:30 UTC by Report Bug Copy Issue Report It seems like `$endl` can also be of type `array`. However, the property `$endl` is declared as type `PhpGedcom\Record\Indi\Endl`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
584			return $this;
585			}
586			/**
587			* @param Indi\Endl $endl
588			* @return Indi
589			*/
590			public function addEndl($endl) {
591			$this->endl[] = $endl;
592			return $this;
593			}
594
595			/**
596			* @return Indi\Endl
597			*/
598			public function getEndl() {
599			return $this->endl;
600			}
601
602			/**
603			* @param Indi\Slgc $slgc
604			* @return Indi
605			*/
606			public function setSlgc($slgc = []) {
607			$this->slgc = $slgc;
			0 ignored issues – show Documentation Bug introduced 2020-09-08 00:30 UTC by Report Bug Copy Issue Report It seems like `$slgc` can also be of type `array`. However, the property `$slgc` is declared as type `PhpGedcom\Record\Indi\Slgc`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
608			return $this;
609			}
610
611			/**
612			* @param Indi\Slgc $slgc
613			* @return Indi
614			*/
615			public function addSlgc($slgc) {
616			$this->slgc[] = $slgc;
617			return $this;
618			}
619
620			/**
621			* @return Indi\Slgc
622			*/
623			public function getSlgc() {
624			return $this->slgc;
625			}
626			}
627

modularsoftware / php-gedcom

Branch — master (6a7148)

Indi::addDesi() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like