PhpGedcom\Parser\Indi\Even::parse()

Complexity

Conditions	23
Paths	17

Size

Total Lines	101
Code Lines	78

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	public static function parse(\PhpGedcom\Parser $parser) {
		$record = $parser->getCurrentLineRecord();
		$depth = (int) $record[0];
		if (empty($record[1])) {
			$parser->skipToNextLevel($depth);
			return null;
		}

		$even = null;

		if (strtoupper(trim($record[1])) != 'EVEN') {
			$className = '\\PhpGedcom\\Record\\Indi\\' . ucfirst(strtolower(trim($record[1])));
			$even = new $className();
		} else {
			$even = new \PhpGedcom\Record\Indi\Even();
		}

		if (isset($record[1]) && strtoupper(trim($record[1])) != 'EVEN') {
			$even->setType(trim($record[1]));
		}

        // ensures we capture any data following the EVEN type
        if (isset($record[2]) && !empty($record[2])) {
            $even->setAttr(trim($record[2]));

The method setAttr() does not exist on PhpGedcom\Record\Indi\Even. Since you implemented __call, consider adding a @method annotation.

        }

        $parser->forward();

		while (!$parser->eof()) {
			$record = $parser->getCurrentLineRecord();
			$recordType = strtoupper(trim($record[1]));
			$currentDepth = (int) $record[0];

			if ($currentDepth <= $depth) {
				$parser->back();
				break;
			}

			switch ($recordType) {
			case 'TYPE':
				$even->setType(trim($record[2]));
				break;
			case 'DATE':
				$dat = \PhpGedcom\Parser\Date::parse($parser);
				$even->setDate($dat);

It seems like $dat can also be of type PhpGedcom\Record\Date; however, parameter $date of PhpGedcom\Record\Indi\Even::setDate() does only seem to accept string, maybe add an additional type check?

				//$even->setDate(trim($record[2]))
				break;
			case 'PLAC':
				$plac = \PhpGedcom\Parser\Plac::parse($parser);
				$even->setPlac($plac);

It seems like $plac can also be of type PhpGedcom\Record\Plac; however, parameter $plac of PhpGedcom\Record\Indi\Even::setPlac() does only seem to accept PhpGedcom\Record\Indi\Even\Plac, maybe add an additional type check?

				break;
			case 'ADDR':
				$even->setAddr(\PhpGedcom\Parser\Addr::parse($parser));
				break;
			case 'PHON':
				$phone = \PhpGedcom\Parser\Phon::parse($parser);
				$even->addPhone($phone);

The method addPhone() does not exist on PhpGedcom\Record\Indi\Even. Since you implemented __call, consider adding a @method annotation.

				break;
			case 'CAUS':
				$even->setCaus(trim($record[2]));
				break;
			case 'AGE':
				$even->setAge(trim($record[2]));
				break;
			case 'AGNC':
				$even->setAgnc(trim($record[2]));
				break;
			case 'SOUR':
				$sour = \PhpGedcom\Parser\SourRef::parse($parser);
				$even->addSour($sour);
				break;
			case 'OBJE':
				$obje = \PhpGedcom\Parser\ObjeRef::parse($parser);
				$even->addObje($obje);
				break;
			case 'NOTE':
				$note = \PhpGedcom\Parser\NoteRef::parse($parser);
				if ($note) {
					$even->addNote($note);
				}
				break;
			case 'CHAN':
				$change = Chan::parse($parser);
				$even->setChan($change);
				break;
			default:
				$self = get_called_class();
				$method = 'parse' . $recordType;

				if (method_exists($self, $method)) {
					$self::$method($parser, $even);
				} else {
					$parser->logUnhandledRecord($self . ' @ ' . __LINE__);
					$parser->skipToNextLevel($currentDepth);
				}
			}

			$parser->forward();
		}

		return $even;
	}