PhpGedcom\Writer\NoteRef

Complexity

Total Complexity

5

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	convert()	0	21	5

<?php
/**
 * php-gedcom.
 *
 * php-gedcom is a library for parsing, manipulating, importing and exporting
 * GEDCOM 5.5 files in PHP 5.3+.
 *
 * @author          Xiang Ming <wenqiangliu344@gmail.com>
 * @copyright       Copyright (c) 2010-2013, Xiang Ming
 * @license         MIT
 *
 * @link            http://github.com/mrkrstphr/php-gedcom
 */

namespace PhpGedcom\Writer;

class NoteRef
{
    /**
     * @param \PhpGedcom\Record\NoteRef $note
     * @param int                       $level
     *
     * @return string
     */
    public static function convert(\PhpGedcom\Record\NoteRef &$note, $level)
    {
        $output = '';

        // $_note
        $_note = $note->getNote();

The method getNote() does not exist on PhpGedcom\Record\NoteRef. Since you implemented __call, consider adding a @method annotation.

        if (!empty($_note)) {
            $output .= $level.' NOTE '.$_note."\n";

Are you sure $_note of type PhpGedcom\Record\NoteRef|mixed can be used in concatenation?

        }

        $level++;
        // $sour
        $sour = $note->getSour();

The method getSour() does not exist on PhpGedcom\Record\NoteRef. Since you implemented __call, consider adding a @method annotation.

        if ($sour && count($sour) > 0) {

It seems like $sour can also be of type PhpGedcom\Record\NoteRef; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

            foreach ($sour as $item) {
                $_convert = \PhpGedcom\Writer\SourRef::convert($item, $level);
                $output .= $_convert;
            }
        }

        return $output;
    }
}