modularsoftware / genealogy

app/Tables/Builders/PersonTable.php

<?php

namespace App\Tables\Builders;

use App\Person;
use App\Traits\ConnectionTrait;
use Illuminate\Database\Eloquent\Builder;
use LaravelEnso\Tables\Contracts\Table;

class PersonTable extends \LaravelEnso\People\Tables\Builders\PersonTable
{
    use ConnectionTrait;

    protected const TemplatePath = __DIR__.'/../Templates/people.json';

    public function query(): Builder
    {
        $conn = $this->getConnection();
        $db = $this->getDB();

The assignment to $db is dead and can be removed.

        return Person::on($conn)->selectRaw('

The expression return App\Person::on($conn)->selectRaw(' people.id , people.title, people.givn, people.surn, people.appellative, people.email, people.phone, people.birthday, people.deathday, CASE WHEN users.id is null THEN 0 ELSE 1 END as "user", companies.name as company, people.created_at ')->leftJoin('users', 'people.id', '=', 'users.person_id')->leftJoin('company_person', function(...) { /* ... */ })->leftJoin('companies', 'company_person.company_id', 'companies.id') could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

            people.id
            , people.title, people.givn, people.surn,  people.appellative, people.email, people.phone,
            people.birthday, people.deathday, CASE WHEN users.id is null THEN 0 ELSE 1 END as "user",
            companies.name as company, people.created_at
        ')->leftJoin('users', 'people.id', '=', 'users.person_id')
            ->leftJoin(
                'company_person',
                fn ($join) => $join
                    ->on('people.id', '=', 'company_person.person_id')
                    ->where('company_person.is_main', true)
            )->leftJoin('companies', 'company_person.company_id', 'companies.id');
    }

    public function templatePath(): string
    {
        return static::TemplatePath;
    }
}