modularsoftware / genealogy

app/Notifications/SendActivationEmail.php

<?php

namespace App\Notifications;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Notification;

class SendActivationEmail extends Notification implements ShouldQueue
{
    use Queueable;

    protected $token;

    /**
     * Create a new notification instance.
     *
     * SendActivationEmail constructor.
     *
     * @param $token
     */
    public function __construct($token)
    {
        $this->token = $token;
        // $this->onQueue('social');
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param mixed $notifiable
     *
     * @return array
     */
    public function via($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return ['mail'];
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param mixed $notifiable
     *
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        $baseUrl = env('APP_URL');
        $url = $baseUrl.'/verify?token='.$this->token;
        $message = new MailMessage();
        $message->subject(trans('emails.activationSubject'))

It seems like trans('emails.activationSubject') can also be of type array and array; however, parameter $subject of Illuminate\Notifications\Messages\SimpleMessage::subject() does only seem to accept string, maybe add an additional type check?

            ->greeting(trans('emails.activationGreeting'))

It seems like trans('emails.activationGreeting') can also be of type array and array; however, parameter $greeting of Illuminate\Notifications\Messages\SimpleMessage::greeting() does only seem to accept string, maybe add an additional type check?

            ->line(trans('emails.activationMessage'))
            ->action(trans('emails.activationButton'), $url)

It seems like trans('emails.activationButton') can also be of type array and array; however, parameter $text of Illuminate\Notifications\Messages\SimpleMessage::action() does only seem to accept string, maybe add an additional type check?

            ->line($this->token)
            ->line(trans('emails.activationThanks'));

        return $message;
    }

    /**
     * Get the array representation of the notification.
     *
     * @param mixed $notifiable
     *
     * @return array
     */
    public function toArray($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return [
            //
        ];
    }
}