App\Http\Controllers\Gedcom\Store

Complexity

Total Complexity

4

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	14	3
A	readData()	0	4	1

<?php

namespace App\Http\Controllers\Gedcom;

use App\Note;
use App\Event;
use App\Family;
use App\Person;
use App\Source;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use Asdfx\LaravelGedcom\Facades\GedcomParserFacade;

class Store extends Controller
{
    /*
    * Api end-point for Gedcom api/gedcom/store
    * Saving uploaded file to storage and starting to read
    */

    public function __invoke(Request $request)
    {
        if ($request->hasFile('file')) {
            if ($request->file('file')->isValid()) {
                $request->file->storeAs('gedcom', 'file.ged');
                $this->readData($request->file);

                return ['File uploaded'];
            }

            return ['File corrupted'];
        }

        return ['Not uploaded'];
    }

    /*
    * Read ged file
    */

    public function readData($filename)

The parameter $filename is not used and could be removed.

    {
	$filename = $this->filename;

The property filename does not exist on App\Http\Controllers\Gedcom\Store. Did you maybe forget to declare it?

	GedcomParserFacade::parse($filename, true);
    }

}