App\Models\enso\Roles\Role

Complexity

Total Complexity

10

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	menu()	0	3	1
A	writeConfig()	0	3	1
A	delete()	0	7	2
A	users()	0	3	1
A	scopeVisible()	0	7	1
A	userGroups()	0	3	1
A	addDefaultPermissions()	0	4	1
A	permissions()	0	3	1
A	syncPermissions()	0	4	1

<?php

namespace App\Models\enso\Roles;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\Auth;
use App\Models\User;
use App\Models\enso\core\UserGroup;
use App\Models\enso\Menus\Menu;
use App\Models\enso\Permissions\Permission;
use LaravelEnso\Rememberable\App\Traits\Rememberable;
use LaravelEnso\Roles\App\Exceptions\RoleConflict;
use LaravelEnso\Roles\App\Services\ConfigWriter;
use LaravelEnso\Tables\App\Traits\TableCache;

/**
 * @property int $id
 * @property int $menu_id
 * @property string $name
 * @property string $display_name
 * @property string $description
 * @property string $created_at
 * @property string $updated_at
 * @property Menu $menu
 * @property PermissionRole[] $permissionRoles
 * @property RoleUserGroup[] $roleUserGroups
 * @property User[] $users
 */
class Role extends Model
{
    use Rememberable, TableCache;

The trait LaravelEnso\Rememberable\App\Traits\Rememberable requires the property $cacheLifetime which is not provided by App\Models\enso\Roles\Role.

    protected $fillable = ['menu_id', 'name', 'display_name', 'description'];

    public function menu()
    {
        return $this->belongsTo(Menu::class);
    }

    public function userGroups()
    {
        return $this->belongsToMany(UserGroup::class);
    }

    public function users()
    {
        return $this->hasMany(User::class);
    }

    public function permissions()
    {
        return $this->belongsToMany(Permission::class)->withTimestamps();
    }

    public function scopeVisible($query)
    {
        $fromAdminGroup = Auth::user()->belongsToAdminGroup();

The method belongsToAdminGroup() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

        return $query->when(! $fromAdminGroup, fn ($query) => $query->whereHas(
            'userGroups',
            fn ($groups) => $groups->whereId(Auth::user()->group_id)

Accessing group_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        ));
    }

    public function syncPermissions($permissionList)
    {
        $this->permissions()
            ->sync($permissionList);
    }

    public function addDefaultPermissions()
    {
        $this->permissions()
            ->sync(Permission::implicit()->pluck('id'));
    }

    public function delete()
    {
        if ($this->users()->exists()) {
            throw RoleConflict::inUse();
        }

        parent::delete();
    }

    public function writeConfig()
    {
        (new ConfigWriter($this))->handle();

$this of type App\Models\enso\Roles\Role is incompatible with the type LaravelEnso\Roles\App\Models\Role expected by parameter $role of LaravelEnso\Roles\App\Services\ConfigWriter::__construct().

    }
}