App\Tables\Builders\enso\core\UserTableIndi

Complexity

Total Complexity

2

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	query()	0	10	1
A	templatePath()	0	3	1

<?php

namespace App\Tables\Builders\enso\core;

use App\Models\User;
use Illuminate\Database\Eloquent\Builder;
use LaravelEnso\Tables\Contracts\Table;
use Auth;
class UserTableIndi implements Table
{
    protected const TemplatePath = __DIR__.'/../../../Templates/enso/core/user.json';

    protected $query;

    public function query(): Builder
    {
        return User::with('person:id,appellative,name', 'avatar:id,user_id')->selectRaw('

The expression return App\Models\User::with('person:id,appellative,name', 'avatar:id,user_id')->selectRaw(' users.id, user_groups.name as userGroup, people.name, people.appellative, people.phone, users.email, roles.name as role, users.is_active, users.created_at, users.person_id ')->join('people', 'users.person_id', '=', 'people.id')->join('user_groups', 'users.group_id', '=', 'user_groups.id')->join('roles', 'users.role_id', '=', 'roles.id')->where('users.id', Auth::user()->id) could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

            users.id, user_groups.name as userGroup, people.name, people.appellative,
            people.phone, users.email, roles.name as role, users.is_active,
            users.created_at, users.person_id
        ')->join('people', 'users.person_id', '=', 'people.id')
            ->join('user_groups', 'users.group_id', '=', 'user_groups.id')
            ->join('roles', 'users.role_id', '=', 'roles.id')
            ->where('users.id', Auth::user()->id);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    public function templatePath(): string
    {
        return static::TemplatePath;
    }
}