App\Service\enso\Localisation\Json\Updater

Complexity

Total Complexity

11

Size/Duplication

Total Lines	83
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	addNewKeys()	0	11	1
A	__construct()	0	5	1
A	updateDifferences()	0	9	3
A	addKey()	0	4	1
A	extraLangs()	0	5	1
A	run()	0	8	1
A	processKey()	0	5	1
A	removeExtraKeys()	0	10	1
A	extraLangFile()	0	3	1

<?php

namespace App\Service\enso\Localisation\Json;

use Illuminate\Support\Collection;
use LaravelEnso\Helpers\Services\JsonReader;
use App\Models\enso\Localisation\Language;

class Updater extends Handler
{
    private ?string $locale;
    private array $langArray;
    private ?string $subDir;

    public function __construct(Language $language, array $langArray, ?string $subDir = null)
    {
        $this->langArray = $langArray;
        $this->locale = $language->name;
        $this->subDir = $subDir;
    }

    public function run()
    {
        $this->savePartial(
            $this->locale, $this->langArray, $this->subDir

It seems like $this->subDir can also be of type null; however, parameter $subDir of App\Service\enso\Localisation\Json\Handler::savePartial() does only seem to accept string, maybe add an additional type check?

It seems like $this->locale can also be of type null; however, parameter $locale of App\Service\enso\Localisation\Json\Handler::savePartial() does only seem to accept string, maybe add an additional type check?

        );

        $this->extraLangs()
            ->each(fn ($locale) => $this->updateDifferences($locale));
    }

    public function addKey()
    {
        $this->extraLangs()
            ->each(fn ($locale) => $this->processKey($locale));
    }

    private function processKey($locale)
    {
        $extraLangFile = $this->extraLangFile($locale, $this->updateDir());
        [$addedCount, $extraLangFile] = $this->addNewKeys($extraLangFile);
        $this->savePartial($locale, $extraLangFile, $this->updateDir());
    }

    private function updateDifferences(string $locale)
    {
        $removedCount = $addedCount = 0;

The assignment to $addedCount is dead and can be removed.

The assignment to $removedCount is dead and can be removed.

        $extraLangFile = $this->extraLangFile($locale, $this->subDir);

It seems like $this->subDir can also be of type null; however, parameter $subDir of App\Service\enso\Localisation\Json\Updater::extraLangFile() does only seem to accept string, maybe add an additional type check?

        [$removedCount, $extraLangFile] = $this->removeExtraKeys($extraLangFile);
        [$addedCount, $extraLangFile] = $this->addNewKeys($extraLangFile);

        if ($addedCount || $removedCount) {
            $this->savePartial($locale, $extraLangFile, $this->subDir);

It seems like $this->subDir can also be of type null; however, parameter $subDir of App\Service\enso\Localisation\Json\Handler::savePartial() does only seem to accept string, maybe add an additional type check?

        }
    }

    private function removeExtraKeys(array $extraLangFile)
    {
        $keysToRemove = (new Collection($extraLangFile))
            ->diffKeys($this->langArray)
            ->keys();

        $extraLangFile = (new Collection($extraLangFile))
            ->filter(fn ($key) => $keysToRemove->contains($key));

        return [$keysToRemove->count(), $extraLangFile->toArray()];
    }

    private function addNewKeys(array $extraLangFile)
    {
        $keysToAdd = (new Collection($this->langArray))
            ->diffKeys($extraLangFile);

        $arrayToAdd = $this->newTranslations($keysToAdd->all());

        $extraLangFile = (new Collection($arrayToAdd))
            ->merge($extraLangFile);

        return [$keysToAdd->count(), $extraLangFile->toArray()];
    }

    private function extraLangFile(string $locale, string $subDir)
    {
        return (new JsonReader($this->jsonFileName($locale, $subDir)))->array();
    }

    private function extraLangs()
    {
        return Language::extra()
            ->where('name', '<>', $this->locale)
            ->pluck('name');
    }
}