App\Models\enso\core\UserGroup

Complexity

Total Complexity

5

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	roles()	0	3	1
A	users()	0	3	1
A	delete()	0	7	2
A	scopeVisible()	0	5	1

<?php

namespace App\Models\enso\core;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Facades\Auth;
use LaravelEnso\Core\App\Exceptions\UserGroupConflict;
use LaravelEnso\Rememberable\App\Traits\Rememberable;
use App\Models\Roles\Role;

The type App\Models\Roles\Role was not found. Maybe you did not declare it correctly or list all dependencies?

use LaravelEnso\Roles\App\Traits\HasRoles;
use LaravelEnso\Tables\App\Traits\TableCache;

/**
 * @property int $id
 * @property string $name
 * @property string $description
 * @property string $created_at
 * @property string $updated_at
 * @property RoleUserGroup[] $roleUserGroups
 * @property User[] $users
 */
class UserGroup extends Model
{
    /**
     * The table associated with the model.
     * 
     * @var string
     */
    protected $table = 'user_groups';
    use HasRoles, Rememberable, TableCache;

The trait LaravelEnso\Rememberable\App\Traits\Rememberable requires the property $cacheLifetime which is not provided by App\Models\enso\core\UserGroup.

    protected $fillable = ['name', 'description'];

    public function roles()
    {
        return $this->belongsToMany(Role::class);
    }

    public function users()
    {
        return $this->hasMany(User::class, 'group_id');
    }

    public function delete()
    {
        if ($this->users()->exists()) {
            throw UserGroupConflict::hasUsers();
        }

        parent::delete();
    }

    public function scopeVisible($query)
    {
        return $query->when(
            ! Auth::user()->belongsToAdminGroup(),

The method belongsToAdminGroup() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

            fn ($query) => $query->whereId(Auth::user()->group_id)

Accessing group_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        );
    }
}