RegisterController::create() - Code Metrics - Inspection of "Merge pull request #1368 from modularsoftware/depe..." - modularsoftware/genealogy - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 27ee29...5ee236 )

by Curtis

created 2020-08-17 23:45 UTC

RegisterController::create() A

↳ Parent: RegisterController

Complexity

Conditions	4
Paths	38

Size

Total Lines	56
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	4
eloc	30
nc	38
nop	1
dl	0
loc	56
rs	9.44
c	4
b	0
f	0

How to fix Long Method

<?php

namespace App\Http\Controllers\Auth;

use App\Http\Controllers\Controller;
use App\Jobs\Tenant\CreateDB;
use App\Jobs\Tenant\Migration;
use App\Models\User;
use App\Person;
use App\Providers\RouteServiceProvider;
use App\Traits\ActivationTrait;
use App\Traits\ConnectionTrait;
use Illuminate\Foundation\Auth\RegistersUsers;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Hash;
// use LaravelEnso\Multitenancy\Jobs\CreateDatabase;
// use LaravelEnso\Multitenancy\Jobs\Migrate;
use Illuminate\Support\Facades\Validator;
use LaravelEnso\Companies\Models\Company;
use LaravelEnso\Core\Models\UserGroup;
use LaravelEnso\Multitenancy\Enums\Connections;
use LaravelEnso\Roles\Models\Role;
use Str;

class RegisterController extends Controller
{
    use RegistersUsers;
    use ActivationTrait;

    protected $redirectTo = RouteServiceProvider::HOME;

    public function __construct()
    {
        $this->middleware('guest');
    }

    protected function validator(array $data)
    {
        return Validator::make($data, [
            'name' => ['required', 'string', 'max:255'],
            'email' => ['required', 'string', 'email', 'max:255', 'unique:users'],
            'password' => ['required', 'string', 'min:5', 'confirmed'],
        ]);
    }

    protected function create(array $data)
    {
        try {
            // DB::beginTransaction();
            // create person
            $person = new Person();
            $person->name = $data['name'];

            $person->email = $data['email'];

            $person->save();

            // get user_group_id
            $user_group = UserGroup::where('name', 'Administrators')->first();
            if ($user_group == null) {
                // create user_group
                $user_group = UserGroup::create(['name'=>'Administrators', 'description'=>'Administrator users group']);
            }

            // get role_id
            $role = Role::where('name', 'supervisor')->first();
            if ($role == null) {
                $role = Role::create(['menu_id'=>1, 'name'=>'supervisor', 'display_name'=>'Supervisor', 'description'=>'Supervisor role.']);
            }
            $user = User::create([
                'email' => $data['email'],
                'password' => Hash::make($data['password']),
                'person_id' => $person->id,
                'group_id' => $user_group->id,
                'role_id' => $role->id,
                'is_active' => 1,
            ]);
            // send verification email;

            $this->initiateEmailActivation($user);

            $company = Company::create([
                'name' => $data['name'],
                'email' => $data['email'],
                // 'is_active' => 1,
                'is_tenant' => 1,
                'status' => 1,
            ]);

//          $company->attachPerson($person->id, 'Owner');
            // DB::commit();

            $person->companies()->attach($company->id, ['person_id' => $person->id, 'is_main' => 1, 'is_mandatary' => 1, 'company_id' => $company->id]);

            // Dispatch Tenancy Jobs

            CreateDB::dispatch($company);
            Migration::dispatch($company, $data['name'], $data['email'], $data['password']);

            return $user;
        } catch (\Exception $e) {
            // DB::rollBack();
            throw $e;
        }
    }
}


1			<?php
2
3			namespace App\Http\Controllers\Auth;
4
5			use App\Http\Controllers\Controller;
6			use App\Jobs\Tenant\CreateDB;
7			use App\Jobs\Tenant\Migration;
8			use App\Models\User;
9			use App\Person;
10			use App\Providers\RouteServiceProvider;
11			use App\Traits\ActivationTrait;
12			use App\Traits\ConnectionTrait;
13			use Illuminate\Foundation\Auth\RegistersUsers;
14			use Illuminate\Support\Facades\DB;
15			use Illuminate\Support\Facades\Hash;
16			// use LaravelEnso\Multitenancy\Jobs\CreateDatabase;
17			// use LaravelEnso\Multitenancy\Jobs\Migrate;
18			use Illuminate\Support\Facades\Validator;
19			use LaravelEnso\Companies\Models\Company;
20			use LaravelEnso\Core\Models\UserGroup;
21			use LaravelEnso\Multitenancy\Enums\Connections;
22			use LaravelEnso\Roles\Models\Role;
23			use Str;
24
25			class RegisterController extends Controller
26			{
27			use RegistersUsers;
28			use ActivationTrait;
29
30			protected $redirectTo = RouteServiceProvider::HOME;
31
32			public function __construct()
33			{
34			$this->middleware('guest');
35			}
36
37			protected function validator(array $data)
38			{
39			return Validator::make($data, [
40			'name' => ['required', 'string', 'max:255'],
41			'email' => ['required', 'string', 'email', 'max:255', 'unique:users'],
42			'password' => ['required', 'string', 'min:5', 'confirmed'],
43			]);
44			}
45
46			protected function create(array $data)
47			{
48			try {
49			// DB::beginTransaction();
50			// create person
51			$person = new Person();
52			$person->name = $data['name'];
			0 ignored issues – show Bug introduced 2020-07-01 14:18 UTC by Report Bug Copy Issue Report The property `name` does not seem to exist on `App\Person`. Are you sure there is no database migration missing? Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct. Loading history...
53			$person->email = $data['email'];
			0 ignored issues – show Bug introduced 2020-06-30 17:31 UTC by Report Bug Copy Issue Report The property `email` does not seem to exist on `App\Person`. Are you sure there is no database migration missing? Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct. Loading history...
54			$person->save();
55
56			// get user_group_id
57			$user_group = UserGroup::where('name', 'Administrators')->first();
58			if ($user_group == null) {
59			// create user_group
60			$user_group = UserGroup::create(['name'=>'Administrators', 'description'=>'Administrator users group']);
61			}
62
63			// get role_id
64			$role = Role::where('name', 'supervisor')->first();
65			if ($role == null) {
66			$role = Role::create(['menu_id'=>1, 'name'=>'supervisor', 'display_name'=>'Supervisor', 'description'=>'Supervisor role.']);
67			}
68			$user = User::create([
69			'email' => $data['email'],
70			'password' => Hash::make($data['password']),
71			'person_id' => $person->id,
72			'group_id' => $user_group->id,
73			'role_id' => $role->id,
74			'is_active' => 1,
75			]);
76			// send verification email;
77
78			$this->initiateEmailActivation($user);
79
80			$company = Company::create([
81			'name' => $data['name'],
82			'email' => $data['email'],
83			// 'is_active' => 1,
84			'is_tenant' => 1,
85			'status' => 1,
86			]);
87
88			// $company->attachPerson($person->id, 'Owner');
89			// DB::commit();
90
91			$person->companies()->attach($company->id, ['person_id' => $person->id, 'is_main' => 1, 'is_mandatary' => 1, 'company_id' => $company->id]);
92
93			// Dispatch Tenancy Jobs
94
95			CreateDB::dispatch($company);
96			Migration::dispatch($company, $data['name'], $data['email'], $data['password']);
97
98			return $user;
99			} catch (\Exception $e) {
100			// DB::rollBack();
101			throw $e;
102			}
103			}
104			}
105

modularsoftware / genealogy

Push — master ( 27ee29...5ee236 )

RegisterController::create() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like