RequestViewHelper::appendFirstUriPartIfValidDimension() - Code Metrics - Inspection of "BUGFIX: Gracefully handle URLs without (correct) d..." - mocdk/MOC.NotFound - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Aske

created 2017-01-26 18:17 UTC

appendFirstUriPartIfValidDimension() C

↳ Parent: RequestViewHelper

Complexity

Conditions	13
Paths	10

Size

Total Lines	45
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	45
rs	5.1234
cc	13
eloc	31
nc	10
nop	1

How to fix Complexity

<?php
namespace MOC\NotFound\ViewHelpers;

use TYPO3\Flow\Annotations as Flow;
use TYPO3\Flow\Configuration\ConfigurationManager;
use TYPO3\Flow\Core\Bootstrap;
use TYPO3\Flow\Http\Request;
use TYPO3\Flow\Http\RequestHandler;
use TYPO3\Flow\Http\Response;
use TYPO3\Flow\Http\Uri;
use TYPO3\Flow\Mvc\ActionRequest;
use TYPO3\Flow\Mvc\Routing\Router;
use TYPO3\Fluid\Core\ViewHelper\AbstractViewHelper;
use TYPO3\Neos\Domain\Service\ContentDimensionPresetSourceInterface;

/**
 * Loads the content of a given URL
 */
class RequestViewHelper extends AbstractViewHelper {

	/**
	 * @Flow\Inject
	 * @var \TYPO3\Flow\Mvc\Dispatcher
	 */
	protected $dispatcher;

	/**
	 * @Flow\Inject(lazy = false)
	 * @var Bootstrap
	 */
	protected $bootstrap;

	/**
	 * @Flow\Inject(lazy = false)
	 * @var Router
	 */
	protected $router;

	/**
	 * @Flow\Inject(lazy=false)
	 * @var \TYPO3\Flow\Security\Context
	 */
	protected $securityContext;

	/**
	 * @Flow\Inject
	 * @var ConfigurationManager
	 */
	protected $configurationManager;

	/**
	 * @Flow\InjectConfiguration("routing.supportEmptySegmentForDimensions", package="TYPO3.Neos")
	 * @var boolean
	 */
	protected $supportEmptySegmentForDimensions;

	/**
	 * @Flow\Inject
	 * @var ContentDimensionPresetSourceInterface
	 */
	protected $contentDimensionPresetSource;

	/**
	 * Initialize this engine
	 *
	 * @return void
	 */
	public function initializeObject() {
		$this->router->setRoutesConfiguration($this->configurationManager->getConfiguration(ConfigurationManager::CONFIGURATION_TYPE_ROUTES));
	}

	/**
	 * @param string $path
	 * @return string
	 * @throws \Exception
	 */
	public function render($path = NULL) {
		$this->appendFirstUriPartIfValidDimension($path);
		/** @var RequestHandler $activeRequestHandler */
		$activeRequestHandler = $this->bootstrap->getActiveRequestHandler();
		$parentHttpRequest = $activeRequestHandler->getHttpRequest();
		$uri = rtrim($parentHttpRequest->getBaseUri(), '/') . '/' . $path;
		$httpRequest = Request::create(new Uri($uri));
		$matchingRoute = $this->router->route($httpRequest);
		if (!$matchingRoute) {

			$exception = new \Exception(sprintf('Uri with path "%s" could not be found.', $uri), 1426446160);
			$exceptionHandler = set_exception_handler(null)[0];
			$exceptionHandler->handleException($exception);
			exit();

		}
		$request = new ActionRequest($parentHttpRequest);
		foreach ($matchingRoute as $argumentName => $argumentValue) {
			$request->setArgument($argumentName, $argumentValue);
		}
		$response = new Response($activeRequestHandler->getHttpResponse());

		$this->securityContext->withoutAuthorizationChecks(function() use ($request, $response) {
			$this->dispatcher->dispatch($request, $response);
		});

		return $response->getContent();
	}

	/**
	 * @param string $path
	 * @return void
	 */
	protected function appendFirstUriPartIfValidDimension(&$path) {
		$requestPath = ltrim($this->controllerContext->getRequest()->getHttpRequest()->getUri()->getPath(), '/');
		$matches = [];
		preg_match(\TYPO3\Neos\Routing\FrontendNodeRoutePartHandler::DIMENSION_REQUEST_PATH_MATCHER, $requestPath, $matches);
		if (!isset($matches['firstUriPart']) && !isset($matches['dimensionPresetUriSegments'])) {
			return;
		}

		$dimensionPresets = $this->contentDimensionPresetSource->getAllPresets();
		if (count($dimensionPresets) === 0) {
			return;
		}

		$firstUriPartExploded = explode('_', $matches['firstUriPart'] ?: $matches['dimensionPresetUriSegments']);
		if ($this->supportEmptySegmentForDimensions) {
			foreach ($firstUriPartExploded as $uriSegment) {
				$uriSegmentIsValid = false;
				foreach ($dimensionPresets as $dimensionName => $dimensionPreset) {
					$preset = $this->contentDimensionPresetSource->findPresetByUriSegment($dimensionName, $uriSegment);
					if ($preset !== null) {
						$uriSegmentIsValid = true;
						break;
					}
				}
				if (!$uriSegmentIsValid) {
					return;
				}
			}
		} else {
			if (count($firstUriPartExploded) !== count($dimensionPresets)) {
				$this->appendDefaultDimensionPresetUriSegments($dimensionPresets, $path);
				return;
			}
			foreach ($dimensionPresets as $dimensionName => $dimensionPreset) {
				$uriSegment = array_shift($firstUriPartExploded);
				$preset = $this->contentDimensionPresetSource->findPresetByUriSegment($dimensionName, $uriSegment);
				if ($preset === null) {
					$this->appendDefaultDimensionPresetUriSegments($dimensionPresets, $path);
					return;
				}
			}
		}

		$path = $matches['firstUriPart'] . '/' . $path;
	}

	/**
	 * @param array $dimensionPresets
	 * @param string $path
	 * @return void
	 */
	protected function appendDefaultDimensionPresetUriSegments($dimensionPresets, &$path) {
		$defaultDimensionPresetUriSegments = [];
		foreach ($dimensionPresets as $dimensionName => $dimensionPreset) {
			$defaultDimensionPresetUriSegments[] = $dimensionPreset['presets'][$dimensionPreset['defaultPreset']]['uriSegment'];
		}
		$path = implode('_', $defaultDimensionPresetUriSegments) . '/' . $path;
	}
}


1			<?php
2			namespace MOC\NotFound\ViewHelpers;
3
4			use TYPO3\Flow\Annotations as Flow;
5			use TYPO3\Flow\Configuration\ConfigurationManager;
6			use TYPO3\Flow\Core\Bootstrap;
7			use TYPO3\Flow\Http\Request;
8			use TYPO3\Flow\Http\RequestHandler;
9			use TYPO3\Flow\Http\Response;
10			use TYPO3\Flow\Http\Uri;
11			use TYPO3\Flow\Mvc\ActionRequest;
12			use TYPO3\Flow\Mvc\Routing\Router;
13			use TYPO3\Fluid\Core\ViewHelper\AbstractViewHelper;
14			use TYPO3\Neos\Domain\Service\ContentDimensionPresetSourceInterface;
15
16			/**
17			* Loads the content of a given URL
18			*/
19			class RequestViewHelper extends AbstractViewHelper {
20
21			/**
22			* @Flow\Inject
23			* @var \TYPO3\Flow\Mvc\Dispatcher
24			*/
25			protected $dispatcher;
26
27			/**
28			* @Flow\Inject(lazy = false)
29			* @var Bootstrap
30			*/
31			protected $bootstrap;
32
33			/**
34			* @Flow\Inject(lazy = false)
35			* @var Router
36			*/
37			protected $router;
38
39			/**
40			* @Flow\Inject(lazy=false)
41			* @var \TYPO3\Flow\Security\Context
42			*/
43			protected $securityContext;
44
45			/**
46			* @Flow\Inject
47			* @var ConfigurationManager
48			*/
49			protected $configurationManager;
50
51			/**
52			* @Flow\InjectConfiguration("routing.supportEmptySegmentForDimensions", package="TYPO3.Neos")
53			* @var boolean
54			*/
55			protected $supportEmptySegmentForDimensions;
56
57			/**
58			* @Flow\Inject
59			* @var ContentDimensionPresetSourceInterface
60			*/
61			protected $contentDimensionPresetSource;
62
63			/**
64			* Initialize this engine
65			*
66			* @return void
67			*/
68			public function initializeObject() {
69			$this->router->setRoutesConfiguration($this->configurationManager->getConfiguration(ConfigurationManager::CONFIGURATION_TYPE_ROUTES));
70			}
71
72			/**
73			* @param string $path
74			* @return string
75			* @throws \Exception
76			*/
77			public function render($path = NULL) {
78			$this->appendFirstUriPartIfValidDimension($path);
79			/** @var RequestHandler $activeRequestHandler */
80			$activeRequestHandler = $this->bootstrap->getActiveRequestHandler();
81			$parentHttpRequest = $activeRequestHandler->getHttpRequest();
82			$uri = rtrim($parentHttpRequest->getBaseUri(), '/') . '/' . $path;
83			$httpRequest = Request::create(new Uri($uri));
84			$matchingRoute = $this->router->route($httpRequest);
85			if (!$matchingRoute) {
			0 ignored issues – show Bug Best Practice introduced 2016-01-26 15:03 UTC by Report Bug Copy Issue Report The expression `$matchingRoute` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
86			$exception = new \Exception(sprintf('Uri with path "%s" could not be found.', $uri), 1426446160);
87			$exceptionHandler = set_exception_handler(null)[0];
88			$exceptionHandler->handleException($exception);
89			exit();
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-09 04:51 UTC by Report Bug Copy Issue Report The method `render()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
90			}
91			$request = new ActionRequest($parentHttpRequest);
92			foreach ($matchingRoute as $argumentName => $argumentValue) {
93			$request->setArgument($argumentName, $argumentValue);
94			}
95			$response = new Response($activeRequestHandler->getHttpResponse());
96
97			$this->securityContext->withoutAuthorizationChecks(function() use ($request, $response) {
98			$this->dispatcher->dispatch($request, $response);
99			});
100
101			return $response->getContent();
102			}
103
104			/**
105			* @param string $path
106			* @return void
107			*/
108			protected function appendFirstUriPartIfValidDimension(&$path) {
109			$requestPath = ltrim($this->controllerContext->getRequest()->getHttpRequest()->getUri()->getPath(), '/');
110			$matches = [];
111			preg_match(\TYPO3\Neos\Routing\FrontendNodeRoutePartHandler::DIMENSION_REQUEST_PATH_MATCHER, $requestPath, $matches);
112			if (!isset($matches['firstUriPart']) && !isset($matches['dimensionPresetUriSegments'])) {
113			return;
114			}
115
116			$dimensionPresets = $this->contentDimensionPresetSource->getAllPresets();
117			if (count($dimensionPresets) === 0) {
118			return;
119			}
120
121			$firstUriPartExploded = explode('_', $matches['firstUriPart'] ?: $matches['dimensionPresetUriSegments']);
122			if ($this->supportEmptySegmentForDimensions) {
123			foreach ($firstUriPartExploded as $uriSegment) {
124			$uriSegmentIsValid = false;
125			foreach ($dimensionPresets as $dimensionName => $dimensionPreset) {
126			$preset = $this->contentDimensionPresetSource->findPresetByUriSegment($dimensionName, $uriSegment);
127			if ($preset !== null) {
128			$uriSegmentIsValid = true;
129			break;
130			}
131			}
132			if (!$uriSegmentIsValid) {
133			return;
134			}
135			}
136			} else {
137			if (count($firstUriPartExploded) !== count($dimensionPresets)) {
138			$this->appendDefaultDimensionPresetUriSegments($dimensionPresets, $path);
139			return;
140			}
141			foreach ($dimensionPresets as $dimensionName => $dimensionPreset) {
142			$uriSegment = array_shift($firstUriPartExploded);
143			$preset = $this->contentDimensionPresetSource->findPresetByUriSegment($dimensionName, $uriSegment);
144			if ($preset === null) {
145			$this->appendDefaultDimensionPresetUriSegments($dimensionPresets, $path);
146			return;
147			}
148			}
149			}
150
151			$path = $matches['firstUriPart'] . '/' . $path;
152			}
153
154			/**
155			* @param array $dimensionPresets
156			* @param string $path
157			* @return void
158			*/
159			protected function appendDefaultDimensionPresetUriSegments($dimensionPresets, &$path) {
160			$defaultDimensionPresetUriSegments = [];
161			foreach ($dimensionPresets as $dimensionName => $dimensionPreset) {
162			$defaultDimensionPresetUriSegments[] = $dimensionPreset['presets'][$dimensionPreset['defaultPreset']]['uriSegment'];
163			}
164			$path = implode('_', $defaultDimensionPresetUriSegments) . '/' . $path;
165			}
166			}
167

mocdk / MOC.NotFound

Pull Request — master (#10)

appendFirstUriPartIfValidDimension() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like