mnabialek / laravel-sql-logger

src/Query.php

<?php

namespace Mnabialek\LaravelSqlLogger;

use Mnabialek\LaravelSqlLogger\Objects\SqlQuery;
use Mnabialek\LaravelVersion\Version;

class Query
{
    /**
     * @var Version
     */
    private $version;

    /**
     * Query constructor.
     *
     * @param Version $version
     */
    public function __construct(Version $version)
    {
        $this->version = $version;
    }

    /**
     * @param int $number
     * @param string|\Illuminate\Database\Events\QueryExecuted $query
     * @param array|null $bindings
     * @param float|null $time
     *
     * @return SqlQuery
     */
    public function get($number, $query, array $bindings = null, $time = null)
    {
        // for Laravel/Lumen 5.2+ $query is object and it holds all the data
        if ($this->version->min('5.2.0')) {
            $bindings = $query->bindings;
            $time = $query->time;
            $query = $query->sql;
        }

        return new SqlQuery($number, $query, $bindings, $time);

It seems like $query can also be of type Illuminate\Database\Events\QueryExecuted; however, parameter $sql of Mnabialek\LaravelSqlLogger\Objects\SqlQuery::__construct() does only seem to accept string, maybe add an additional type check?

It seems like $bindings can also be of type null; however, parameter $bindings of Mnabialek\LaravelSqlLogger\Objects\SqlQuery::__construct() does only seem to accept array, maybe add an additional type check?

    }
}