ModuleMakeMigration::getMigrationFileName() - Code Metrics - mnabialek/laravel-modular - Measure and Improve Code Quality continuously with Scrutinizer

ModuleMakeMigration::getMigrationFileName() A
last analyzed 2017-01-24 17:31 UTC

↳ Parent: ModuleMakeMigration

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php

namespace Mnabialek\LaravelModular\Console\Commands;

use Exception;
use Mnabialek\LaravelModular\Models\Module;
use Mnabialek\LaravelModular\Traits\Replacer;
use Mnabialek\LaravelModular\Console\Traits\ModuleCreator;
use Mnabialek\LaravelModular\Console\Traits\ModuleVerification;

class ModuleMakeMigration extends BaseCommand
{
    use ModuleVerification;
    use Replacer;
    use ModuleCreator;

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'module:make-migration 
    {module : Module name}
    {name : Migration full name (ex. create_users_table)}
    {--type= : Type of migration (default options: create, edit)}
    {--table= : Table name (use with --type)}
    {--group= : Stub group name that will be used for creating this migration}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create migration in selected module';

    /**
     * {@inheritdoc}
     */
    public function proceed()
    {
        $module = $this->argument('module');
        $name = $this->argument('name');
        $type = $this->option('type');
        $table = $this->option('table');

        // verify whether both type and table used
        if ($type && !$table || $table && !$type) {
            throw new Exception('You need to use both options --type and --table when using any of them');
        }

        // verify whether module exists
        $modules = $this->verifyExisting(collect((array)$module));

        $this->createMigrationFile($modules->first(), $name, $type, $table);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * Create migration file
     *
     * @param Module $module
     * @param string $name
     * @param string $type
     * @param string $table
     *
     * @throws Exception
     */
    protected function createMigrationFile(Module $module, $name, $type, $table)
    {
        $stubGroup = $this->getStubGroup();
        $type =
            $type ?: $this->laravel['modular.config']->migrationDefaultType();
        $stubFile =
            $this->laravel['modular.config']->migrationStubFileName($type);

        if (!$stubFile) {
            throw new Exception("There is no {$type} in module_migrations.types registered in configuration file");
        }

        // migration file name
        $filename = $this->getMigrationFileName($name);

        // migration class name
        $migrationClass = studly_case($name);

        $this->copyStubFileIntoModule($module, $stubFile, $stubGroup,
            $module->migrationsPath(true) . DIRECTORY_SEPARATOR . $filename,
            ['migrationClass' => $migrationClass, 'table' => $table]
        );

        $this->info("[Module {$module->name()}] Created migration file: {$filename}");
    }

    /**
     * Get migration file name based on user given migration name
     *
     * @param string $name
     *
     * @return string
     */
    protected function getMigrationFileName($name)
    {
        return date('Y_m_d_His') . '_' . snake_case($name) . '.php';
    }
}


1			<?php
2
3			namespace Mnabialek\LaravelModular\Console\Commands;
4
5			use Exception;
6			use Mnabialek\LaravelModular\Models\Module;
7			use Mnabialek\LaravelModular\Traits\Replacer;
8			use Mnabialek\LaravelModular\Console\Traits\ModuleCreator;
9			use Mnabialek\LaravelModular\Console\Traits\ModuleVerification;
10
11			class ModuleMakeMigration extends BaseCommand
12			{
13			use ModuleVerification;
14			use Replacer;
15			use ModuleCreator;
16
17			/**
18			* The name and signature of the console command.
19			*
20			* @var string
21			*/
22			protected $signature = 'module:make-migration
23			{module : Module name}
24			{name : Migration full name (ex. create_users_table)}
25			{--type= : Type of migration (default options: create, edit)}
26			{--table= : Table name (use with --type)}
27			{--group= : Stub group name that will be used for creating this migration}';
28
29			/**
30			* The console command description.
31			*
32			* @var string
33			*/
34			protected $description = 'Create migration in selected module';
35
36			/**
37			* {@inheritdoc}
38			*/
39			public function proceed()
40			{
41			$module = $this->argument('module');
42			$name = $this->argument('name');
43			$type = $this->option('type');
44			$table = $this->option('table');
45
46			// verify whether both type and table used
47			if ($type && !$table \|\| $table && !$type) {
48			throw new Exception('You need to use both options --type and --table when using any of them');
49			}
50
51			// verify whether module exists
52			$modules = $this->verifyExisting(collect((array)$module));
53
54			$this->createMigrationFile($modules->first(), $name, $type, $table);
			0 ignored issues – show Bug introduced 2016-08-24 09:03 UTC by Report Bug Copy Issue Report It seems like `$name` defined by `$this->argument('name')` on line `42` can also be of type `array`; however, `Mnabialek\LaravelModular...::createMigrationFile()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2016-08-24 09:03 UTC by Report Bug Copy Issue Report It seems like `$type` defined by `$this->option('type')` on line `43` can also be of type `array`; however, `Mnabialek\LaravelModular...::createMigrationFile()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string / function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history... Bug introduced 2016-08-24 09:03 UTC by Report Bug Copy Issue Report It seems like `$table` defined by `$this->option('table')` on line `44` can also be of type `array`; however, `Mnabialek\LaravelModular...::createMigrationFile()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /* * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
55			}
56
57			/**
58			* Create migration file
59			*
60			* @param Module $module
61			* @param string $name
62			* @param string $type
63			* @param string $table
64			*
65			* @throws Exception
66			*/
67			protected function createMigrationFile(Module $module, $name, $type, $table)
68			{
69			$stubGroup = $this->getStubGroup();
70			$type =
71			$type ?: $this->laravel['modular.config']->migrationDefaultType();
72			$stubFile =
73			$this->laravel['modular.config']->migrationStubFileName($type);
74
75			if (!$stubFile) {
76			throw new Exception("There is no {$type} in module_migrations.types registered in configuration file");
77			}
78
79			// migration file name
80			$filename = $this->getMigrationFileName($name);
81
82			// migration class name
83			$migrationClass = studly_case($name);
84
85			$this->copyStubFileIntoModule($module, $stubFile, $stubGroup,
86			$module->migrationsPath(true) . DIRECTORY_SEPARATOR . $filename,
87			['migrationClass' => $migrationClass, 'table' => $table]
88			);
89
90			$this->info("[Module {$module->name()}] Created migration file: {$filename}");
91			}
92
93			/**
94			* Get migration file name based on user given migration name
95			*
96			* @param string $name
97			*
98			* @return string
99			*/
100			protected function getMigrationFileName($name)
101			{
102			return date('Y_m_d_His') . '_' . snake_case($name) . '.php';
103			}
104			}
105

mnabialek / laravel-modular

ModuleMakeMigration::getMigrationFileName() A last analyzed 2017-01-24 17:31 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ModuleMakeMigration::getMigrationFileName() A
last analyzed 2017-01-24 17:31 UTC