Mnabialek\LaravelModular\Console\Traits\ModuleVerification

Complexity

Total Complexity

8

Size/Duplication

Total Lines	72
Duplicated Lines	25 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	verifyActive()	9	9	2
A	verifyExisting()	9	9	2
B	verifyModules()	0	25	4

<?php

namespace Mnabialek\LaravelModular\Console\Traits;

use Exception;
use Illuminate\Support\Collection;
use Mnabialek\LaravelModular\Models\Module;

trait ModuleVerification
{
    /**
     * Verify whether given modules exist and are active
     *
     * @param Collection $moduleNames
     *
     * @return Collection
     * @throws Exception
     */
    protected function verifyActive(Collection $moduleNames)

This method seems to be duplicated in your project.

    {
        $modules = $this->verifyModules($moduleNames, true);
        if ($modules->count() != $moduleNames->count()) {
            throw new Exception('There were errors. You need to pass only valid active module names');
        }

        return $modules;
    }

    /**
     * Verify whether given modules exist
     *
     * @param Collection $moduleNames
     *
     * @return Collection
     * @throws Exception
     */
    protected function verifyExisting(Collection $moduleNames)

This method seems to be duplicated in your project.

    {
        $modules = $this->verifyModules($moduleNames, false);
        if ($modules->count() != $moduleNames->count()) {
            throw new Exception('There were errors. You need to pass only valid module names');
        }

        return $modules;
    }

    /**
     * Verifies whether given modules exist and whether they are active
     *
     * @param Collection $moduleNames
     * @param bool $verifyActive
     *
     * @return Collection|bool
     */
    private function verifyModules(Collection $moduleNames, $verifyActive)
    {
        $modules = collect();

        $moduleNames->each(function ($name) use ($verifyActive, $modules) {
            /** @var Module $module */
            $module = $this->laravel['modular']->find($name);

The property laravel does not exist. Did you maybe forget to declare it?

            if (!$module) {
                $this->error("Module {$name} does not exist");

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                return;
            }

            if ($verifyActive && !$module->active()) {
                $this->error("Module {$name} is not active");

It seems like error() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                return;
            }

            $modules->push($module);
        });

        return $modules;
    }
}