CommonTrait::removeOlderThan() - Code Metrics - Inspection of "try out the new scrutinizer" - mmucklo/DtcQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#57)

by Matthew

created 2018-02-17 16:06 UTC

CommonTrait::removeOlderThan() A

↳ Parent: CommonTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	2.004

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
ccs	9
cts	10
cp	0.9
cc	2
eloc	10
nc	2
nop	3
crap	2.004

<?php

namespace Dtc\QueueBundle\ODM;

use Doctrine\Common\Persistence\ObjectManager;
use Doctrine\ODM\MongoDB\DocumentManager;
use Dtc\QueueBundle\Document\Job;
use Dtc\QueueBundle\Document\JobTiming;
use Dtc\QueueBundle\Document\Run;

trait CommonTrait
{
    /**
     * @param string    $objectName
     * @param string    $field
     * @param \DateTime $olderThan
     *
     * @return int
     */
    protected function removeOlderThan($objectName, $field, \DateTime $olderThan)
    {
        /** @var DocumentManager $objectManager */
        $objectManager = $this->getObjectManager();
        $qb = $objectManager->createQueryBuilder($objectName);
        $qb
            ->remove()
            ->field($field)->lt($olderThan);

        $query = $qb->getQuery();
        $result = $query->execute();
        if (isset($result['n'])) {
            return $result['n'];
        }

        return 0;
    }

    /**
     * @param Run|Job|JobTiming $object
     * @param string            $action
     */
    protected function persist($object, $action = 'persist')
    {
        $objectManager = $this->getObjectManager();
        $objectManager->$action($object);
        $objectManager->flush();
    }

    /**
     * @return ObjectManager
     */
    abstract public function getObjectManager();

    /**
     * @param string $objectName
     */
    public function stopIdGenerator($objectName)
    {
        // Not needed for ODM
    }

    public function restoreIdGenerator($objectName)
    {
        // Not needed for ODM
    }
}


1		<?php
2
3		namespace Dtc\QueueBundle\ODM;
4
5		use Doctrine\Common\Persistence\ObjectManager;
6		use Doctrine\ODM\MongoDB\DocumentManager;
7		use Dtc\QueueBundle\Document\Job;
8		use Dtc\QueueBundle\Document\JobTiming;
9		use Dtc\QueueBundle\Document\Run;
10
11		trait CommonTrait
12		{
13		/**
14		* @param string $objectName
15		* @param string $field
16		* @param \DateTime $olderThan
17		*
18		* @return int
19		*/
20	2	protected function removeOlderThan($objectName, $field, \DateTime $olderThan)
21		{
22		/** @var DocumentManager $objectManager */
23	2	$objectManager = $this->getObjectManager();
24	2	$qb = $objectManager->createQueryBuilder($objectName);
25		$qb
26	2	->remove()
27	2	->field($field)->lt($olderThan);
28
29	2	$query = $qb->getQuery();
30	2	$result = $query->execute();
31	2	if (isset($result['n'])) {
32	2	return $result['n'];
33		}
34
35		return 0;
36		}
37
38		/**
39		* @param Run\|Job\|JobTiming $object
40		* @param string $action
41		*/
42	22	protected function persist($object, $action = 'persist')
43		{
44	22	$objectManager = $this->getObjectManager();
45	22	$objectManager->$action($object);
46	22	$objectManager->flush();
47	22	}
48
49		/**
50		* @return ObjectManager
51		*/
52		abstract public function getObjectManager();
53
54		/**
55		* @param string $objectName
56		*/
57	1	public function stopIdGenerator($objectName)
58		{
59		// Not needed for ODM
60	1	}
61
62	1	public function restoreIdGenerator($objectName)
63		{
64		// Not needed for ODM
65	1	}
66		}
67

mmucklo / DtcQueueBundle

Pull Request — master (#57)

CommonTrait::removeOlderThan() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like