Dtc\QueueBundle\Tests\Model\WorkerTest

Complexity

Total Complexity

13

Size/Duplication

Total Lines	142
Duplicated Lines	59.15 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	6	1
A	testAt()	21	21	2
A	testLater()	21	21	2
A	testBatchLater()	21	21	2
A	testBatchAt()	21	21	2
B	assertJob()	0	36	4

<?php

namespace Dtc\QueueBundle\Tests\Model;

use Dtc\QueueBundle\Model\Job;
use Dtc\QueueBundle\Tests\FibonacciWorker;
use Dtc\QueueBundle\Tests\StaticJobManager;

class WorkerTest extends \PHPUnit_Framework_TestCase
{
    protected $worker;
    protected $jobManager;

    public function setUp()
    {
        $this->jobManager = new StaticJobManager();
        $this->worker = new FibonacciWorker();
        $this->worker->setJobManager($this->jobManager);
    }

    public function testAt()

This method seems to be duplicated in your project.

    {
        $time = time() + 2600;
        $job = $this->worker->at($time)->fibonacci(20);
        self::assertJob($job, $time, 'fibonacci');

        // Test at with priority
        $priority = 1024;
        $job = $this->worker->at($time, false, $priority)->fibonacci(20);
        self::assertJob($job, $time, 'fibonacci', $priority);
        self::assertFalse($job->getBatch(), 'Should not be batching');

        // Test job with object
        try {
            $object = new \stdClass();
            $this->worker->at($time)->fibonacci($object);
            self::fail('Exception should be thrown.');
        } catch (\Exception $e) {
            self::assertTrue(true);
        }
    }

    public function testLater()

This method seems to be duplicated in your project.

    {
        $time = null;
        $job = $this->worker->later()->fibonacci(20);
        self::assertJob($job, $time, 'fibonacci');
        self::assertFalse($job->getBatch(), 'Should not be batching');

        // Test later with priority
        $priority = 1024;
        $job = $this->worker->later(0, $priority)->fibonacci(20);
        self::assertJob($job, $time, 'fibonacci', $priority);

        // Test job with object
        try {
            $object = new \stdClass();
            $this->worker->later($time)->fibonacci($object);
            self::fail('Exception should be thrown.');
        } catch (\Exception $e) {
            self::assertTrue(true);
        }
    }

    public function testBatchLater()

This method seems to be duplicated in your project.

    {
        $time = null;
        $job = $this->worker->batchLater()->fibonacci(20);
        self::assertJob($job, $time, 'fibonacci');
        self::assertTrue($job->getBatch(), 'Should be batching');

        // Test batchLater with priority
        $priority = 1024;
        $job = $this->worker->batchLater(0, $priority)->fibonacci(20);
        self::assertJob($job, $time, 'fibonacci', $priority);

        // Test job with object
        try {
            $object = new \stdClass();
            $this->worker->batchLater($time)->fibonacci($object);
            self::fail('Exception should be thrown.');
        } catch (\Exception $e) {
            self::assertTrue(true);
        }
    }

    public function testBatchAt()

This method seems to be duplicated in your project.

    {
        $time = time() + 3600;
        $job = $this->worker->batchAt($time)->fibonacci(20);
        self::assertJob($job, $time, 'fibonacci');
        self::assertTrue($job->getBatch(), 'Should be batching');

        // Test priority
        $priority = 1024;
        $job = $this->worker->batchAt($time, $priority)->fibonacci(20);
        self::assertJob($job, $time, 'fibonacci', $priority);

        // Test job with object
        try {
            $object = new \stdClass();
            $this->worker->batchAt($time)->fibonacci($object);
            self::fail('Exception should be thrown.');
        } catch (\Exception $e) {
            self::assertTrue(true);
        }
    }

    /**
     * @param int|null $time
     * @param string   $method
     * @param int      $priority
     */
    protected function assertJob(Job $job, $time, $method, $priority = null)
    {
        self::assertNotEmpty($job->getId(), 'Job should have an id');

        if ($time && $time > 0) {

The expression $time of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            self::assertEquals(
                $time,
                $job->getWhenAt()->getTimestamp(),
                    'Job start time should equals'
            );
        }

        if ($priority) {

The expression $priority of type integer|null is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            self::assertEquals(
                $priority,
                $job->getPriority(),
                    'Priority should be the same.'
            );
        } else {
            self::assertNull($job->getPriority(), 'Priority should be null');
        }

        self::assertEquals(
            $this->worker->getName(),
            $job->getWorkerName(),
                'Worker should be the same'
        );
        self::assertEquals(
            $method,
            $job->getMethod(),
                'Worker method should be the same'
        );

        // Make sure param gets saved
        self::assertContains(20, $job->getArgs());
    }
}