mmucklo /
DtcQueueBundle
| Total Complexity | 67 |
| Total Lines | 417 |
| Duplicated Lines | 0 % |
| Coverage | 87.88% |
| Changes | 1 | ||
| Bugs | 1 | Features | 0 |
Complex classes like TrendsController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use TrendsController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 17 | class TrendsController extends Controller |
||
|
Deprecated Code
introduced
by
|
|||
| 18 | { |
||
| 19 | use ControllerTrait; |
||
| 20 | |||
| 21 | /** |
||
| 22 | * Show a graph of job trends. |
||
| 23 | * |
||
| 24 | * @Route("/trends", name="dtc_queue_trends") |
||
| 25 | * @Template("@DtcQueue/Queue/trends.html.twig") |
||
| 26 | */ |
||
| 27 | 1 | public function trendsAction() |
|
| 28 | { |
||
| 29 | 1 | $recordTimings = $this->container->getParameter('dtc_queue.timings.record'); |
|
| 30 | 1 | $foundYearFunction = class_exists('Oro\ORM\Query\AST\Platform\Functions\Mysql\Year') || class_exists('DoctrineExtensions\Query\Mysql\Year'); |
|
| 31 | 1 | $params = ['record_timings' => $recordTimings, 'states' => JobTiming::getStates(), 'found_year_function' => $foundYearFunction]; |
|
| 32 | 1 | $this->addCssJs($params); |
|
| 33 | |||
| 34 | 1 | return $params; |
|
| 35 | } |
||
| 36 | |||
| 37 | /** |
||
| 38 | * @Route("/timings", name="dtc_queue_timings") |
||
| 39 | */ |
||
| 40 | 1 | public function getTimingsAction(Request $request) |
|
| 41 | { |
||
| 42 | 1 | $begin = $request->query->get('begin'); |
|
| 43 | 1 | $end = $request->query->get('end'); |
|
| 44 | 1 | $type = $request->query->get('type', 'HOUR'); |
|
| 45 | 1 | $beginDate = \DateTime::createFromFormat('Y-m-d\TH:i:s.uO', $begin, new \DateTimeZone(date_default_timezone_get())) ?: null; |
|
| 46 | 1 | $endDate = \DateTime::createFromFormat('Y-m-d\TH:i:s.uO', $end, new \DateTimeZone(date_default_timezone_get())) ?: \Dtc\QueueBundle\Util\Util::getMicrotimeDateTime(); |
|
| 47 | |||
| 48 | 1 | $recordTimings = $this->container->getParameter('dtc_queue.timings.record'); |
|
| 49 | 1 | $params = []; |
|
| 50 | 1 | if ($recordTimings) { |
|
| 51 | 1 | $params = $this->calculateTimings($type, $beginDate, $endDate); |
|
| 52 | } |
||
| 53 | |||
| 54 | 1 | return new JsonResponse($params); |
|
| 55 | } |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @param \DateTime|null $beginDate |
||
| 59 | * @param \DateTime $endDate |
||
| 60 | */ |
||
| 61 | 1 | protected function calculateTimings($type, $beginDate, $endDate) |
|
| 62 | { |
||
| 63 | 1 | $params = []; |
|
| 64 | 1 | $this->validateJobTimingManager(); |
|
| 65 | |||
| 66 | /** @var DoctrineJobTimingManager $jobTimingManager */ |
||
| 67 | 1 | $jobTimingManager = $this->get('dtc_queue.manager.job_timing'); |
|
| 68 | 1 | if ($jobTimingManager instanceof JobTimingManager) { |
|
| 69 | 1 | $timings = $this->getJobTimingsOdm($type, $endDate, $beginDate); |
|
| 70 | } else { |
||
| 71 | 1 | $timings = $this->getJobTimingsOrm($type, $endDate, $beginDate); |
|
| 72 | } |
||
| 73 | |||
| 74 | 1 | $timingStates = JobTiming::getStates(); |
|
| 75 | 1 | $timingsDates = []; |
|
| 76 | 1 | foreach (array_keys($timingStates) as $state) { |
|
| 77 | 1 | if (!isset($timings[$state])) { |
|
| 78 | 1 | continue; |
|
| 79 | } |
||
| 80 | 1 | $timingsData = $timings[$state]; |
|
| 81 | 1 | $timingsDates = array_unique(array_merge(array_keys($timingsData), $timingsDates)); |
|
| 82 | } |
||
| 83 | |||
| 84 | 1 | $format = $this->getDateFormat($type); |
|
| 85 | 1 | usort($timingsDates, function ($date1str, $date2str) use ($format) { |
|
| 86 | $date1 = \DateTime::createFromFormat($format, $date1str, new \DateTimeZone(date_default_timezone_get())); |
||
| 87 | $date2 = \DateTime::createFromFormat($format, $date2str, new \DateTimeZone(date_default_timezone_get())); |
||
| 88 | if (!$date2) { |
||
| 89 | return false; |
||
| 90 | } |
||
| 91 | if (!$date1) { |
||
| 92 | return false; |
||
| 93 | } |
||
| 94 | |||
| 95 | return $date1 > $date2; |
||
| 96 | 1 | }); |
|
| 97 | |||
| 98 | 1 | $timingsDatesAdjusted = $this->getTimingsDatesAdjusted($timingsDates, $format); |
|
| 99 | 1 | $this->setTimingsData($timingStates, $timings, $timingsDates, $params); |
|
| 100 | 1 | $params['timings_dates'] = $timingsDates; |
|
| 101 | 1 | $params['timings_dates_rfc3339'] = $timingsDatesAdjusted; |
|
| 102 | |||
| 103 | 1 | return $params; |
|
| 104 | } |
||
| 105 | |||
| 106 | /** |
||
| 107 | * Timings offset by timezone if necessary. |
||
| 108 | * |
||
| 109 | * @param array $timingsDates |
||
| 110 | * @param string $format |
||
| 111 | * |
||
| 112 | * @return array |
||
| 113 | */ |
||
| 114 | 1 | protected function getTimingsDatesAdjusted(array $timingsDates, $format) |
|
| 115 | { |
||
| 116 | 1 | $timezoneOffset = $this->container->getParameter('dtc_queue.timings.timezone_offset'); |
|
| 117 | 1 | $timingsDatesAdjusted = []; |
|
| 118 | 1 | foreach ($timingsDates as $dateStr) { |
|
| 119 | 1 | $date = \DateTime::createFromFormat($format, $dateStr, new \DateTimeZone(date_default_timezone_get())); |
|
| 120 | 1 | if (0 !== $timezoneOffset) { |
|
| 121 | // This may too simplistic in areas that observe DST - does the database or PHP code observe DST? |
||
| 122 | $date->setTimestamp($date->getTimestamp() + ($timezoneOffset * 3600)); |
||
| 123 | } |
||
| 124 | 1 | if (false === $date) { |
|
| 125 | throw new \InvalidArgumentException("'$date' is not in the right format: ".DATE_RFC3339); |
||
| 126 | } |
||
| 127 | 1 | $timingsDatesAdjusted[] = $date->format(DATE_RFC3339); |
|
| 128 | } |
||
| 129 | |||
| 130 | 1 | return $timingsDatesAdjusted; |
|
| 131 | } |
||
| 132 | |||
| 133 | 1 | protected function setTimingsData(array $timingStates, array $timings, array $timingsDates, array &$params) |
|
| 134 | { |
||
| 135 | 1 | foreach (array_keys($timingStates) as $state) { |
|
| 136 | 1 | if (!isset($timings[$state])) { |
|
| 137 | 1 | continue; |
|
| 138 | } |
||
| 139 | |||
| 140 | 1 | $timingsData = $timings[$state]; |
|
| 141 | 1 | foreach ($timingsDates as $date) { |
|
| 142 | 1 | $params['timings_data_'.$state][] = isset($timingsData[$date]) ? $timingsData[$date] : 0; |
|
| 143 | } |
||
| 144 | } |
||
| 145 | 1 | } |
|
| 146 | |||
| 147 | /** |
||
| 148 | * @param string $type |
||
| 149 | * @param \Doctrine\ODM\MongoDB\Aggregation\Expr $expr |
||
| 150 | * @return mixed |
||
| 151 | */ |
||
| 152 | 1 | protected function addJobTimingsDateInfo($type, $expr) { |
|
| 153 | 1 | switch ($type) { |
|
| 154 | 1 | case 'YEAR': |
|
| 155 | 1 | return $expr->field('year') |
|
| 156 | 1 | ->year('$finishedAt'); |
|
| 157 | 1 | case 'MONTH': |
|
| 158 | 1 | return $expr->field('year') |
|
| 159 | 1 | ->year('$finishedAt') |
|
| 160 | 1 | ->field('month') |
|
| 161 | 1 | ->month('$finishedAt'); |
|
| 162 | 1 | case 'DAY': |
|
| 163 | 1 | return $expr->field('year') |
|
| 164 | 1 | ->year('$finishedAt') |
|
| 165 | 1 | ->field('month') |
|
| 166 | 1 | ->month('$finishedAt') |
|
| 167 | 1 | ->field('day') |
|
| 168 | 1 | ->dayOfMonth('$finishedAt'); |
|
| 169 | 1 | case 'HOUR': |
|
| 170 | 1 | return $expr->field('year') |
|
| 171 | 1 | ->year('$finishedAt') |
|
| 172 | 1 | ->field('month') |
|
| 173 | 1 | ->month('$finishedAt') |
|
| 174 | 1 | ->field('day') |
|
| 175 | 1 | ->dayOfMonth('$finishedAt') |
|
| 176 | 1 | ->field('hour') |
|
| 177 | 1 | ->hour('$finishedAt'); |
|
| 178 | 1 | case 'MINUTE': |
|
| 179 | 1 | return $expr->field('year') |
|
| 180 | 1 | ->year('$finishedAt') |
|
| 181 | 1 | ->field('month') |
|
| 182 | 1 | ->month('$finishedAt') |
|
| 183 | 1 | ->field('day') |
|
| 184 | 1 | ->dayOfMonth('$finishedAt') |
|
| 185 | 1 | ->field('hour') |
|
| 186 | 1 | ->hour('$finishedAt') |
|
| 187 | 1 | ->field('minute') |
|
| 188 | 1 | ->minute('$finishedAt'); |
|
| 189 | default: |
||
| 190 | throw new \InvalidArgumentException("Unknown type $type"); |
||
| 191 | } |
||
| 192 | } |
||
| 193 | |||
| 194 | protected function getJobTImingsOdmMapReduce($builder, $type, \DateTime $end, \DateTime $begin = null) { |
||
| 225 | } |
||
| 226 | |||
| 227 | 1 | protected function getJobTimingsOdm($type, \DateTime $end, \DateTime $begin = null) |
|
| 271 | } |
||
| 272 | |||
| 273 | /** |
||
| 274 | * Formats the aggregation result into the desired date string format. |
||
| 275 | * @param string $type |
||
| 276 | * @param array $result |
||
| 277 | * @return string |
||
| 278 | */ |
||
| 279 | 1 | protected function getAggregationResultDateStr($type, array $result) |
|
| 280 | { |
||
| 281 | 1 | switch ($type) { |
|
| 282 | 1 | case 'YEAR': |
|
| 283 | 1 | return $result['year']; |
|
| 284 | 1 | case 'MONTH': |
|
| 285 | 1 | return "{$result['year']}-" . str_pad($result['month'], 2, "0", STR_PAD_LEFT); |
|
| 286 | 1 | case 'DAY': |
|
| 287 | 1 | $str = "{$result['year']}-" . str_pad($result['month'], 2, "0", STR_PAD_LEFT); |
|
| 288 | 1 | $str .= '-' . str_pad($result['day'], 2, "0", STR_PAD_LEFT); |
|
| 289 | 1 | return $str; |
|
| 290 | 1 | case 'HOUR': |
|
| 291 | 1 | $str = "{$result['year']}-" . str_pad($result['month'], 2, "0", STR_PAD_LEFT); |
|
| 292 | 1 | $str .= '-' . str_pad($result['day'], 2, "0", STR_PAD_LEFT); |
|
| 293 | 1 | $str .= ' ' . str_pad($result['hour'], 2, "0", STR_PAD_LEFT); |
|
| 294 | 1 | return $str; |
|
| 295 | 1 | case 'MINUTE': |
|
| 296 | 1 | $str = "{$result['year']}-" . str_pad($result['month'], 2, "0", STR_PAD_LEFT); |
|
| 297 | 1 | $str .= '-' . str_pad($result['day'], 2, "0", STR_PAD_LEFT); |
|
| 298 | 1 | $str .= ' ' . str_pad($result['hour'], 2, "0", STR_PAD_LEFT); |
|
| 299 | 1 | $str .= ':' . str_pad($result['minute'], 2, "0", STR_PAD_LEFT); |
|
| 300 | 1 | return $str; |
|
| 301 | default: |
||
| 302 | throw new \InvalidArgumentException("Invalid date format type '$type''"); |
||
| 303 | } |
||
| 304 | } |
||
| 305 | |||
| 306 | 1 | protected function getDateFormat($type) |
|
| 321 | } |
||
| 322 | } |
||
| 323 | |||
| 324 | 1 | protected function getRegexDate($type) |
|
| 325 | { |
||
| 326 | 1 | switch ($type) { |
|
| 327 | 1 | case 'YEAR': |
|
| 328 | 1 | return ['replace' => ['regex' => '(\d+)\-(\d+)\-(\d+)T(\d+):(\d+):(\d+).+$', 'replacement' => '$1'], |
|
| 329 | 1 | 'interval' => new \DateInterval('P10Y'), ]; |
|
| 330 | 1 | case 'MONTH': |
|
| 331 | 1 | return ['replace' => ['regex' => '(\d+)\-(\d+)\-(\d+)T(\d+):(\d+):(\d+).+$', 'replacement' => '$1-$2'], |
|
| 332 | 1 | 'interval' => new \DateInterval('P12M'), ]; |
|
| 333 | 1 | case 'DAY': |
|
| 334 | 1 | return ['replace' => ['regex' => '(\d+)\-(\d+)\-(\d+)T(\d+):(\d+):(\d+).+$', 'replacement' => '$1-$2-$3'], |
|
| 335 | 1 | 'interval' => new \DateInterval('P31D'), ]; |
|
| 336 | 1 | case 'HOUR': |
|
| 337 | 1 | return ['replace' => ['regex' => '(\d+)\-(\d+)\-(\d+)T(\d+):(\d+):(\d+).+$', 'replacement' => '$1-$2-$3 $4'], |
|
| 338 | 1 | 'interval' => new \DateInterval('PT24H'), ]; |
|
| 339 | 1 | case 'MINUTE': |
|
| 340 | 1 | return ['replace' => ['regex' => '(\d+)\-(\d+)\-(\d+)T(\d+):(\d+):(\d+).+$', 'replacement' => '$1-$2-$3 $4:$5'], |
|
| 341 | 1 | 'interval' => new \DateInterval('PT3600S'), ]; |
|
| 342 | } |
||
| 343 | throw new \InvalidArgumentException("Invalid type $type"); |
||
| 344 | } |
||
| 345 | |||
| 346 | 1 | protected function getOrmGroupBy($type) |
|
| 366 | } |
||
| 367 | |||
| 368 | 1 | protected function getJobTimingsOrm($type, \DateTime $end, \DateTime $begin = null) |
|
| 369 | { |
||
| 370 | /** @var JobTimingManager $jobTimingManager */ |
||
| 371 | 1 | $jobTimingManager = $this->get('dtc_queue.manager.job_timing'); |
|
| 372 | 1 | $jobTimingClass = $jobTimingManager->getJobTimingClass(); |
|
| 373 | /** @var EntityManager $entityManager */ |
||
| 374 | 1 | $entityManager = $jobTimingManager->getObjectManager(); |
|
| 375 | |||
| 376 | 1 | $groupByInfo = $this->getOrmGroupBy($type); |
|
| 377 | |||
| 378 | 1 | if (!$begin) { |
|
| 379 | 1 | $begin = clone $end; |
|
| 380 | 1 | $begin->sub($groupByInfo['interval']); |
|
| 381 | } |
||
| 382 | |||
| 383 | 1 | $queryBuilder = $entityManager->createQueryBuilder()->select("j.status as status, count(j.finishedAt) as thecount, {$groupByInfo['groupby']} as thedate") |
|
| 384 | 1 | ->from($jobTimingClass, 'j') |
|
| 385 | 1 | ->where('j.finishedAt <= :end') |
|
| 386 | 1 | ->andWhere('j.finishedAt >= :begin') |
|
| 387 | 1 | ->setParameter(':end', $end) |
|
| 388 | 1 | ->setParameter(':begin', $begin) |
|
| 389 | 1 | ->groupBy('status') |
|
| 390 | 1 | ->addGroupBy('thedate'); |
|
| 391 | |||
| 392 | $result = $queryBuilder |
||
| 393 | 1 | ->getQuery()->getArrayResult(); |
|
| 394 | |||
| 395 | 1 | $resultHash = []; |
|
| 396 | 1 | foreach ($result as $row) { |
|
| 397 | 1 | $date = $this->formatOrmDateTime($type, $row['thedate']); |
|
| 398 | 1 | $resultHash[$row['status']][$date] = intval($row['thecount']); |
|
| 399 | } |
||
| 400 | |||
| 401 | 1 | return $resultHash; |
|
| 402 | } |
||
| 403 | |||
| 404 | 1 | protected function strPadLeft($str) |
|
| 405 | { |
||
| 406 | 1 | return str_pad($str, 2, '0', STR_PAD_LEFT); |
|
| 407 | } |
||
| 408 | |||
| 409 | 1 | protected function formatOrmDateTime($type, $str) |
|
| 434 | } |
||
| 435 | } |
||
| 436 |
Loading history...